SUNRPC: eliminate rpc_call()

Clean-up: replace rpc_call() helper with direct call to rpc_call_sync.

This makes NFSv2 and NFSv3 synchronous calls more computationally
efficient, and reduces stack consumption in functions that used to
invoke rpc_call more than once.

Test plan:
Compile kernel with CONFIG_NFS enabled.  Connectathon on NFS version 2,
version 3, and version 4 mount points.

Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

1 files changed, 22 insertions, 12 deletions

diff --git a/net/sunrpc/pmap_clnt.c b/net/sunrpc/pmap_clnt.c
index efa00bd9ff9e..d25b054ec921 100644
--- a/net/sunrpc/pmap_clnt.c
+++ b/net/sunrpc/pmap_clnt.c
@@ -104,6 +104,11 @@ rpc_getport_external(struct sockaddr_in *sin, __u32 prog, __u32 vers, int prot)
                 .pm_prot        = prot,
                 .pm_port        = 0
         };
+        struct rpc_message msg = {
+                .rpc_proc       = &pmap_procedures[PMAP_GETPORT],
+                .rpc_argp       = &map,
+                .rpc_resp       = &map.pm_port,
+        };
         struct rpc_clnt *pmap_clnt;
         char            hostname[32];
         int             status;
@@ -117,7 +122,7 @@ rpc_getport_external(struct sockaddr_in *sin, __u32 prog, __u32 vers, int prot)
                 return PTR_ERR(pmap_clnt);
 
         /* Setup the call info struct */
-        status = rpc_call(pmap_clnt, PMAP_GETPORT, &map, &map.pm_port, 0);
+        status = rpc_call_sync(pmap_clnt, &msg, 0);
 
         if (status >= 0) {
                 if (map.pm_port != 0)
@@ -162,16 +167,27 @@ pmap_getport_done(struct rpc_task *task)
 int
 rpc_register(u32 prog, u32 vers, int prot, unsigned short port, int *okay)
 {
-        struct sockaddr_in      sin;
-        struct rpc_portmap      map;
+        struct sockaddr_in      sin = {
+                .sin_family     = AF_INET,
+                .sin_addr.s_addr = htonl(INADDR_LOOPBACK),
+        };
+        struct rpc_portmap      map = {
+                .pm_prog        = prog,
+                .pm_vers        = vers,
+                .pm_prot        = prot,
+                .pm_port        = port,
+        };
+        struct rpc_message msg = {
+                .rpc_proc       = &pmap_procedures[port ? PMAP_SET : PMAP_UNSET],
+                .rpc_argp       = &map,
+                .rpc_resp       = okay,
+        };
         struct rpc_clnt         *pmap_clnt;
         int error = 0;
 
         dprintk("RPC: registering (%d, %d, %d, %d) with portmapper.\n",
                         prog, vers, prot, port);
 
-        sin.sin_family = AF_INET;
-        sin.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
         pmap_clnt = pmap_create("localhost", &sin, IPPROTO_UDP, 1);
         if (IS_ERR(pmap_clnt)) {
                 error = PTR_ERR(pmap_clnt);
@@ -179,13 +195,7 @@ rpc_register(u32 prog, u32 vers, int prot, unsigned short port, int *okay)
                 return error;
         }
 
-        map.pm_prog = prog;
-        map.pm_vers = vers;
-        map.pm_prot = prot;
-        map.pm_port = port;
-
-        error = rpc_call(pmap_clnt, port? PMAP_SET : PMAP_UNSET,
-                                        &map, okay, 0);
+        error = rpc_call_sync(pmap_clnt, &msg, 0);
 
         if (error < 0) {
                 printk(KERN_WARNING