aboutsummaryrefslogtreecommitdiffstats
path: root/net/sunrpc/auth.c
diff options
context:
space:
mode:
authorTrond Myklebust <Trond.Myklebust@netapp.com>2008-12-23 15:21:31 -0500
committerTrond Myklebust <Trond.Myklebust@netapp.com>2008-12-23 15:21:31 -0500
commit88a9fe8cae3bb52e82489447f45e8d7ba1409ca8 (patch)
treeacef9d0b7d4c8c2e98faf852ab8bc0173842fbe5 /net/sunrpc/auth.c
parent136221fc3219b3805c48db5da065e8e3467175d4 (diff)
SUNRPC: Remove the last remnant of the BKL...
Somehow, this escaped the previous purge. There should be no need to keep any extra locks in the XDR callbacks. The NFS client XDR code only writes into private objects, whereas all reads of shared objects are confined to fields that do not change, such as filehandles... Ditto for lockd, the NFSv2/v3 client mount code, and rpcbind. The nfsd XDR code may require the BKL, but since it does a synchronous RPC call from a thread that already holds the lock, that issue is moot. Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net/sunrpc/auth.c')
-rw-r--r--net/sunrpc/auth.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
index cb216b2df666..6e28744b1709 100644
--- a/net/sunrpc/auth.c
+++ b/net/sunrpc/auth.c
@@ -513,7 +513,7 @@ rpcauth_wrap_req(struct rpc_task *task, kxdrproc_t encode, void *rqstp,
513 if (cred->cr_ops->crwrap_req) 513 if (cred->cr_ops->crwrap_req)
514 return cred->cr_ops->crwrap_req(task, encode, rqstp, data, obj); 514 return cred->cr_ops->crwrap_req(task, encode, rqstp, data, obj);
515 /* By default, we encode the arguments normally. */ 515 /* By default, we encode the arguments normally. */
516 return rpc_call_xdrproc(encode, rqstp, data, obj); 516 return encode(rqstp, data, obj);
517} 517}
518 518
519int 519int
@@ -528,7 +528,7 @@ rpcauth_unwrap_resp(struct rpc_task *task, kxdrproc_t decode, void *rqstp,
528 return cred->cr_ops->crunwrap_resp(task, decode, rqstp, 528 return cred->cr_ops->crunwrap_resp(task, decode, rqstp,
529 data, obj); 529 data, obj);
530 /* By default, we decode the arguments normally. */ 530 /* By default, we decode the arguments normally. */
531 return rpc_call_xdrproc(decode, rqstp, data, obj); 531 return decode(rqstp, data, obj);
532} 532}
533 533
534int 534int