net: Remove casts of void *

Unnecessary casts of void * clutter the code.

These are the remainder casts after several specific
patches to remove netdev_priv and dev_priv.

Done via coccinelle script:

$ cat cast_void_pointer.cocci
@@
type T;
T *pt;
void *pv;
@@

- pt = (T *)pv;
+ pt = pv;

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: David S. Miller <davem@conan.davemloft.net>

5 files changed, 21 insertions, 28 deletions

diff --git a/net/sctp/bind_addr.c b/net/sctp/bind_addr.c
index 17d157325b66..4ece451c8d27 100644
--- a/net/sctp/bind_addr.c
+++ b/net/sctp/bind_addr.c
@@ -430,7 +430,7 @@ union sctp_addr *sctp_find_unmatch_addr(struct sctp_bind_addr	*bp,
         list_for_each_entry(laddr, &bp->address_list, list) {
                 addr_buf = (union sctp_addr *)addrs;
                 for (i = 0; i < addrcnt; i++) {
-                        addr = (union sctp_addr *)addr_buf;
+                        addr = addr_buf;
                         af = sctp_get_af_specific(addr->v4.sin_family);
                         if (!af)
                                 break;
diff --git a/net/sctp/input.c b/net/sctp/input.c
index 741ed1648838..b7692aab6e9c 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -510,8 +510,7 @@ struct sock *sctp_err_lookup(int family, struct sk_buff *skb,
          * discard the packet.
          */
         if (vtag == 0) {
-                chunkhdr = (struct sctp_init_chunk *)((void *)sctphdr
-                                + sizeof(struct sctphdr));
+                chunkhdr = (void *)sctphdr + sizeof(struct sctphdr);
                 if (len < sizeof(struct sctphdr) + sizeof(sctp_chunkhdr_t)
                           + sizeof(__be32) ||
                     chunkhdr->chunk_hdr.type != SCTP_CID_INIT ||
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index 3363d3788259..81db4e385352 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -2773,7 +2773,7 @@ struct sctp_chunk *sctp_make_asconf_update_ip(struct sctp_association *asoc,
         /* Get total length of all the address parameters. */
         addr_buf = addrs;
         for (i = 0; i < addrcnt; i++) {
-                addr = (union sctp_addr *)addr_buf;
+                addr = addr_buf;
                 af = sctp_get_af_specific(addr->v4.sin_family);
                 addr_param_len = af->to_addr_param(addr, &addr_param);
 
@@ -2798,7 +2798,7 @@ struct sctp_chunk *sctp_make_asconf_update_ip(struct sctp_association *asoc,
         /* Add the address parameters to the asconf chunk. */
         addr_buf = addrs;
         for (i = 0; i < addrcnt; i++) {
-                addr = (union sctp_addr *)addr_buf;
+                addr = addr_buf;
                 af = sctp_get_af_specific(addr->v4.sin_family);
                 addr_param_len = af->to_addr_param(addr, &addr_param);
                 param.param_hdr.type = flags;
@@ -2958,8 +2958,7 @@ static __be16 sctp_process_asconf_param(struct sctp_association *asoc,
         union sctp_addr addr;
         union sctp_addr_param *addr_param;
 
-        addr_param = (union sctp_addr_param *)
-                        ((void *)asconf_param + sizeof(sctp_addip_param_t));
+        addr_param = (void *)asconf_param + sizeof(sctp_addip_param_t);
 
         if (asconf_param->param_hdr.type != SCTP_PARAM_ADD_IP &&
             asconf_param->param_hdr.type != SCTP_PARAM_DEL_IP &&
@@ -3144,7 +3143,7 @@ struct sctp_chunk *sctp_process_asconf(struct sctp_association *asoc,
          * asconf parameter.
          */
         length = ntohs(addr_param->p.length);
-        asconf_param = (sctp_addip_param_t *)((void *)addr_param + length);
+        asconf_param = (void *)addr_param + length;
         chunk_len -= length;
 
         /* create an ASCONF_ACK chunk.
@@ -3185,8 +3184,7 @@ struct sctp_chunk *sctp_process_asconf(struct sctp_association *asoc,
 
                 /* Move to the next ASCONF param. */
                 length = ntohs(asconf_param->param_hdr.length);
-                asconf_param = (sctp_addip_param_t *)((void *)asconf_param +
-                                                      length);
+                asconf_param = (void *)asconf_param + length;
                 chunk_len -= length;
         }
 
@@ -3216,8 +3214,7 @@ static void sctp_asconf_param_success(struct sctp_association *asoc,
         struct sctp_transport *transport;
         struct sctp_sockaddr_entry *saddr;
 
-        addr_param = (union sctp_addr_param *)
-                        ((void *)asconf_param + sizeof(sctp_addip_param_t));
+        addr_param = (void *)asconf_param + sizeof(sctp_addip_param_t);
 
         /* We have checked the packet before, so we do not check again. */
         af = sctp_get_af_specific(param_type2af(addr_param->p.type));
@@ -3302,8 +3299,7 @@ static __be16 sctp_get_asconf_response(struct sctp_chunk *asconf_ack,
                                 return SCTP_ERROR_NO_ERROR;
                         case SCTP_PARAM_ERR_CAUSE:
                                 length = sizeof(sctp_addip_param_t);
-                                err_param = (sctp_errhdr_t *)
-                                           ((void *)asconf_ack_param + length);
+                                err_param = (void *)asconf_ack_param + length;
                                 asconf_ack_len -= length;
                                 if (asconf_ack_len > 0)
                                         return err_param->cause;
@@ -3316,8 +3312,7 @@ static __be16 sctp_get_asconf_response(struct sctp_chunk *asconf_ack,
                 }
 
                 length = ntohs(asconf_ack_param->param_hdr.length);
-                asconf_ack_param = (sctp_addip_param_t *)
-                                        ((void *)asconf_ack_param + length);
+                asconf_ack_param = (void *)asconf_ack_param + length;
                 asconf_ack_len -= length;
         }
 
@@ -3349,7 +3344,7 @@ int sctp_process_asconf_ack(struct sctp_association *asoc,
          * pointer to the first asconf parameter.
          */
         length = ntohs(addr_param->p.length);
-        asconf_param = (sctp_addip_param_t *)((void *)addr_param + length);
+        asconf_param = (void *)addr_param + length;
         asconf_len -= length;
 
         /* ADDIP 4.1
@@ -3400,8 +3395,7 @@ int sctp_process_asconf_ack(struct sctp_association *asoc,
                  * one.
                  */
                 length = ntohs(asconf_param->param_hdr.length);
-                asconf_param = (sctp_addip_param_t *)((void *)asconf_param +
-                                                      length);
+                asconf_param = (void *)asconf_param + length;
                 asconf_len -= length;
         }
 
diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index 534c2e5feb05..1b2bb6487342 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -1201,7 +1201,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
         int local_cork = 0;
 
         if (SCTP_EVENT_T_TIMEOUT != event_type)
-                chunk = (struct sctp_chunk *) event_arg;
+                chunk = event_arg;
 
         /* Note:  This whole file is a huge candidate for rework.
          * For example, each command could either have its own handler, so
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 60038fef3ba1..fd31b3616a33 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -476,7 +476,7 @@ static int sctp_bindx_add(struct sock *sk, struct sockaddr *addrs, int addrcnt)
                 /* The list may contain either IPv4 or IPv6 address;
                  * determine the address length for walking thru the list.
                  */
-                sa_addr = (struct sockaddr *)addr_buf;
+                sa_addr = addr_buf;
                 af = sctp_get_af_specific(sa_addr->sa_family);
                 if (!af) {
                         retval = -EINVAL;
@@ -555,7 +555,7 @@ static int sctp_send_asconf_add_ip(struct sock		*sk,
                  */
                 addr_buf = addrs;
                 for (i = 0; i < addrcnt; i++) {
-                        addr = (union sctp_addr *)addr_buf;
+                        addr = addr_buf;
                         af = sctp_get_af_specific(addr->v4.sin_family);
                         if (!af) {
                                 retval = -EINVAL;
@@ -588,7 +588,7 @@ static int sctp_send_asconf_add_ip(struct sock		*sk,
                  */
                 addr_buf = addrs;
                 for (i = 0; i < addrcnt; i++) {
-                        addr = (union sctp_addr *)addr_buf;
+                        addr = addr_buf;
                         af = sctp_get_af_specific(addr->v4.sin_family);
                         memcpy(&saveaddr, addr, af->sockaddr_len);
                         retval = sctp_add_bind_addr(bp, &saveaddr,
@@ -659,7 +659,7 @@ static int sctp_bindx_rem(struct sock *sk, struct sockaddr *addrs, int addrcnt)
                         goto err_bindx_rem;
                 }
 
-                sa_addr = (union sctp_addr *)addr_buf;
+                sa_addr = addr_buf;
                 af = sctp_get_af_specific(sa_addr->sa.sa_family);
                 if (!af) {
                         retval = -EINVAL;
@@ -758,7 +758,7 @@ static int sctp_send_asconf_del_ip(struct sock		*sk,
                  */
                 addr_buf = addrs;
                 for (i = 0; i < addrcnt; i++) {
-                        laddr = (union sctp_addr *)addr_buf;
+                        laddr = addr_buf;
                         af = sctp_get_af_specific(laddr->v4.sin_family);
                         if (!af) {
                                 retval = -EINVAL;
@@ -830,7 +830,7 @@ skip_mkasconf:
                  */
                 addr_buf = addrs;
                 for (i = 0; i < addrcnt; i++) {
-                        laddr = (union sctp_addr *)addr_buf;
+                        laddr = addr_buf;
                         af = sctp_get_af_specific(laddr->v4.sin_family);
                         list_for_each_entry(saddr, &bp->address_list, list) {
                                 if (sctp_cmp_addr_exact(&saddr->a, laddr))
@@ -997,7 +997,7 @@ SCTP_STATIC int sctp_setsockopt_bindx(struct sock* sk,
                         return -EINVAL;
                 }
 
-                sa_addr = (struct sockaddr *)addr_buf;
+                sa_addr = addr_buf;
                 af = sctp_get_af_specific(sa_addr->sa_family);
 
                 /* If the address family is not supported or if this address
@@ -1088,7 +1088,7 @@ static int __sctp_connect(struct sock* sk,
                         goto out_free;
                 }
 
-                sa_addr = (union sctp_addr *)addr_buf;
+                sa_addr = addr_buf;
                 af = sctp_get_af_specific(sa_addr->sa.sa_family);
 
                 /* If the address family is not supported or if this address