diff options
author | Jesper Juhl <jesper.juhl@gmail.com> | 2005-11-08 12:41:34 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2005-11-08 12:41:34 -0500 |
commit | a51482bde22f99c63fbbb57d5d46cc666384e379 (patch) | |
tree | 5482ed1c0803edb2ffbd51035de921fb0f72d82b /net/sctp | |
parent | ac7c98eca88a854755475fcfe1b2bf5f97f90d99 (diff) |
[NET]: kfree cleanup
From: Jesper Juhl <jesper.juhl@gmail.com>
This is the net/ part of the big kfree cleanup patch.
Remove pointless checks for NULL prior to calling kfree() in net/.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Diffstat (limited to 'net/sctp')
-rw-r--r-- | net/sctp/associola.c | 4 | ||||
-rw-r--r-- | net/sctp/sm_make_chunk.c | 6 |
2 files changed, 3 insertions, 7 deletions
diff --git a/net/sctp/associola.c b/net/sctp/associola.c index 12b0f582a66b..8c8ddf7f9b61 100644 --- a/net/sctp/associola.c +++ b/net/sctp/associola.c | |||
@@ -344,9 +344,7 @@ void sctp_association_free(struct sctp_association *asoc) | |||
344 | } | 344 | } |
345 | 345 | ||
346 | /* Free peer's cached cookie. */ | 346 | /* Free peer's cached cookie. */ |
347 | if (asoc->peer.cookie) { | 347 | kfree(asoc->peer.cookie); |
348 | kfree(asoc->peer.cookie); | ||
349 | } | ||
350 | 348 | ||
351 | /* Release the transport structures. */ | 349 | /* Release the transport structures. */ |
352 | list_for_each_safe(pos, temp, &asoc->peer.transport_addr_list) { | 350 | list_for_each_safe(pos, temp, &asoc->peer.transport_addr_list) { |
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c index 660c61bdf164..f9573eba5c7a 100644 --- a/net/sctp/sm_make_chunk.c +++ b/net/sctp/sm_make_chunk.c | |||
@@ -254,8 +254,7 @@ struct sctp_chunk *sctp_make_init(const struct sctp_association *asoc, | |||
254 | aiparam.adaption_ind = htonl(sp->adaption_ind); | 254 | aiparam.adaption_ind = htonl(sp->adaption_ind); |
255 | sctp_addto_chunk(retval, sizeof(aiparam), &aiparam); | 255 | sctp_addto_chunk(retval, sizeof(aiparam), &aiparam); |
256 | nodata: | 256 | nodata: |
257 | if (addrs.v) | 257 | kfree(addrs.v); |
258 | kfree(addrs.v); | ||
259 | return retval; | 258 | return retval; |
260 | } | 259 | } |
261 | 260 | ||
@@ -347,8 +346,7 @@ struct sctp_chunk *sctp_make_init_ack(const struct sctp_association *asoc, | |||
347 | nomem_chunk: | 346 | nomem_chunk: |
348 | kfree(cookie); | 347 | kfree(cookie); |
349 | nomem_cookie: | 348 | nomem_cookie: |
350 | if (addrs.v) | 349 | kfree(addrs.v); |
351 | kfree(addrs.v); | ||
352 | return retval; | 350 | return retval; |
353 | } | 351 | } |
354 | 352 | ||