aboutsummaryrefslogtreecommitdiffstats
path: root/net/sctp
diff options
context:
space:
mode:
authorVlad Yasevich <vladislav.yasevich@hp.com>2008-06-09 18:45:05 -0400
committerDavid S. Miller <davem@davemloft.net>2008-06-09 18:45:05 -0400
commit7bfe8bdb80d5988483b01177b09b9c8d1605dffb (patch)
treea18463ac461bd213876771e0b0d2bc3957afc726 /net/sctp
parent9457afee85e0dfc2b5075a391d6f34463b4c2b90 (diff)
sctp: Fix problems with the new SCTP_DELAYED_ACK code
The default sack frequency should be 2. Also fix copy/paste error when updating all transports. Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
-rw-r--r--net/sctp/socket.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 81600eea05d2..253e5ea7e1e8 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -2471,7 +2471,7 @@ static int sctp_setsockopt_delayed_ack(struct sock *sk,
2471 (trans->param_flags & ~SPP_SACKDELAY) | 2471 (trans->param_flags & ~SPP_SACKDELAY) |
2472 SPP_SACKDELAY_ENABLE; 2472 SPP_SACKDELAY_ENABLE;
2473 } 2473 }
2474 if (params.sack_delay == 1) { 2474 if (params.sack_freq == 1) {
2475 trans->param_flags = 2475 trans->param_flags =
2476 (trans->param_flags & ~SPP_SACKDELAY) | 2476 (trans->param_flags & ~SPP_SACKDELAY) |
2477 SPP_SACKDELAY_DISABLE; 2477 SPP_SACKDELAY_DISABLE;
@@ -3536,7 +3536,7 @@ SCTP_STATIC int sctp_init_sock(struct sock *sk)
3536 sp->pathmaxrxt = sctp_max_retrans_path; 3536 sp->pathmaxrxt = sctp_max_retrans_path;
3537 sp->pathmtu = 0; // allow default discovery 3537 sp->pathmtu = 0; // allow default discovery
3538 sp->sackdelay = sctp_sack_timeout; 3538 sp->sackdelay = sctp_sack_timeout;
3539 sp->sackfreq = 3; 3539 sp->sackfreq = 2;
3540 sp->param_flags = SPP_HB_ENABLE | 3540 sp->param_flags = SPP_HB_ENABLE |
3541 SPP_PMTUD_ENABLE | 3541 SPP_PMTUD_ENABLE |
3542 SPP_SACKDELAY_ENABLE; 3542 SPP_SACKDELAY_ENABLE;