diff options
author | Joe Perches <joe@perches.com> | 2006-01-13 17:29:07 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2006-01-13 17:29:07 -0500 |
commit | 46b86a2da0fd14bd49765330df63a62279833acb (patch) | |
tree | 069b4741a970db9b03772a870b4d63398b1f56e0 /net/sctp/ipv6.c | |
parent | 23b0ca5bf52cef0ab0f0fe247cb91cbef836e7eb (diff) |
[NET]: Use NIP6_FMT in kernel.h
There are errors and inconsistency in the display of NIP6 strings.
ie: net/ipv6/ip6_flowlabel.c
There are errors and inconsistency in the display of NIPQUAD strings too.
ie: net/netfilter/nf_conntrack_ftp.c
This patch:
adds NIP6_FMT to kernel.h
changes all code to use NIP6_FMT
fixes net/ipv6/ip6_flowlabel.c
adds NIPQUAD_FMT to kernel.h
fixes net/netfilter/nf_conntrack_ftp.c
changes a few uses of "%u.%u.%u.%u" to NIPQUAD_FMT for symmetry to NIP6_FMT
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/ipv6.c')
-rw-r--r-- | net/sctp/ipv6.c | 24 |
1 files changed, 9 insertions, 15 deletions
diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c index 04c7fab4edc4..2e266129a764 100644 --- a/net/sctp/ipv6.c +++ b/net/sctp/ipv6.c | |||
@@ -180,8 +180,7 @@ static int sctp_v6_xmit(struct sk_buff *skb, struct sctp_transport *transport, | |||
180 | } | 180 | } |
181 | 181 | ||
182 | SCTP_DEBUG_PRINTK("%s: skb:%p, len:%d, " | 182 | SCTP_DEBUG_PRINTK("%s: skb:%p, len:%d, " |
183 | "src:%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x " | 183 | "src:" NIP6_FMT " dst:" NIP6_FMT "\n", |
184 | "dst:%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x\n", | ||
185 | __FUNCTION__, skb, skb->len, | 184 | __FUNCTION__, skb, skb->len, |
186 | NIP6(fl.fl6_src), NIP6(fl.fl6_dst)); | 185 | NIP6(fl.fl6_src), NIP6(fl.fl6_dst)); |
187 | 186 | ||
@@ -206,13 +205,13 @@ static struct dst_entry *sctp_v6_get_dst(struct sctp_association *asoc, | |||
206 | fl.oif = daddr->v6.sin6_scope_id; | 205 | fl.oif = daddr->v6.sin6_scope_id; |
207 | 206 | ||
208 | 207 | ||
209 | SCTP_DEBUG_PRINTK("%s: DST=%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x ", | 208 | SCTP_DEBUG_PRINTK("%s: DST=" NIP6_FMT " ", |
210 | __FUNCTION__, NIP6(fl.fl6_dst)); | 209 | __FUNCTION__, NIP6(fl.fl6_dst)); |
211 | 210 | ||
212 | if (saddr) { | 211 | if (saddr) { |
213 | ipv6_addr_copy(&fl.fl6_src, &saddr->v6.sin6_addr); | 212 | ipv6_addr_copy(&fl.fl6_src, &saddr->v6.sin6_addr); |
214 | SCTP_DEBUG_PRINTK( | 213 | SCTP_DEBUG_PRINTK( |
215 | "SRC=%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x - ", | 214 | "SRC=" NIP6_FMT " - ", |
216 | NIP6(fl.fl6_src)); | 215 | NIP6(fl.fl6_src)); |
217 | } | 216 | } |
218 | 217 | ||
@@ -221,8 +220,7 @@ static struct dst_entry *sctp_v6_get_dst(struct sctp_association *asoc, | |||
221 | struct rt6_info *rt; | 220 | struct rt6_info *rt; |
222 | rt = (struct rt6_info *)dst; | 221 | rt = (struct rt6_info *)dst; |
223 | SCTP_DEBUG_PRINTK( | 222 | SCTP_DEBUG_PRINTK( |
224 | "rt6_dst:%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x " | 223 | "rt6_dst:" NIP6_FMT " rt6_src:" NIP6_FMT "\n", |
225 | "rt6_src:%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x\n", | ||
226 | NIP6(rt->rt6i_dst.addr), NIP6(rt->rt6i_src.addr)); | 224 | NIP6(rt->rt6i_dst.addr), NIP6(rt->rt6i_src.addr)); |
227 | } else { | 225 | } else { |
228 | SCTP_DEBUG_PRINTK("NO ROUTE\n"); | 226 | SCTP_DEBUG_PRINTK("NO ROUTE\n"); |
@@ -271,13 +269,12 @@ static void sctp_v6_get_saddr(struct sctp_association *asoc, | |||
271 | __u8 bmatchlen; | 269 | __u8 bmatchlen; |
272 | 270 | ||
273 | SCTP_DEBUG_PRINTK("%s: asoc:%p dst:%p " | 271 | SCTP_DEBUG_PRINTK("%s: asoc:%p dst:%p " |
274 | "daddr:%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x ", | 272 | "daddr:" NIP6_FMT " ", |
275 | __FUNCTION__, asoc, dst, NIP6(daddr->v6.sin6_addr)); | 273 | __FUNCTION__, asoc, dst, NIP6(daddr->v6.sin6_addr)); |
276 | 274 | ||
277 | if (!asoc) { | 275 | if (!asoc) { |
278 | ipv6_get_saddr(dst, &daddr->v6.sin6_addr,&saddr->v6.sin6_addr); | 276 | ipv6_get_saddr(dst, &daddr->v6.sin6_addr,&saddr->v6.sin6_addr); |
279 | SCTP_DEBUG_PRINTK("saddr from ipv6_get_saddr: " | 277 | SCTP_DEBUG_PRINTK("saddr from ipv6_get_saddr: " NIP6_FMT "\n", |
280 | "%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x\n", | ||
281 | NIP6(saddr->v6.sin6_addr)); | 278 | NIP6(saddr->v6.sin6_addr)); |
282 | return; | 279 | return; |
283 | } | 280 | } |
@@ -305,13 +302,11 @@ static void sctp_v6_get_saddr(struct sctp_association *asoc, | |||
305 | 302 | ||
306 | if (baddr) { | 303 | if (baddr) { |
307 | memcpy(saddr, baddr, sizeof(union sctp_addr)); | 304 | memcpy(saddr, baddr, sizeof(union sctp_addr)); |
308 | SCTP_DEBUG_PRINTK("saddr: " | 305 | SCTP_DEBUG_PRINTK("saddr: " NIP6_FMT "\n", |
309 | "%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x\n", | ||
310 | NIP6(saddr->v6.sin6_addr)); | 306 | NIP6(saddr->v6.sin6_addr)); |
311 | } else { | 307 | } else { |
312 | printk(KERN_ERR "%s: asoc:%p Could not find a valid source " | 308 | printk(KERN_ERR "%s: asoc:%p Could not find a valid source " |
313 | "address for the " | 309 | "address for the dest:" NIP6_FMT "\n", |
314 | "dest:%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x\n", | ||
315 | __FUNCTION__, asoc, NIP6(daddr->v6.sin6_addr)); | 310 | __FUNCTION__, asoc, NIP6(daddr->v6.sin6_addr)); |
316 | } | 311 | } |
317 | 312 | ||
@@ -675,8 +670,7 @@ static int sctp_v6_is_ce(const struct sk_buff *skb) | |||
675 | /* Dump the v6 addr to the seq file. */ | 670 | /* Dump the v6 addr to the seq file. */ |
676 | static void sctp_v6_seq_dump_addr(struct seq_file *seq, union sctp_addr *addr) | 671 | static void sctp_v6_seq_dump_addr(struct seq_file *seq, union sctp_addr *addr) |
677 | { | 672 | { |
678 | seq_printf(seq, "%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x ", | 673 | seq_printf(seq, NIP6_FMT " ", NIP6(addr->v6.sin6_addr)); |
679 | NIP6(addr->v6.sin6_addr)); | ||
680 | } | 674 | } |
681 | 675 | ||
682 | /* Initialize a PF_INET6 socket msg_name. */ | 676 | /* Initialize a PF_INET6 socket msg_name. */ |