diff options
author | Patrick McHardy <kaber@trash.net> | 2006-03-23 04:16:48 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2006-03-23 04:16:48 -0500 |
commit | 1ae39a430b692552e5aceb63fa35ce95fcbadc6a (patch) | |
tree | 598cfbcff6a1e84f6668d75bc8c92a28f73a381a /net/sched | |
parent | a5cdc030030ef5a16e48aebeb65067bdc3120899 (diff) |
[NET_SCHED]: cls_u32: remove unnecessary NULL-ptr check
In both cases n can't be NULL without crashing anyway.
Coverity #78
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
-rw-r--r-- | net/sched/cls_u32.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 2b670479dde1..78e052591fa9 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c | |||
@@ -347,8 +347,7 @@ static int u32_destroy_key(struct tcf_proto *tp, struct tc_u_knode *n) | |||
347 | if (n->ht_down) | 347 | if (n->ht_down) |
348 | n->ht_down->refcnt--; | 348 | n->ht_down->refcnt--; |
349 | #ifdef CONFIG_CLS_U32_PERF | 349 | #ifdef CONFIG_CLS_U32_PERF |
350 | if (n) | 350 | kfree(n->pf); |
351 | kfree(n->pf); | ||
352 | #endif | 351 | #endif |
353 | kfree(n); | 352 | kfree(n); |
354 | return 0; | 353 | return 0; |
@@ -680,8 +679,7 @@ static int u32_change(struct tcf_proto *tp, unsigned long base, u32 handle, | |||
680 | return 0; | 679 | return 0; |
681 | } | 680 | } |
682 | #ifdef CONFIG_CLS_U32_PERF | 681 | #ifdef CONFIG_CLS_U32_PERF |
683 | if (n) | 682 | kfree(n->pf); |
684 | kfree(n->pf); | ||
685 | #endif | 683 | #endif |
686 | kfree(n); | 684 | kfree(n); |
687 | return err; | 685 | return err; |