diff options
author | David S. Miller <davem@davemloft.net> | 2008-08-18 00:51:03 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-08-18 00:51:03 -0400 |
commit | a9312ae89324438b0edc554eb36c3ec6bf927d04 (patch) | |
tree | 8a440aa75a9ac5aba1447082ec43ed48951aa121 /net/sched | |
parent | 08013fa353fdcfc0a03cae805393abfc56722387 (diff) |
pkt_sched: Add 'deactivated' state.
This new state lets dev_deactivate() mark a qdisc as having been
deactivated.
dev_queue_xmit() and ing_filter() check for this bit and do not
try to process the qdisc if the bit is set.
dev_deactivate() polls the qdisc after setting the bit, waiting
for both __QDISC_STATE_RUNNING and __QDISC_STATE_SCHED to clear.
This isn't perfect yet, but subsequent changesets will make it so.
This part is just one piece of the puzzle.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
-rw-r--r-- | net/sched/sch_generic.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 468574682caa..ff1c4557e5f8 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c | |||
@@ -597,6 +597,9 @@ static void transition_one_qdisc(struct net_device *dev, | |||
597 | struct Qdisc *new_qdisc = dev_queue->qdisc_sleeping; | 597 | struct Qdisc *new_qdisc = dev_queue->qdisc_sleeping; |
598 | int *need_watchdog_p = _need_watchdog; | 598 | int *need_watchdog_p = _need_watchdog; |
599 | 599 | ||
600 | if (!(new_qdisc->flags & TCQ_F_BUILTIN)) | ||
601 | clear_bit(__QDISC_STATE_DEACTIVATED, &new_qdisc->state); | ||
602 | |||
600 | rcu_assign_pointer(dev_queue->qdisc, new_qdisc); | 603 | rcu_assign_pointer(dev_queue->qdisc, new_qdisc); |
601 | if (need_watchdog_p && new_qdisc != &noqueue_qdisc) | 604 | if (need_watchdog_p && new_qdisc != &noqueue_qdisc) |
602 | *need_watchdog_p = 1; | 605 | *need_watchdog_p = 1; |
@@ -640,6 +643,9 @@ static void dev_deactivate_queue(struct net_device *dev, | |||
640 | if (qdisc) { | 643 | if (qdisc) { |
641 | spin_lock_bh(qdisc_lock(qdisc)); | 644 | spin_lock_bh(qdisc_lock(qdisc)); |
642 | 645 | ||
646 | if (!(qdisc->flags & TCQ_F_BUILTIN)) | ||
647 | set_bit(__QDISC_STATE_DEACTIVATED, &qdisc->state); | ||
648 | |||
643 | dev_queue->qdisc = qdisc_default; | 649 | dev_queue->qdisc = qdisc_default; |
644 | qdisc_reset(qdisc); | 650 | qdisc_reset(qdisc); |
645 | 651 | ||