diff options
| author | David S. Miller <davem@davemloft.net> | 2012-03-29 05:11:39 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-04-01 18:11:37 -0400 |
| commit | 1b34ec43c9b3de44a5420841ab293d1b2035a94c (patch) | |
| tree | 8d6cf966c813e0e61001655179b5ef8e5f1b54b3 /net/sched/sch_sfb.c | |
| parent | 9360ffd1859720f6520cf59241909b74dae369d0 (diff) | |
pkt_sched: Stop using NLA_PUT*().
These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_sfb.c')
| -rw-r--r-- | net/sched/sch_sfb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/sched/sch_sfb.c b/net/sched/sch_sfb.c index d7eea99333e9..74305c883bd3 100644 --- a/net/sched/sch_sfb.c +++ b/net/sched/sch_sfb.c | |||
| @@ -570,7 +570,8 @@ static int sfb_dump(struct Qdisc *sch, struct sk_buff *skb) | |||
| 570 | 570 | ||
| 571 | sch->qstats.backlog = q->qdisc->qstats.backlog; | 571 | sch->qstats.backlog = q->qdisc->qstats.backlog; |
| 572 | opts = nla_nest_start(skb, TCA_OPTIONS); | 572 | opts = nla_nest_start(skb, TCA_OPTIONS); |
| 573 | NLA_PUT(skb, TCA_SFB_PARMS, sizeof(opt), &opt); | 573 | if (nla_put(skb, TCA_SFB_PARMS, sizeof(opt), &opt)) |
| 574 | goto nla_put_failure; | ||
| 574 | return nla_nest_end(skb, opts); | 575 | return nla_nest_end(skb, opts); |
| 575 | 576 | ||
| 576 | nla_put_failure: | 577 | nla_put_failure: |