diff options
author | Patrick McHardy <kaber@trash.net> | 2008-01-23 23:33:32 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:11:18 -0500 |
commit | cee63723b358e594225e812d6e14a2a0abfd5c88 (patch) | |
tree | 847f929e0f445cca8cdf55d7c17a56b0d0f2ec68 /net/sched/sch_red.c | |
parent | ab27cfb85c5778400740ad0c401bde65616774eb (diff) |
[NET_SCHED]: Propagate nla_parse return value
nla_parse() returns more detailed errno codes, propagate them back on
error.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_red.c')
-rw-r--r-- | net/sched/sch_red.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/net/sched/sch_red.c b/net/sched/sch_red.c index 6ce8da5aca0b..dcf6afc196f8 100644 --- a/net/sched/sch_red.c +++ b/net/sched/sch_red.c | |||
@@ -207,10 +207,15 @@ static int red_change(struct Qdisc *sch, struct nlattr *opt) | |||
207 | struct nlattr *tb[TCA_RED_MAX + 1]; | 207 | struct nlattr *tb[TCA_RED_MAX + 1]; |
208 | struct tc_red_qopt *ctl; | 208 | struct tc_red_qopt *ctl; |
209 | struct Qdisc *child = NULL; | 209 | struct Qdisc *child = NULL; |
210 | int err; | ||
210 | 211 | ||
211 | if (opt == NULL || nla_parse_nested(tb, TCA_RED_MAX, opt, NULL)) | 212 | if (opt == NULL) |
212 | return -EINVAL; | 213 | return -EINVAL; |
213 | 214 | ||
215 | err = nla_parse_nested(tb, TCA_RED_MAX, opt, NULL); | ||
216 | if (err < 0) | ||
217 | return err; | ||
218 | |||
214 | if (tb[TCA_RED_PARMS] == NULL || | 219 | if (tb[TCA_RED_PARMS] == NULL || |
215 | nla_len(tb[TCA_RED_PARMS]) < sizeof(*ctl) || | 220 | nla_len(tb[TCA_RED_PARMS]) < sizeof(*ctl) || |
216 | tb[TCA_RED_STAB] == NULL || | 221 | tb[TCA_RED_STAB] == NULL || |