diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2007-04-19 23:29:13 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-04-26 01:26:28 -0400 |
commit | 27a884dc3cb63b93c2b3b643f5b31eed5f8a4d26 (patch) | |
tree | 5a267e40f9b94014be38dad5de0a52b6628834e0 /net/sched/sch_netem.c | |
parent | be8bd86321fa7f06359d866ef61fb4d2f3e9dce9 (diff) |
[SK_BUFF]: Convert skb->tail to sk_buff_data_t
So that it is also an offset from skb->head, reduces its size from 8 to 4 bytes
on 64bit architectures, allowing us to combine the 4 bytes hole left by the
layer headers conversion, reducing struct sk_buff size to 256 bytes, i.e. 4
64byte cachelines, and since the sk_buff slab cache is SLAB_HWCACHE_ALIGN...
:-)
Many calculations that previously required that skb->{transport,network,
mac}_header be first converted to a pointer now can be done directly, being
meaningful as offsets or pointers.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_netem.c')
-rw-r--r-- | net/sched/sch_netem.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 915f82a2cc3d..2a9b1e429ff8 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c | |||
@@ -583,7 +583,7 @@ static void netem_destroy(struct Qdisc *sch) | |||
583 | static int netem_dump(struct Qdisc *sch, struct sk_buff *skb) | 583 | static int netem_dump(struct Qdisc *sch, struct sk_buff *skb) |
584 | { | 584 | { |
585 | const struct netem_sched_data *q = qdisc_priv(sch); | 585 | const struct netem_sched_data *q = qdisc_priv(sch); |
586 | unsigned char *b = skb->tail; | 586 | unsigned char *b = skb_tail_pointer(skb); |
587 | struct rtattr *rta = (struct rtattr *) b; | 587 | struct rtattr *rta = (struct rtattr *) b; |
588 | struct tc_netem_qopt qopt; | 588 | struct tc_netem_qopt qopt; |
589 | struct tc_netem_corr cor; | 589 | struct tc_netem_corr cor; |
@@ -611,7 +611,7 @@ static int netem_dump(struct Qdisc *sch, struct sk_buff *skb) | |||
611 | corrupt.correlation = q->corrupt_cor.rho; | 611 | corrupt.correlation = q->corrupt_cor.rho; |
612 | RTA_PUT(skb, TCA_NETEM_CORRUPT, sizeof(corrupt), &corrupt); | 612 | RTA_PUT(skb, TCA_NETEM_CORRUPT, sizeof(corrupt), &corrupt); |
613 | 613 | ||
614 | rta->rta_len = skb->tail - b; | 614 | rta->rta_len = skb_tail_pointer(skb) - b; |
615 | 615 | ||
616 | return skb->len; | 616 | return skb->len; |
617 | 617 | ||