pkt_sched: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 4 insertions, 2 deletions

diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index 9bdca2e011e9..8db3e2c72827 100644
--- a/net/sched/sch_hfsc.c
+++ b/net/sched/sch_hfsc.c
@@ -1305,7 +1305,8 @@ hfsc_dump_sc(struct sk_buff *skb, int attr, struct internal_sc *sc)
         tsc.m1 = sm2m(sc->sm1);
         tsc.d  = dx2d(sc->dx);
         tsc.m2 = sm2m(sc->sm2);
-        NLA_PUT(skb, attr, sizeof(tsc), &tsc);
+        if (nla_put(skb, attr, sizeof(tsc), &tsc))
+                goto nla_put_failure;
 
         return skb->len;
 
@@ -1573,7 +1574,8 @@ hfsc_dump_qdisc(struct Qdisc *sch, struct sk_buff *skb)
         }
 
         qopt.defcls = q->defcls;
-        NLA_PUT(skb, TCA_OPTIONS, sizeof(qopt), &qopt);
+        if (nla_put(skb, TCA_OPTIONS, sizeof(qopt), &qopt))
+                goto nla_put_failure;
         return skb->len;
 
  nla_put_failure: