aboutsummaryrefslogtreecommitdiffstats
path: root/net/sched/sch_hfsc.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2007-04-19 23:29:13 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-04-26 01:26:28 -0400
commit27a884dc3cb63b93c2b3b643f5b31eed5f8a4d26 (patch)
tree5a267e40f9b94014be38dad5de0a52b6628834e0 /net/sched/sch_hfsc.c
parentbe8bd86321fa7f06359d866ef61fb4d2f3e9dce9 (diff)
[SK_BUFF]: Convert skb->tail to sk_buff_data_t
So that it is also an offset from skb->head, reduces its size from 8 to 4 bytes on 64bit architectures, allowing us to combine the 4 bytes hole left by the layer headers conversion, reducing struct sk_buff size to 256 bytes, i.e. 4 64byte cachelines, and since the sk_buff slab cache is SLAB_HWCACHE_ALIGN... :-) Many calculations that previously required that skb->{transport,network, mac}_header be first converted to a pointer now can be done directly, being meaningful as offsets or pointers. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_hfsc.c')
-rw-r--r--net/sched/sch_hfsc.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index 5197b6caaf2d..80e6f811e3bc 100644
--- a/net/sched/sch_hfsc.c
+++ b/net/sched/sch_hfsc.c
@@ -1363,7 +1363,7 @@ hfsc_dump_class(struct Qdisc *sch, unsigned long arg, struct sk_buff *skb,
1363 struct tcmsg *tcm) 1363 struct tcmsg *tcm)
1364{ 1364{
1365 struct hfsc_class *cl = (struct hfsc_class *)arg; 1365 struct hfsc_class *cl = (struct hfsc_class *)arg;
1366 unsigned char *b = skb->tail; 1366 unsigned char *b = skb_tail_pointer(skb);
1367 struct rtattr *rta = (struct rtattr *)b; 1367 struct rtattr *rta = (struct rtattr *)b;
1368 1368
1369 tcm->tcm_parent = cl->cl_parent ? cl->cl_parent->classid : TC_H_ROOT; 1369 tcm->tcm_parent = cl->cl_parent ? cl->cl_parent->classid : TC_H_ROOT;
@@ -1374,7 +1374,7 @@ hfsc_dump_class(struct Qdisc *sch, unsigned long arg, struct sk_buff *skb,
1374 RTA_PUT(skb, TCA_OPTIONS, 0, NULL); 1374 RTA_PUT(skb, TCA_OPTIONS, 0, NULL);
1375 if (hfsc_dump_curves(skb, cl) < 0) 1375 if (hfsc_dump_curves(skb, cl) < 0)
1376 goto rtattr_failure; 1376 goto rtattr_failure;
1377 rta->rta_len = skb->tail - b; 1377 rta->rta_len = skb_tail_pointer(skb) - b;
1378 return skb->len; 1378 return skb->len;
1379 1379
1380 rtattr_failure: 1380 rtattr_failure:
@@ -1576,7 +1576,7 @@ static int
1576hfsc_dump_qdisc(struct Qdisc *sch, struct sk_buff *skb) 1576hfsc_dump_qdisc(struct Qdisc *sch, struct sk_buff *skb)
1577{ 1577{
1578 struct hfsc_sched *q = qdisc_priv(sch); 1578 struct hfsc_sched *q = qdisc_priv(sch);
1579 unsigned char *b = skb->tail; 1579 unsigned char *b = skb_tail_pointer(skb);
1580 struct tc_hfsc_qopt qopt; 1580 struct tc_hfsc_qopt qopt;
1581 1581
1582 qopt.defcls = q->defcls; 1582 qopt.defcls = q->defcls;