diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2007-04-19 23:29:13 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-04-26 01:26:28 -0400 |
commit | 27a884dc3cb63b93c2b3b643f5b31eed5f8a4d26 (patch) | |
tree | 5a267e40f9b94014be38dad5de0a52b6628834e0 /net/sched/sch_atm.c | |
parent | be8bd86321fa7f06359d866ef61fb4d2f3e9dce9 (diff) |
[SK_BUFF]: Convert skb->tail to sk_buff_data_t
So that it is also an offset from skb->head, reduces its size from 8 to 4 bytes
on 64bit architectures, allowing us to combine the 4 bytes hole left by the
layer headers conversion, reducing struct sk_buff size to 256 bytes, i.e. 4
64byte cachelines, and since the sk_buff slab cache is SLAB_HWCACHE_ALIGN...
:-)
Many calculations that previously required that skb->{transport,network,
mac}_header be first converted to a pointer now can be done directly, being
meaningful as offsets or pointers.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_atm.c')
-rw-r--r-- | net/sched/sch_atm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c index baca8743c12b..1d7bb1632138 100644 --- a/net/sched/sch_atm.c +++ b/net/sched/sch_atm.c | |||
@@ -631,7 +631,7 @@ static int atm_tc_dump_class(struct Qdisc *sch, unsigned long cl, | |||
631 | { | 631 | { |
632 | struct atm_qdisc_data *p = PRIV(sch); | 632 | struct atm_qdisc_data *p = PRIV(sch); |
633 | struct atm_flow_data *flow = (struct atm_flow_data *) cl; | 633 | struct atm_flow_data *flow = (struct atm_flow_data *) cl; |
634 | unsigned char *b = skb->tail; | 634 | unsigned char *b = skb_tail_pointer(skb); |
635 | struct rtattr *rta; | 635 | struct rtattr *rta; |
636 | 636 | ||
637 | DPRINTK("atm_tc_dump_class(sch %p,[qdisc %p],flow %p,skb %p,tcm %p)\n", | 637 | DPRINTK("atm_tc_dump_class(sch %p,[qdisc %p],flow %p,skb %p,tcm %p)\n", |
@@ -661,7 +661,7 @@ static int atm_tc_dump_class(struct Qdisc *sch, unsigned long cl, | |||
661 | 661 | ||
662 | RTA_PUT(skb,TCA_ATM_EXCESS,sizeof(zero),&zero); | 662 | RTA_PUT(skb,TCA_ATM_EXCESS,sizeof(zero),&zero); |
663 | } | 663 | } |
664 | rta->rta_len = skb->tail-b; | 664 | rta->rta_len = skb_tail_pointer(skb) - b; |
665 | return skb->len; | 665 | return skb->len; |
666 | 666 | ||
667 | rtattr_failure: | 667 | rtattr_failure: |