diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2007-04-19 23:29:13 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-04-26 01:26:28 -0400 |
commit | 27a884dc3cb63b93c2b3b643f5b31eed5f8a4d26 (patch) | |
tree | 5a267e40f9b94014be38dad5de0a52b6628834e0 /net/sched/sch_api.c | |
parent | be8bd86321fa7f06359d866ef61fb4d2f3e9dce9 (diff) |
[SK_BUFF]: Convert skb->tail to sk_buff_data_t
So that it is also an offset from skb->head, reduces its size from 8 to 4 bytes
on 64bit architectures, allowing us to combine the 4 bytes hole left by the
layer headers conversion, reducing struct sk_buff size to 256 bytes, i.e. 4
64byte cachelines, and since the sk_buff slab cache is SLAB_HWCACHE_ALIGN...
:-)
Many calculations that previously required that skb->{transport,network,
mac}_header be first converted to a pointer now can be done directly, being
meaningful as offsets or pointers.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_api.c')
-rw-r--r-- | net/sched/sch_api.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index ecbdc6b42a9c..7482a950717b 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c | |||
@@ -813,7 +813,7 @@ static int tc_fill_qdisc(struct sk_buff *skb, struct Qdisc *q, u32 clid, | |||
813 | { | 813 | { |
814 | struct tcmsg *tcm; | 814 | struct tcmsg *tcm; |
815 | struct nlmsghdr *nlh; | 815 | struct nlmsghdr *nlh; |
816 | unsigned char *b = skb->tail; | 816 | unsigned char *b = skb_tail_pointer(skb); |
817 | struct gnet_dump d; | 817 | struct gnet_dump d; |
818 | 818 | ||
819 | nlh = NLMSG_NEW(skb, pid, seq, event, sizeof(*tcm), flags); | 819 | nlh = NLMSG_NEW(skb, pid, seq, event, sizeof(*tcm), flags); |
@@ -847,7 +847,7 @@ static int tc_fill_qdisc(struct sk_buff *skb, struct Qdisc *q, u32 clid, | |||
847 | if (gnet_stats_finish_copy(&d) < 0) | 847 | if (gnet_stats_finish_copy(&d) < 0) |
848 | goto rtattr_failure; | 848 | goto rtattr_failure; |
849 | 849 | ||
850 | nlh->nlmsg_len = skb->tail - b; | 850 | nlh->nlmsg_len = skb_tail_pointer(skb) - b; |
851 | return skb->len; | 851 | return skb->len; |
852 | 852 | ||
853 | nlmsg_failure: | 853 | nlmsg_failure: |
@@ -1051,7 +1051,7 @@ static int tc_fill_tclass(struct sk_buff *skb, struct Qdisc *q, | |||
1051 | { | 1051 | { |
1052 | struct tcmsg *tcm; | 1052 | struct tcmsg *tcm; |
1053 | struct nlmsghdr *nlh; | 1053 | struct nlmsghdr *nlh; |
1054 | unsigned char *b = skb->tail; | 1054 | unsigned char *b = skb_tail_pointer(skb); |
1055 | struct gnet_dump d; | 1055 | struct gnet_dump d; |
1056 | struct Qdisc_class_ops *cl_ops = q->ops->cl_ops; | 1056 | struct Qdisc_class_ops *cl_ops = q->ops->cl_ops; |
1057 | 1057 | ||
@@ -1076,7 +1076,7 @@ static int tc_fill_tclass(struct sk_buff *skb, struct Qdisc *q, | |||
1076 | if (gnet_stats_finish_copy(&d) < 0) | 1076 | if (gnet_stats_finish_copy(&d) < 0) |
1077 | goto rtattr_failure; | 1077 | goto rtattr_failure; |
1078 | 1078 | ||
1079 | nlh->nlmsg_len = skb->tail - b; | 1079 | nlh->nlmsg_len = skb_tail_pointer(skb) - b; |
1080 | return skb->len; | 1080 | return skb->len; |
1081 | 1081 | ||
1082 | nlmsg_failure: | 1082 | nlmsg_failure: |