diff options
author | Patrick McHardy <kaber@trash.net> | 2008-01-23 23:33:32 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:11:18 -0500 |
commit | cee63723b358e594225e812d6e14a2a0abfd5c88 (patch) | |
tree | 847f929e0f445cca8cdf55d7c17a56b0d0f2ec68 /net/sched/act_simple.c | |
parent | ab27cfb85c5778400740ad0c401bde65616774eb (diff) |
[NET_SCHED]: Propagate nla_parse return value
nla_parse() returns more detailed errno codes, propagate them back on
error.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_simple.c')
-rw-r--r-- | net/sched/act_simple.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c index d3226e24070b..cedaadf18eb2 100644 --- a/net/sched/act_simple.c +++ b/net/sched/act_simple.c | |||
@@ -93,11 +93,15 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est, | |||
93 | struct tcf_common *pc; | 93 | struct tcf_common *pc; |
94 | void *defdata; | 94 | void *defdata; |
95 | u32 datalen = 0; | 95 | u32 datalen = 0; |
96 | int ret = 0; | 96 | int ret = 0, err; |
97 | 97 | ||
98 | if (nla == NULL || nla_parse_nested(tb, TCA_DEF_MAX, nla, NULL) < 0) | 98 | if (nla == NULL) |
99 | return -EINVAL; | 99 | return -EINVAL; |
100 | 100 | ||
101 | err = nla_parse_nested(tb, TCA_DEF_MAX, nla, NULL); | ||
102 | if (err < 0) | ||
103 | return err; | ||
104 | |||
101 | if (tb[TCA_DEF_PARMS] == NULL || | 105 | if (tb[TCA_DEF_PARMS] == NULL || |
102 | nla_len(tb[TCA_DEF_PARMS]) < sizeof(*parm)) | 106 | nla_len(tb[TCA_DEF_PARMS]) < sizeof(*parm)) |
103 | return -EINVAL; | 107 | return -EINVAL; |