diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2007-04-19 23:29:13 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-04-26 01:26:28 -0400 |
commit | 27a884dc3cb63b93c2b3b643f5b31eed5f8a4d26 (patch) | |
tree | 5a267e40f9b94014be38dad5de0a52b6628834e0 /net/sched/act_police.c | |
parent | be8bd86321fa7f06359d866ef61fb4d2f3e9dce9 (diff) |
[SK_BUFF]: Convert skb->tail to sk_buff_data_t
So that it is also an offset from skb->head, reduces its size from 8 to 4 bytes
on 64bit architectures, allowing us to combine the 4 bytes hole left by the
layer headers conversion, reducing struct sk_buff size to 256 bytes, i.e. 4
64byte cachelines, and since the sk_buff slab cache is SLAB_HWCACHE_ALIGN...
:-)
Many calculations that previously required that skb->{transport,network,
mac}_header be first converted to a pointer now can be done directly, being
meaningful as offsets or pointers.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_police.c')
-rw-r--r-- | net/sched/act_police.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/sched/act_police.c b/net/sched/act_police.c index 10a5a5c36f76..068b23763665 100644 --- a/net/sched/act_police.c +++ b/net/sched/act_police.c | |||
@@ -80,7 +80,7 @@ static int tcf_act_police_walker(struct sk_buff *skb, struct netlink_callback *c | |||
80 | continue; | 80 | continue; |
81 | a->priv = p; | 81 | a->priv = p; |
82 | a->order = index; | 82 | a->order = index; |
83 | r = (struct rtattr*) skb->tail; | 83 | r = (struct rtattr *)skb_tail_pointer(skb); |
84 | RTA_PUT(skb, a->order, 0, NULL); | 84 | RTA_PUT(skb, a->order, 0, NULL); |
85 | if (type == RTM_DELACTION) | 85 | if (type == RTM_DELACTION) |
86 | err = tcf_action_dump_1(skb, a, 0, 1); | 86 | err = tcf_action_dump_1(skb, a, 0, 1); |
@@ -91,7 +91,7 @@ static int tcf_act_police_walker(struct sk_buff *skb, struct netlink_callback *c | |||
91 | skb_trim(skb, (u8*)r - skb->data); | 91 | skb_trim(skb, (u8*)r - skb->data); |
92 | goto done; | 92 | goto done; |
93 | } | 93 | } |
94 | r->rta_len = skb->tail - (u8*)r; | 94 | r->rta_len = skb_tail_pointer(skb) - (u8 *)r; |
95 | n_i++; | 95 | n_i++; |
96 | } | 96 | } |
97 | } | 97 | } |
@@ -326,7 +326,7 @@ static int tcf_act_police(struct sk_buff *skb, struct tc_action *a, | |||
326 | static int | 326 | static int |
327 | tcf_act_police_dump(struct sk_buff *skb, struct tc_action *a, int bind, int ref) | 327 | tcf_act_police_dump(struct sk_buff *skb, struct tc_action *a, int bind, int ref) |
328 | { | 328 | { |
329 | unsigned char *b = skb->tail; | 329 | unsigned char *b = skb_tail_pointer(skb); |
330 | struct tcf_police *police = a->priv; | 330 | struct tcf_police *police = a->priv; |
331 | struct tc_police opt; | 331 | struct tc_police opt; |
332 | 332 | ||
@@ -572,7 +572,7 @@ EXPORT_SYMBOL(tcf_police); | |||
572 | 572 | ||
573 | int tcf_police_dump(struct sk_buff *skb, struct tcf_police *police) | 573 | int tcf_police_dump(struct sk_buff *skb, struct tcf_police *police) |
574 | { | 574 | { |
575 | unsigned char *b = skb->tail; | 575 | unsigned char *b = skb_tail_pointer(skb); |
576 | struct tc_police opt; | 576 | struct tc_police opt; |
577 | 577 | ||
578 | opt.index = police->tcf_index; | 578 | opt.index = police->tcf_index; |