aboutsummaryrefslogtreecommitdiffstats
path: root/net/sched/act_pedit.c
diff options
context:
space:
mode:
authorstephen hemminger <shemminger@vyatta.com>2010-05-12 02:37:05 -0400
committerDavid S. Miller <davem@davemloft.net>2010-05-18 02:23:12 -0400
commit6ff9c3644e72bfac20844e0155c2cc8108602820 (patch)
tree81a8ce88d6f0f91ff7f68b234c2d20d6a0d8745f /net/sched/act_pedit.c
parent00c60a8312c235cac1c879b620ecb71413e9245d (diff)
net sched: printk message severity
The previous patch encourage me to go look at all the messages in the network scheduler and fix them. Many messages were missing any severity level. Some serious ones that should never happen were turned into WARN(), and the random noise messages that were handled changed to pr_debug(). Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_pedit.c')
-rw-r--r--net/sched/act_pedit.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
index b7dcfedc802e..fdbd0b7bd840 100644
--- a/net/sched/act_pedit.c
+++ b/net/sched/act_pedit.c
@@ -158,11 +158,13 @@ static int tcf_pedit(struct sk_buff *skb, struct tc_action *a,
158 } 158 }
159 159
160 if (offset % 4) { 160 if (offset % 4) {
161 printk("offset must be on 32 bit boundaries\n"); 161 pr_info("tc filter pedit"
162 " offset must be on 32 bit boundaries\n");
162 goto bad; 163 goto bad;
163 } 164 }
164 if (offset > 0 && offset > skb->len) { 165 if (offset > 0 && offset > skb->len) {
165 printk("offset %d cant exceed pkt length %d\n", 166 pr_info("tc filter pedit"
167 " offset %d cant exceed pkt length %d\n",
166 offset, skb->len); 168 offset, skb->len);
167 goto bad; 169 goto bad;
168 } 170 }
@@ -176,9 +178,8 @@ static int tcf_pedit(struct sk_buff *skb, struct tc_action *a,
176 if (munged) 178 if (munged)
177 skb->tc_verd = SET_TC_MUNGED(skb->tc_verd); 179 skb->tc_verd = SET_TC_MUNGED(skb->tc_verd);
178 goto done; 180 goto done;
179 } else { 181 } else
180 printk("pedit BUG: index %d\n", p->tcf_index); 182 WARN(1, "pedit BUG: index %d\n", p->tcf_index);
181 }
182 183
183bad: 184bad:
184 p->tcf_qstats.overlimits++; 185 p->tcf_qstats.overlimits++;