aboutsummaryrefslogtreecommitdiffstats
path: root/net/sched/act_mirred.c
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2008-01-23 23:33:32 -0500
committerDavid S. Miller <davem@davemloft.net>2008-01-28 18:11:18 -0500
commitcee63723b358e594225e812d6e14a2a0abfd5c88 (patch)
tree847f929e0f445cca8cdf55d7c17a56b0d0f2ec68 /net/sched/act_mirred.c
parentab27cfb85c5778400740ad0c401bde65616774eb (diff)
[NET_SCHED]: Propagate nla_parse return value
nla_parse() returns more detailed errno codes, propagate them back on error. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_mirred.c')
-rw-r--r--net/sched/act_mirred.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c
index db943a8c7388..6cb5e30dcf8c 100644
--- a/net/sched/act_mirred.c
+++ b/net/sched/act_mirred.c
@@ -62,12 +62,16 @@ static int tcf_mirred_init(struct nlattr *nla, struct nlattr *est,
62 struct tcf_mirred *m; 62 struct tcf_mirred *m;
63 struct tcf_common *pc; 63 struct tcf_common *pc;
64 struct net_device *dev = NULL; 64 struct net_device *dev = NULL;
65 int ret = 0; 65 int ret = 0, err;
66 int ok_push = 0; 66 int ok_push = 0;
67 67
68 if (nla == NULL || nla_parse_nested(tb, TCA_MIRRED_MAX, nla, NULL) < 0) 68 if (nla == NULL)
69 return -EINVAL; 69 return -EINVAL;
70 70
71 err = nla_parse_nested(tb, TCA_MIRRED_MAX, nla, NULL);
72 if (err < 0)
73 return err;
74
71 if (tb[TCA_MIRRED_PARMS] == NULL || 75 if (tb[TCA_MIRRED_PARMS] == NULL ||
72 nla_len(tb[TCA_MIRRED_PARMS]) < sizeof(*parm)) 76 nla_len(tb[TCA_MIRRED_PARMS]) < sizeof(*parm))
73 return -EINVAL; 77 return -EINVAL;