diff options
author | Patrick McHardy <kaber@trash.net> | 2008-01-23 23:33:32 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:11:18 -0500 |
commit | cee63723b358e594225e812d6e14a2a0abfd5c88 (patch) | |
tree | 847f929e0f445cca8cdf55d7c17a56b0d0f2ec68 /net/sched/act_ipt.c | |
parent | ab27cfb85c5778400740ad0c401bde65616774eb (diff) |
[NET_SCHED]: Propagate nla_parse return value
nla_parse() returns more detailed errno codes, propagate them back on
error.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_ipt.c')
-rw-r--r-- | net/sched/act_ipt.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/net/sched/act_ipt.c b/net/sched/act_ipt.c index fee5282637cc..12693347d56a 100644 --- a/net/sched/act_ipt.c +++ b/net/sched/act_ipt.c | |||
@@ -104,9 +104,13 @@ static int tcf_ipt_init(struct nlattr *nla, struct nlattr *est, | |||
104 | u32 hook = 0; | 104 | u32 hook = 0; |
105 | u32 index = 0; | 105 | u32 index = 0; |
106 | 106 | ||
107 | if (nla == NULL || nla_parse_nested(tb, TCA_IPT_MAX, nla, NULL) < 0) | 107 | if (nla == NULL) |
108 | return -EINVAL; | 108 | return -EINVAL; |
109 | 109 | ||
110 | err = nla_parse_nested(tb, TCA_IPT_MAX, nla, NULL); | ||
111 | if (err < 0) | ||
112 | return err; | ||
113 | |||
110 | if (tb[TCA_IPT_HOOK] == NULL || | 114 | if (tb[TCA_IPT_HOOK] == NULL || |
111 | nla_len(tb[TCA_IPT_HOOK]) < sizeof(u32)) | 115 | nla_len(tb[TCA_IPT_HOOK]) < sizeof(u32)) |
112 | return -EINVAL; | 116 | return -EINVAL; |