diff options
author | Patrick McHardy <kaber@trash.net> | 2008-01-23 23:33:32 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:11:18 -0500 |
commit | cee63723b358e594225e812d6e14a2a0abfd5c88 (patch) | |
tree | 847f929e0f445cca8cdf55d7c17a56b0d0f2ec68 /net/sched/act_gact.c | |
parent | ab27cfb85c5778400740ad0c401bde65616774eb (diff) |
[NET_SCHED]: Propagate nla_parse return value
nla_parse() returns more detailed errno codes, propagate them back on
error.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_gact.c')
-rw-r--r-- | net/sched/act_gact.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/net/sched/act_gact.c b/net/sched/act_gact.c index 5402cf885f95..df214d47fc92 100644 --- a/net/sched/act_gact.c +++ b/net/sched/act_gact.c | |||
@@ -61,10 +61,15 @@ static int tcf_gact_init(struct nlattr *nla, struct nlattr *est, | |||
61 | struct tcf_gact *gact; | 61 | struct tcf_gact *gact; |
62 | struct tcf_common *pc; | 62 | struct tcf_common *pc; |
63 | int ret = 0; | 63 | int ret = 0; |
64 | int err; | ||
64 | 65 | ||
65 | if (nla == NULL || nla_parse_nested(tb, TCA_GACT_MAX, nla, NULL) < 0) | 66 | if (nla == NULL) |
66 | return -EINVAL; | 67 | return -EINVAL; |
67 | 68 | ||
69 | err = nla_parse_nested(tb, TCA_GACT_MAX, nla, NULL); | ||
70 | if (err < 0) | ||
71 | return err; | ||
72 | |||
68 | if (tb[TCA_GACT_PARMS] == NULL || | 73 | if (tb[TCA_GACT_PARMS] == NULL || |
69 | nla_len(tb[TCA_GACT_PARMS]) < sizeof(*parm)) | 74 | nla_len(tb[TCA_GACT_PARMS]) < sizeof(*parm)) |
70 | return -EINVAL; | 75 | return -EINVAL; |