aboutsummaryrefslogtreecommitdiffstats
path: root/net/rose/rose_route.c
diff options
context:
space:
mode:
authorEric Dumazet <dada1@cosmosbay.com>2008-01-15 06:30:35 -0500
committerDavid S. Miller <davem@davemloft.net>2008-01-28 18:02:44 -0500
commit95b7d924a589dbefc7ae2ea6c7144b86b75d6a47 (patch)
tree887766c4c98864db4fa1ac0ec5b97bcc90bc2ab5 /net/rose/rose_route.c
parent5c17d5f11212af5f12b91991b1132cf301dd1f28 (diff)
[ROSE]: Supress sparse warnings
CHECK net/rose/af_rose.c net/rose/af_rose.c:125:11: warning: expensive signed divide net/rose/af_rose.c:976:46: warning: expensive signed divide net/rose/af_rose.c:1379:13: warning: context imbalance in 'rose_info_start' - wrong count at exit net/rose/af_rose.c:1406:13: warning: context imbalance in 'rose_info_stop' - unexpected unlock CHECK net/rose/rose_in.c net/rose/rose_in.c:185:25: warning: expensive signed divide CHECK net/rose/rose_route.c net/rose/rose_route.c:997:46: warning: expensive signed divide net/rose/rose_route.c:1070:13: warning: context imbalance in 'rose_node_start' - wrong count at exit net/rose/rose_route.c:1093:13: warning: context imbalance in 'rose_node_stop' - unexpected unlock net/rose/rose_route.c:1146:13: warning: context imbalance in 'rose_neigh_start' - wrong count at exit net/rose/rose_route.c:1169:13: warning: context imbalance in 'rose_neigh_stop' - unexpected unlock net/rose/rose_route.c:1229:13: warning: context imbalance in 'rose_route_start' - wrong count at exit net/rose/rose_route.c:1252:13: warning: context imbalance in 'rose_route_stop' - unexpected unlock Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rose/rose_route.c')
-rw-r--r--net/rose/rose_route.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c
index 540c0f26ffee..fb9359fb2358 100644
--- a/net/rose/rose_route.c
+++ b/net/rose/rose_route.c
@@ -994,8 +994,8 @@ int rose_route_frame(struct sk_buff *skb, ax25_cb *ax25)
994 goto out; 994 goto out;
995 } 995 }
996 996
997 len = (((skb->data[3] >> 4) & 0x0F) + 1) / 2; 997 len = (((skb->data[3] >> 4) & 0x0F) + 1) >> 1;
998 len += (((skb->data[3] >> 0) & 0x0F) + 1) / 2; 998 len += (((skb->data[3] >> 0) & 0x0F) + 1) >> 1;
999 999
1000 memset(&facilities, 0x00, sizeof(struct rose_facilities_struct)); 1000 memset(&facilities, 0x00, sizeof(struct rose_facilities_struct));
1001 1001
@@ -1068,6 +1068,7 @@ out:
1068#ifdef CONFIG_PROC_FS 1068#ifdef CONFIG_PROC_FS
1069 1069
1070static void *rose_node_start(struct seq_file *seq, loff_t *pos) 1070static void *rose_node_start(struct seq_file *seq, loff_t *pos)
1071 __acquires(rose_neigh_list_lock)
1071{ 1072{
1072 struct rose_node *rose_node; 1073 struct rose_node *rose_node;
1073 int i = 1; 1074 int i = 1;
@@ -1091,6 +1092,7 @@ static void *rose_node_next(struct seq_file *seq, void *v, loff_t *pos)
1091} 1092}
1092 1093
1093static void rose_node_stop(struct seq_file *seq, void *v) 1094static void rose_node_stop(struct seq_file *seq, void *v)
1095 __releases(rose_neigh_list_lock)
1094{ 1096{
1095 spin_unlock_bh(&rose_neigh_list_lock); 1097 spin_unlock_bh(&rose_neigh_list_lock);
1096} 1098}
@@ -1144,6 +1146,7 @@ const struct file_operations rose_nodes_fops = {
1144}; 1146};
1145 1147
1146static void *rose_neigh_start(struct seq_file *seq, loff_t *pos) 1148static void *rose_neigh_start(struct seq_file *seq, loff_t *pos)
1149 __acquires(rose_neigh_list_lock)
1147{ 1150{
1148 struct rose_neigh *rose_neigh; 1151 struct rose_neigh *rose_neigh;
1149 int i = 1; 1152 int i = 1;
@@ -1167,6 +1170,7 @@ static void *rose_neigh_next(struct seq_file *seq, void *v, loff_t *pos)
1167} 1170}
1168 1171
1169static void rose_neigh_stop(struct seq_file *seq, void *v) 1172static void rose_neigh_stop(struct seq_file *seq, void *v)
1173 __releases(rose_neigh_list_lock)
1170{ 1174{
1171 spin_unlock_bh(&rose_neigh_list_lock); 1175 spin_unlock_bh(&rose_neigh_list_lock);
1172} 1176}
@@ -1227,6 +1231,7 @@ const struct file_operations rose_neigh_fops = {
1227 1231
1228 1232
1229static void *rose_route_start(struct seq_file *seq, loff_t *pos) 1233static void *rose_route_start(struct seq_file *seq, loff_t *pos)
1234 __acquires(rose_route_list_lock)
1230{ 1235{
1231 struct rose_route *rose_route; 1236 struct rose_route *rose_route;
1232 int i = 1; 1237 int i = 1;
@@ -1250,6 +1255,7 @@ static void *rose_route_next(struct seq_file *seq, void *v, loff_t *pos)
1250} 1255}
1251 1256
1252static void rose_route_stop(struct seq_file *seq, void *v) 1257static void rose_route_stop(struct seq_file *seq, void *v)
1258 __releases(rose_route_list_lock)
1253{ 1259{
1254 spin_unlock_bh(&rose_route_list_lock); 1260 spin_unlock_bh(&rose_route_list_lock);
1255} 1261}