diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2009-11-16 06:11:48 -0500 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2009-11-18 11:37:40 -0500 |
commit | 6d4561110a3e9fa742aeec6717248a491dfb1878 (patch) | |
tree | 689e2abf19940416ce597ba56ed31026ff59bd21 /net/rds | |
parent | 86926d0096279b9739ceeff40f68d3c33b9119a9 (diff) |
sysctl: Drop & in front of every proc_handler.
For consistency drop & in front of every proc_handler. Explicity
taking the address is unnecessary and it prevents optimizations
like stubbing the proc_handlers to NULL.
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Diffstat (limited to 'net/rds')
-rw-r--r-- | net/rds/ib_sysctl.c | 12 | ||||
-rw-r--r-- | net/rds/iw_sysctl.c | 12 | ||||
-rw-r--r-- | net/rds/sysctl.c | 10 |
3 files changed, 17 insertions, 17 deletions
diff --git a/net/rds/ib_sysctl.c b/net/rds/ib_sysctl.c index 517c6c9987ba..03f01cb4e0fe 100644 --- a/net/rds/ib_sysctl.c +++ b/net/rds/ib_sysctl.c | |||
@@ -71,7 +71,7 @@ ctl_table rds_ib_sysctl_table[] = { | |||
71 | .data = &rds_ib_sysctl_max_send_wr, | 71 | .data = &rds_ib_sysctl_max_send_wr, |
72 | .maxlen = sizeof(unsigned long), | 72 | .maxlen = sizeof(unsigned long), |
73 | .mode = 0644, | 73 | .mode = 0644, |
74 | .proc_handler = &proc_doulongvec_minmax, | 74 | .proc_handler = proc_doulongvec_minmax, |
75 | .extra1 = &rds_ib_sysctl_max_wr_min, | 75 | .extra1 = &rds_ib_sysctl_max_wr_min, |
76 | .extra2 = &rds_ib_sysctl_max_wr_max, | 76 | .extra2 = &rds_ib_sysctl_max_wr_max, |
77 | }, | 77 | }, |
@@ -80,7 +80,7 @@ ctl_table rds_ib_sysctl_table[] = { | |||
80 | .data = &rds_ib_sysctl_max_recv_wr, | 80 | .data = &rds_ib_sysctl_max_recv_wr, |
81 | .maxlen = sizeof(unsigned long), | 81 | .maxlen = sizeof(unsigned long), |
82 | .mode = 0644, | 82 | .mode = 0644, |
83 | .proc_handler = &proc_doulongvec_minmax, | 83 | .proc_handler = proc_doulongvec_minmax, |
84 | .extra1 = &rds_ib_sysctl_max_wr_min, | 84 | .extra1 = &rds_ib_sysctl_max_wr_min, |
85 | .extra2 = &rds_ib_sysctl_max_wr_max, | 85 | .extra2 = &rds_ib_sysctl_max_wr_max, |
86 | }, | 86 | }, |
@@ -89,7 +89,7 @@ ctl_table rds_ib_sysctl_table[] = { | |||
89 | .data = &rds_ib_sysctl_max_unsig_wrs, | 89 | .data = &rds_ib_sysctl_max_unsig_wrs, |
90 | .maxlen = sizeof(unsigned long), | 90 | .maxlen = sizeof(unsigned long), |
91 | .mode = 0644, | 91 | .mode = 0644, |
92 | .proc_handler = &proc_doulongvec_minmax, | 92 | .proc_handler = proc_doulongvec_minmax, |
93 | .extra1 = &rds_ib_sysctl_max_unsig_wr_min, | 93 | .extra1 = &rds_ib_sysctl_max_unsig_wr_min, |
94 | .extra2 = &rds_ib_sysctl_max_unsig_wr_max, | 94 | .extra2 = &rds_ib_sysctl_max_unsig_wr_max, |
95 | }, | 95 | }, |
@@ -98,7 +98,7 @@ ctl_table rds_ib_sysctl_table[] = { | |||
98 | .data = &rds_ib_sysctl_max_unsig_bytes, | 98 | .data = &rds_ib_sysctl_max_unsig_bytes, |
99 | .maxlen = sizeof(unsigned long), | 99 | .maxlen = sizeof(unsigned long), |
100 | .mode = 0644, | 100 | .mode = 0644, |
101 | .proc_handler = &proc_doulongvec_minmax, | 101 | .proc_handler = proc_doulongvec_minmax, |
102 | .extra1 = &rds_ib_sysctl_max_unsig_bytes_min, | 102 | .extra1 = &rds_ib_sysctl_max_unsig_bytes_min, |
103 | .extra2 = &rds_ib_sysctl_max_unsig_bytes_max, | 103 | .extra2 = &rds_ib_sysctl_max_unsig_bytes_max, |
104 | }, | 104 | }, |
@@ -107,14 +107,14 @@ ctl_table rds_ib_sysctl_table[] = { | |||
107 | .data = &rds_ib_sysctl_max_recv_allocation, | 107 | .data = &rds_ib_sysctl_max_recv_allocation, |
108 | .maxlen = sizeof(unsigned long), | 108 | .maxlen = sizeof(unsigned long), |
109 | .mode = 0644, | 109 | .mode = 0644, |
110 | .proc_handler = &proc_doulongvec_minmax, | 110 | .proc_handler = proc_doulongvec_minmax, |
111 | }, | 111 | }, |
112 | { | 112 | { |
113 | .procname = "flow_control", | 113 | .procname = "flow_control", |
114 | .data = &rds_ib_sysctl_flow_control, | 114 | .data = &rds_ib_sysctl_flow_control, |
115 | .maxlen = sizeof(rds_ib_sysctl_flow_control), | 115 | .maxlen = sizeof(rds_ib_sysctl_flow_control), |
116 | .mode = 0644, | 116 | .mode = 0644, |
117 | .proc_handler = &proc_dointvec, | 117 | .proc_handler = proc_dointvec, |
118 | }, | 118 | }, |
119 | { } | 119 | { } |
120 | }; | 120 | }; |
diff --git a/net/rds/iw_sysctl.c b/net/rds/iw_sysctl.c index 3e00b01559f2..1c4428a61a02 100644 --- a/net/rds/iw_sysctl.c +++ b/net/rds/iw_sysctl.c | |||
@@ -61,7 +61,7 @@ ctl_table rds_iw_sysctl_table[] = { | |||
61 | .data = &rds_iw_sysctl_max_send_wr, | 61 | .data = &rds_iw_sysctl_max_send_wr, |
62 | .maxlen = sizeof(unsigned long), | 62 | .maxlen = sizeof(unsigned long), |
63 | .mode = 0644, | 63 | .mode = 0644, |
64 | .proc_handler = &proc_doulongvec_minmax, | 64 | .proc_handler = proc_doulongvec_minmax, |
65 | .extra1 = &rds_iw_sysctl_max_wr_min, | 65 | .extra1 = &rds_iw_sysctl_max_wr_min, |
66 | .extra2 = &rds_iw_sysctl_max_wr_max, | 66 | .extra2 = &rds_iw_sysctl_max_wr_max, |
67 | }, | 67 | }, |
@@ -70,7 +70,7 @@ ctl_table rds_iw_sysctl_table[] = { | |||
70 | .data = &rds_iw_sysctl_max_recv_wr, | 70 | .data = &rds_iw_sysctl_max_recv_wr, |
71 | .maxlen = sizeof(unsigned long), | 71 | .maxlen = sizeof(unsigned long), |
72 | .mode = 0644, | 72 | .mode = 0644, |
73 | .proc_handler = &proc_doulongvec_minmax, | 73 | .proc_handler = proc_doulongvec_minmax, |
74 | .extra1 = &rds_iw_sysctl_max_wr_min, | 74 | .extra1 = &rds_iw_sysctl_max_wr_min, |
75 | .extra2 = &rds_iw_sysctl_max_wr_max, | 75 | .extra2 = &rds_iw_sysctl_max_wr_max, |
76 | }, | 76 | }, |
@@ -79,7 +79,7 @@ ctl_table rds_iw_sysctl_table[] = { | |||
79 | .data = &rds_iw_sysctl_max_unsig_wrs, | 79 | .data = &rds_iw_sysctl_max_unsig_wrs, |
80 | .maxlen = sizeof(unsigned long), | 80 | .maxlen = sizeof(unsigned long), |
81 | .mode = 0644, | 81 | .mode = 0644, |
82 | .proc_handler = &proc_doulongvec_minmax, | 82 | .proc_handler = proc_doulongvec_minmax, |
83 | .extra1 = &rds_iw_sysctl_max_unsig_wr_min, | 83 | .extra1 = &rds_iw_sysctl_max_unsig_wr_min, |
84 | .extra2 = &rds_iw_sysctl_max_unsig_wr_max, | 84 | .extra2 = &rds_iw_sysctl_max_unsig_wr_max, |
85 | }, | 85 | }, |
@@ -88,7 +88,7 @@ ctl_table rds_iw_sysctl_table[] = { | |||
88 | .data = &rds_iw_sysctl_max_unsig_bytes, | 88 | .data = &rds_iw_sysctl_max_unsig_bytes, |
89 | .maxlen = sizeof(unsigned long), | 89 | .maxlen = sizeof(unsigned long), |
90 | .mode = 0644, | 90 | .mode = 0644, |
91 | .proc_handler = &proc_doulongvec_minmax, | 91 | .proc_handler = proc_doulongvec_minmax, |
92 | .extra1 = &rds_iw_sysctl_max_unsig_bytes_min, | 92 | .extra1 = &rds_iw_sysctl_max_unsig_bytes_min, |
93 | .extra2 = &rds_iw_sysctl_max_unsig_bytes_max, | 93 | .extra2 = &rds_iw_sysctl_max_unsig_bytes_max, |
94 | }, | 94 | }, |
@@ -97,14 +97,14 @@ ctl_table rds_iw_sysctl_table[] = { | |||
97 | .data = &rds_iw_sysctl_max_recv_allocation, | 97 | .data = &rds_iw_sysctl_max_recv_allocation, |
98 | .maxlen = sizeof(unsigned long), | 98 | .maxlen = sizeof(unsigned long), |
99 | .mode = 0644, | 99 | .mode = 0644, |
100 | .proc_handler = &proc_doulongvec_minmax, | 100 | .proc_handler = proc_doulongvec_minmax, |
101 | }, | 101 | }, |
102 | { | 102 | { |
103 | .procname = "flow_control", | 103 | .procname = "flow_control", |
104 | .data = &rds_iw_sysctl_flow_control, | 104 | .data = &rds_iw_sysctl_flow_control, |
105 | .maxlen = sizeof(rds_iw_sysctl_flow_control), | 105 | .maxlen = sizeof(rds_iw_sysctl_flow_control), |
106 | .mode = 0644, | 106 | .mode = 0644, |
107 | .proc_handler = &proc_dointvec, | 107 | .proc_handler = proc_dointvec, |
108 | }, | 108 | }, |
109 | { } | 109 | { } |
110 | }; | 110 | }; |
diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c index 8fb499ee3687..7829a20325d3 100644 --- a/net/rds/sysctl.c +++ b/net/rds/sysctl.c | |||
@@ -55,7 +55,7 @@ static ctl_table rds_sysctl_rds_table[] = { | |||
55 | .data = &rds_sysctl_reconnect_min_jiffies, | 55 | .data = &rds_sysctl_reconnect_min_jiffies, |
56 | .maxlen = sizeof(unsigned long), | 56 | .maxlen = sizeof(unsigned long), |
57 | .mode = 0644, | 57 | .mode = 0644, |
58 | .proc_handler = &proc_doulongvec_ms_jiffies_minmax, | 58 | .proc_handler = proc_doulongvec_ms_jiffies_minmax, |
59 | .extra1 = &rds_sysctl_reconnect_min, | 59 | .extra1 = &rds_sysctl_reconnect_min, |
60 | .extra2 = &rds_sysctl_reconnect_max_jiffies, | 60 | .extra2 = &rds_sysctl_reconnect_max_jiffies, |
61 | }, | 61 | }, |
@@ -64,7 +64,7 @@ static ctl_table rds_sysctl_rds_table[] = { | |||
64 | .data = &rds_sysctl_reconnect_max_jiffies, | 64 | .data = &rds_sysctl_reconnect_max_jiffies, |
65 | .maxlen = sizeof(unsigned long), | 65 | .maxlen = sizeof(unsigned long), |
66 | .mode = 0644, | 66 | .mode = 0644, |
67 | .proc_handler = &proc_doulongvec_ms_jiffies_minmax, | 67 | .proc_handler = proc_doulongvec_ms_jiffies_minmax, |
68 | .extra1 = &rds_sysctl_reconnect_min_jiffies, | 68 | .extra1 = &rds_sysctl_reconnect_min_jiffies, |
69 | .extra2 = &rds_sysctl_reconnect_max, | 69 | .extra2 = &rds_sysctl_reconnect_max, |
70 | }, | 70 | }, |
@@ -73,21 +73,21 @@ static ctl_table rds_sysctl_rds_table[] = { | |||
73 | .data = &rds_sysctl_max_unacked_packets, | 73 | .data = &rds_sysctl_max_unacked_packets, |
74 | .maxlen = sizeof(unsigned long), | 74 | .maxlen = sizeof(unsigned long), |
75 | .mode = 0644, | 75 | .mode = 0644, |
76 | .proc_handler = &proc_dointvec, | 76 | .proc_handler = proc_dointvec, |
77 | }, | 77 | }, |
78 | { | 78 | { |
79 | .procname = "max_unacked_bytes", | 79 | .procname = "max_unacked_bytes", |
80 | .data = &rds_sysctl_max_unacked_bytes, | 80 | .data = &rds_sysctl_max_unacked_bytes, |
81 | .maxlen = sizeof(unsigned long), | 81 | .maxlen = sizeof(unsigned long), |
82 | .mode = 0644, | 82 | .mode = 0644, |
83 | .proc_handler = &proc_dointvec, | 83 | .proc_handler = proc_dointvec, |
84 | }, | 84 | }, |
85 | { | 85 | { |
86 | .procname = "ping_enable", | 86 | .procname = "ping_enable", |
87 | .data = &rds_sysctl_ping_enable, | 87 | .data = &rds_sysctl_ping_enable, |
88 | .maxlen = sizeof(int), | 88 | .maxlen = sizeof(int), |
89 | .mode = 0644, | 89 | .mode = 0644, |
90 | .proc_handler = &proc_dointvec, | 90 | .proc_handler = proc_dointvec, |
91 | }, | 91 | }, |
92 | { } | 92 | { } |
93 | }; | 93 | }; |