diff options
author | Andy Grover <andy.grover@oracle.com> | 2010-01-12 14:56:44 -0500 |
---|---|---|
committer | Andy Grover <andy.grover@oracle.com> | 2010-09-08 21:11:32 -0400 |
commit | 8690bfa17aea4c42da1bcf90a7af93d161eca624 (patch) | |
tree | 88c4c5fa63aab0c18cf13228c4b3a6f980aa74be /net/rds/bind.c | |
parent | 2dc393573430f853e56e25bf4b41c34ba2aa8fd6 (diff) |
RDS: cleanup: remove "== NULL"s and "!= NULL"s in ptr comparisons
Favor "if (foo)" style over "if (foo != NULL)".
Signed-off-by: Andy Grover <andy.grover@oracle.com>
Diffstat (limited to 'net/rds/bind.c')
-rw-r--r-- | net/rds/bind.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/rds/bind.c b/net/rds/bind.c index 5d95fc007f1a..65de5cbdb576 100644 --- a/net/rds/bind.c +++ b/net/rds/bind.c | |||
@@ -121,7 +121,7 @@ static int rds_add_bound(struct rds_sock *rs, __be32 addr, __be16 *port) | |||
121 | do { | 121 | do { |
122 | if (rover == 0) | 122 | if (rover == 0) |
123 | rover++; | 123 | rover++; |
124 | if (rds_bind_tree_walk(addr, cpu_to_be16(rover), rs) == NULL) { | 124 | if (!rds_bind_tree_walk(addr, cpu_to_be16(rover), rs)) { |
125 | *port = cpu_to_be16(rover); | 125 | *port = cpu_to_be16(rover); |
126 | ret = 0; | 126 | ret = 0; |
127 | break; | 127 | break; |
@@ -184,7 +184,7 @@ int rds_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) | |||
184 | goto out; | 184 | goto out; |
185 | 185 | ||
186 | trans = rds_trans_get_preferred(sin->sin_addr.s_addr); | 186 | trans = rds_trans_get_preferred(sin->sin_addr.s_addr); |
187 | if (trans == NULL) { | 187 | if (!trans) { |
188 | ret = -EADDRNOTAVAIL; | 188 | ret = -EADDRNOTAVAIL; |
189 | rds_remove_bound(rs); | 189 | rds_remove_bound(rs); |
190 | if (printk_ratelimit()) | 190 | if (printk_ratelimit()) |