diff options
author | Ying Xue <ying.xue@windriver.com> | 2015-03-02 02:37:48 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-03-02 13:06:31 -0500 |
commit | 1b784140474e4fc94281a49e96c67d29df0efbde (patch) | |
tree | 569e9813ae7ab79616849b117c6b50b3d6e4dabb /net/phonet | |
parent | 39a0295f901423e260a034ac7c3211ecaa9c2745 (diff) |
net: Remove iocb argument from sendmsg and recvmsg
After TIPC doesn't depend on iocb argument in its internal
implementations of sendmsg() and recvmsg() hooks defined in proto
structure, no any user is using iocb argument in them at all now.
Then we can drop the redundant iocb argument completely from kinds of
implementations of both sendmsg() and recvmsg() in the entire
networking stack.
Cc: Christoph Hellwig <hch@lst.de>
Suggested-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/phonet')
-rw-r--r-- | net/phonet/datagram.c | 8 | ||||
-rw-r--r-- | net/phonet/pep.c | 8 | ||||
-rw-r--r-- | net/phonet/socket.c | 6 |
3 files changed, 9 insertions, 13 deletions
diff --git a/net/phonet/datagram.c b/net/phonet/datagram.c index 26054b4b467c..5e710435ffa9 100644 --- a/net/phonet/datagram.c +++ b/net/phonet/datagram.c | |||
@@ -83,8 +83,7 @@ static int pn_init(struct sock *sk) | |||
83 | return 0; | 83 | return 0; |
84 | } | 84 | } |
85 | 85 | ||
86 | static int pn_sendmsg(struct kiocb *iocb, struct sock *sk, | 86 | static int pn_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) |
87 | struct msghdr *msg, size_t len) | ||
88 | { | 87 | { |
89 | DECLARE_SOCKADDR(struct sockaddr_pn *, target, msg->msg_name); | 88 | DECLARE_SOCKADDR(struct sockaddr_pn *, target, msg->msg_name); |
90 | struct sk_buff *skb; | 89 | struct sk_buff *skb; |
@@ -125,9 +124,8 @@ static int pn_sendmsg(struct kiocb *iocb, struct sock *sk, | |||
125 | return (err >= 0) ? len : err; | 124 | return (err >= 0) ? len : err; |
126 | } | 125 | } |
127 | 126 | ||
128 | static int pn_recvmsg(struct kiocb *iocb, struct sock *sk, | 127 | static int pn_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, |
129 | struct msghdr *msg, size_t len, int noblock, | 128 | int noblock, int flags, int *addr_len) |
130 | int flags, int *addr_len) | ||
131 | { | 129 | { |
132 | struct sk_buff *skb = NULL; | 130 | struct sk_buff *skb = NULL; |
133 | struct sockaddr_pn sa; | 131 | struct sockaddr_pn sa; |
diff --git a/net/phonet/pep.c b/net/phonet/pep.c index 5d3f2b7507d4..6de2aeb98a1f 100644 --- a/net/phonet/pep.c +++ b/net/phonet/pep.c | |||
@@ -1118,8 +1118,7 @@ static int pipe_skb_send(struct sock *sk, struct sk_buff *skb) | |||
1118 | 1118 | ||
1119 | } | 1119 | } |
1120 | 1120 | ||
1121 | static int pep_sendmsg(struct kiocb *iocb, struct sock *sk, | 1121 | static int pep_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) |
1122 | struct msghdr *msg, size_t len) | ||
1123 | { | 1122 | { |
1124 | struct pep_sock *pn = pep_sk(sk); | 1123 | struct pep_sock *pn = pep_sk(sk); |
1125 | struct sk_buff *skb; | 1124 | struct sk_buff *skb; |
@@ -1246,9 +1245,8 @@ struct sk_buff *pep_read(struct sock *sk) | |||
1246 | return skb; | 1245 | return skb; |
1247 | } | 1246 | } |
1248 | 1247 | ||
1249 | static int pep_recvmsg(struct kiocb *iocb, struct sock *sk, | 1248 | static int pep_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, |
1250 | struct msghdr *msg, size_t len, int noblock, | 1249 | int noblock, int flags, int *addr_len) |
1251 | int flags, int *addr_len) | ||
1252 | { | 1250 | { |
1253 | struct sk_buff *skb; | 1251 | struct sk_buff *skb; |
1254 | int err; | 1252 | int err; |
diff --git a/net/phonet/socket.c b/net/phonet/socket.c index 008214a3d5eb..d575ef4e9aa6 100644 --- a/net/phonet/socket.c +++ b/net/phonet/socket.c | |||
@@ -425,15 +425,15 @@ out: | |||
425 | return err; | 425 | return err; |
426 | } | 426 | } |
427 | 427 | ||
428 | static int pn_socket_sendmsg(struct kiocb *iocb, struct socket *sock, | 428 | static int pn_socket_sendmsg(struct socket *sock, struct msghdr *m, |
429 | struct msghdr *m, size_t total_len) | 429 | size_t total_len) |
430 | { | 430 | { |
431 | struct sock *sk = sock->sk; | 431 | struct sock *sk = sock->sk; |
432 | 432 | ||
433 | if (pn_socket_autobind(sock)) | 433 | if (pn_socket_autobind(sock)) |
434 | return -EAGAIN; | 434 | return -EAGAIN; |
435 | 435 | ||
436 | return sk->sk_prot->sendmsg(iocb, sk, m, total_len); | 436 | return sk->sk_prot->sendmsg(sk, m, total_len); |
437 | } | 437 | } |
438 | 438 | ||
439 | const struct proto_ops phonet_dgram_ops = { | 439 | const struct proto_ops phonet_dgram_ops = { |