aboutsummaryrefslogtreecommitdiffstats
path: root/net/phonet
diff options
context:
space:
mode:
authorRémi Denis-Courmont <remi.denis-courmont@nokia.com>2011-03-08 17:44:13 -0500
committerDavid S. Miller <davem@davemloft.net>2011-03-09 14:59:33 -0500
commita015f6f49968c330b236ca2f6c2170820414f922 (patch)
tree8370664c7d17ae1d1290622fa7b302919b13f4fe /net/phonet
parent297edb6003268c1d60da8c21eb76bf39b6428213 (diff)
Phonet: kill the ST-Ericsson pipe controller Kconfig
This is now a run-time choice so that a single kernel can support both old and new generation ISI modems. Support for manually enabling the pipe flow is removed as it did not work properly, does not fit well with the socket API, and I am not aware of any use at the moment. Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/phonet')
-rw-r--r--net/phonet/Kconfig12
-rw-r--r--net/phonet/pep.c25
2 files changed, 0 insertions, 37 deletions
diff --git a/net/phonet/Kconfig b/net/phonet/Kconfig
index 0d9b8a220a78..6ec7d55b1769 100644
--- a/net/phonet/Kconfig
+++ b/net/phonet/Kconfig
@@ -14,15 +14,3 @@ config PHONET
14 14
15 To compile this driver as a module, choose M here: the module 15 To compile this driver as a module, choose M here: the module
16 will be called phonet. If unsure, say N. 16 will be called phonet. If unsure, say N.
17
18config PHONET_PIPECTRLR
19 bool "Phonet Pipe Controller (EXPERIMENTAL)"
20 depends on PHONET && EXPERIMENTAL
21 default N
22 help
23 The Pipe Controller implementation in Phonet stack to support Pipe
24 data with Nokia Slim modems like WG2.5 used on ST-Ericsson U8500
25 platform.
26
27 This option is incompatible with older Nokia modems.
28 Say N here unless you really know what you are doing.
diff --git a/net/phonet/pep.c b/net/phonet/pep.c
index 671effb4ea15..68e635f11de8 100644
--- a/net/phonet/pep.c
+++ b/net/phonet/pep.c
@@ -167,15 +167,6 @@ static int pipe_handler_send_created_ind(struct sock *sk)
167 data, 4, GFP_ATOMIC); 167 data, 4, GFP_ATOMIC);
168} 168}
169 169
170#ifdef CONFIG_PHONET_PIPECTRLR
171static int pipe_handler_enable_pipe(struct sock *sk, int enable)
172{
173 u8 id = enable ? PNS_PEP_ENABLE_REQ : PNS_PEP_DISABLE_REQ;
174
175 return pipe_handler_request(sk, id, PAD, NULL, 0);
176}
177#endif
178
179static int pep_accept_conn(struct sock *sk, struct sk_buff *skb) 170static int pep_accept_conn(struct sock *sk, struct sk_buff *skb)
180{ 171{
181 static const u8 data[20] = { 172 static const u8 data[20] = {
@@ -968,16 +959,6 @@ static int pep_setsockopt(struct sock *sk, int level, int optname,
968 } 959 }
969 goto out_norel; 960 goto out_norel;
970 961
971#ifdef CONFIG_PHONET_PIPECTRLR
972 case PNPIPE_ENABLE:
973 if ((1 << sk->sk_state) & ~(TCPF_SYN_RECV|TCPF_ESTABLISHED)) {
974 err = -ENOTCONN;
975 break;
976 }
977 err = pipe_handler_enable_pipe(sk, val);
978 break;
979#endif
980
981 default: 962 default:
982 err = -ENOPROTOOPT; 963 err = -ENOPROTOOPT;
983 } 964 }
@@ -1013,12 +994,6 @@ static int pep_getsockopt(struct sock *sk, int level, int optname,
1013 return -EINVAL; 994 return -EINVAL;
1014 break; 995 break;
1015 996
1016#ifdef CONFIG_PHONET_PIPECTRLR
1017 case PNPIPE_ENABLE:
1018 val = sk->sk_state == TCP_ESTABLISHED;
1019 break;
1020#endif
1021
1022 default: 997 default:
1023 return -ENOPROTOOPT; 998 return -ENOPROTOOPT;
1024 } 999 }