diff options
author | Harvey Harrison <harvey.harrison@gmail.com> | 2008-11-07 02:10:50 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-11-07 02:10:50 -0500 |
commit | 5c7f0333584128c745fbda845abbe3a32c22d467 (patch) | |
tree | f3177803eb94aa9cbc1e28b1626cacfa06341cf3 /net/phonet/pep-gprs.c | |
parent | ca62059b7ec7267d1d2cab0791d3ed6d033e0583 (diff) |
phonet: sparse annotations of protocol, remove forward declaration
net/phonet/af_phonet.c:38:36: error: marked inline, but without a definition
net/phonet/pep-gprs.c:63:10: warning: incorrect type in return expression (different base types)
net/phonet/pep-gprs.c:63:10: expected int
net/phonet/pep-gprs.c:63:10: got restricted __be16 [usertype] <noident>
net/phonet/pep-gprs.c:65:10: warning: incorrect type in return expression (different base types)
net/phonet/pep-gprs.c:65:10: expected int
net/phonet/pep-gprs.c:65:10: got restricted __be16 [usertype] <noident>
net/phonet/pep-gprs.c:124:16: warning: incorrect type in assignment (different base types)
net/phonet/pep-gprs.c:124:16: expected restricted __be16 [usertype] protocol
net/phonet/pep-gprs.c:124:16: got unsigned short [unsigned] [usertype] protocol
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/phonet/pep-gprs.c')
-rw-r--r-- | net/phonet/pep-gprs.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/phonet/pep-gprs.c b/net/phonet/pep-gprs.c index 9978afbd9f2a..a4324075355f 100644 --- a/net/phonet/pep-gprs.c +++ b/net/phonet/pep-gprs.c | |||
@@ -49,14 +49,14 @@ struct gprs_dev { | |||
49 | unsigned tx_max; | 49 | unsigned tx_max; |
50 | }; | 50 | }; |
51 | 51 | ||
52 | static int gprs_type_trans(struct sk_buff *skb) | 52 | static __be16 gprs_type_trans(struct sk_buff *skb) |
53 | { | 53 | { |
54 | const u8 *pvfc; | 54 | const u8 *pvfc; |
55 | u8 buf; | 55 | u8 buf; |
56 | 56 | ||
57 | pvfc = skb_header_pointer(skb, 0, 1, &buf); | 57 | pvfc = skb_header_pointer(skb, 0, 1, &buf); |
58 | if (!pvfc) | 58 | if (!pvfc) |
59 | return 0; | 59 | return htons(0); |
60 | /* Look at IP version field */ | 60 | /* Look at IP version field */ |
61 | switch (*pvfc >> 4) { | 61 | switch (*pvfc >> 4) { |
62 | case 4: | 62 | case 4: |
@@ -64,7 +64,7 @@ static int gprs_type_trans(struct sk_buff *skb) | |||
64 | case 6: | 64 | case 6: |
65 | return htons(ETH_P_IPV6); | 65 | return htons(ETH_P_IPV6); |
66 | } | 66 | } |
67 | return 0; | 67 | return htons(0); |
68 | } | 68 | } |
69 | 69 | ||
70 | /* | 70 | /* |
@@ -84,7 +84,7 @@ static void gprs_state_change(struct sock *sk) | |||
84 | static int gprs_recv(struct gprs_dev *dev, struct sk_buff *skb) | 84 | static int gprs_recv(struct gprs_dev *dev, struct sk_buff *skb) |
85 | { | 85 | { |
86 | int err = 0; | 86 | int err = 0; |
87 | u16 protocol = gprs_type_trans(skb); | 87 | __be16 protocol = gprs_type_trans(skb); |
88 | 88 | ||
89 | if (!protocol) { | 89 | if (!protocol) { |
90 | err = -EINVAL; | 90 | err = -EINVAL; |