diff options
author | Danny Kukawka <danny.kukawka@bisect.de> | 2012-02-15 01:45:40 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-02-15 15:34:17 -0500 |
commit | 7ce5d222190cb3ce3ae88bafde7c4fa52a5103e0 (patch) | |
tree | 2b284365b7a2e11d4ba286a589bd35bc39918805 /net/openvswitch | |
parent | f2cedb63df14342ad40a8b5b324fc5d94a60b665 (diff) |
net: use eth_hw_addr_random() and reset addr_assign_type
Use eth_hw_addr_random() instead of calling random_ether_addr()
to set addr_assign_type correctly to NET_ADDR_RANDOM.
Reset the state to NET_ADDR_PERM as soon as the MAC get
changed via .ndo_set_mac_address.
v2: adapt to renamed eth_hw_addr_random()
Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/openvswitch')
-rw-r--r-- | net/openvswitch/vport-internal_dev.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index 322b8d206693..b6b1d7daa3cb 100644 --- a/net/openvswitch/vport-internal_dev.c +++ b/net/openvswitch/vport-internal_dev.c | |||
@@ -66,6 +66,7 @@ static int internal_dev_mac_addr(struct net_device *dev, void *p) | |||
66 | 66 | ||
67 | if (!is_valid_ether_addr(addr->sa_data)) | 67 | if (!is_valid_ether_addr(addr->sa_data)) |
68 | return -EADDRNOTAVAIL; | 68 | return -EADDRNOTAVAIL; |
69 | dev->addr_assign_type &= ~NET_ADDR_RANDOM; | ||
69 | memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); | 70 | memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); |
70 | return 0; | 71 | return 0; |
71 | } | 72 | } |
@@ -145,7 +146,7 @@ static void do_setup(struct net_device *netdev) | |||
145 | netdev->vlan_features = netdev->features; | 146 | netdev->vlan_features = netdev->features; |
146 | netdev->features |= NETIF_F_HW_VLAN_TX; | 147 | netdev->features |= NETIF_F_HW_VLAN_TX; |
147 | netdev->hw_features = netdev->features & ~NETIF_F_LLTX; | 148 | netdev->hw_features = netdev->features & ~NETIF_F_LLTX; |
148 | random_ether_addr(netdev->dev_addr); | 149 | eth_hw_addr_random(netdev); |
149 | } | 150 | } |
150 | 151 | ||
151 | static struct vport *internal_dev_create(const struct vport_parms *parms) | 152 | static struct vport *internal_dev_create(const struct vport_parms *parms) |