[AX25]: Make ax2asc thread-proof

Ax2asc was still using a static buffer for all invocations which isn't
exactly SMP-safe.  Change ax2asc to take an additional result buffer as
the argument.  Change all callers to provide such a buffer.

Signed-off-by: Ralf Baechle DL5RB <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

2 files changed, 9 insertions, 6 deletions

diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c
index 4b53de982114..f4578c759ffc 100644
--- a/net/netrom/af_netrom.c
+++ b/net/netrom/af_netrom.c
@@ -1261,6 +1261,7 @@ static int nr_info_show(struct seq_file *seq, void *v)
         struct net_device *dev;
         struct nr_sock *nr;
         const char *devname;
+        char buf[11];
 
         if (v == SEQ_START_TOKEN)
                 seq_puts(seq,
@@ -1276,11 +1277,11 @@ static int nr_info_show(struct seq_file *seq, void *v)
                 else
                         devname = dev->name;
 
-                seq_printf(seq, "%-9s ", ax2asc(&nr->user_addr));
-                seq_printf(seq, "%-9s ", ax2asc(&nr->dest_addr));
+                seq_printf(seq, "%-9s ", ax2asc(buf, &nr->user_addr));
+                seq_printf(seq, "%-9s ", ax2asc(buf, &nr->dest_addr));
                 seq_printf(seq, 
 "%-9s %-3s  %02X/%02X %02X/%02X %2d %3d %3d %3d %3lu/%03lu %2lu/%02lu %3lu/%03lu %3lu/%03lu %2d/%02d %3d %5d %5d %ld\n",
-                        ax2asc(&nr->source_addr),
+                        ax2asc(buf, &nr->source_addr),
                         devname,
                         nr->my_index,
                         nr->my_id,
diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index 7a86b36cba50..b3b9097c87c7 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -881,6 +881,7 @@ static void nr_node_stop(struct seq_file *seq, void *v)
 
 static int nr_node_show(struct seq_file *seq, void *v)
 {
+        char buf[11];
         int i;
 
         if (v == SEQ_START_TOKEN)
@@ -890,7 +891,7 @@ static int nr_node_show(struct seq_file *seq, void *v)
                 struct nr_node *nr_node = v;
                 nr_node_lock(nr_node);
                 seq_printf(seq, "%-9s %-7s  %d %d",
-                        ax2asc(&nr_node->callsign),
+                        ax2asc(buf, &nr_node->callsign),
                         (nr_node->mnemonic[0] == '\0') ? "*" : nr_node->mnemonic,
                         nr_node->which + 1,
                         nr_node->count);
@@ -964,6 +965,7 @@ static void nr_neigh_stop(struct seq_file *seq, void *v)
 
 static int nr_neigh_show(struct seq_file *seq, void *v)
 {
+        char buf[11];
         int i;
 
         if (v == SEQ_START_TOKEN)
@@ -973,7 +975,7 @@ static int nr_neigh_show(struct seq_file *seq, void *v)
 
                 seq_printf(seq, "%05d %-9s %-4s  %3d    %d   %3d    %3d",
                         nr_neigh->number,
-                        ax2asc(&nr_neigh->callsign),
+                        ax2asc(buf, &nr_neigh->callsign),
                         nr_neigh->dev ? nr_neigh->dev->name : "???",
                         nr_neigh->quality,
                         nr_neigh->locked,
@@ -983,7 +985,7 @@ static int nr_neigh_show(struct seq_file *seq, void *v)
                 if (nr_neigh->digipeat != NULL) {
                         for (i = 0; i < nr_neigh->digipeat->ndigi; i++)
                                 seq_printf(seq, " %s", 
-                                           ax2asc(&nr_neigh->digipeat->calls[i]));
+                                           ax2asc(buf, &nr_neigh->digipeat->calls[i]));
                 }
 
                 seq_puts(seq, "\n");