diff options
| author | Thomas Graf <tgraf@suug.ch> | 2006-11-10 17:10:15 -0500 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2006-12-03 00:22:11 -0500 |
| commit | 339bf98ffc6a8d8eb16fc532ac57ffbced2f8a68 (patch) | |
| tree | 499ad948863d2753ca10283dcf006ad28954538e /net/netlabel/netlabel_unlabeled.c | |
| parent | a94f723d595ee085f81b1788d18e031af7eeba91 (diff) | |
[NETLINK]: Do precise netlink message allocations where possible
Account for the netlink message header size directly in nlmsg_new()
instead of relying on the caller calculate it correctly.
Replaces error handling of message construction functions when
constructing notifications with bug traps since a failure implies
a bug in calculating the size of the skb.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlabel/netlabel_unlabeled.c')
| -rw-r--r-- | net/netlabel/netlabel_unlabeled.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c index 1833ad233b39..219dccade4e1 100644 --- a/net/netlabel/netlabel_unlabeled.c +++ b/net/netlabel/netlabel_unlabeled.c | |||
| @@ -138,7 +138,7 @@ static int netlbl_unlabel_list(struct sk_buff *skb, struct genl_info *info) | |||
| 138 | struct sk_buff *ans_skb; | 138 | struct sk_buff *ans_skb; |
| 139 | void *data; | 139 | void *data; |
| 140 | 140 | ||
| 141 | ans_skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); | 141 | ans_skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); |
| 142 | if (ans_skb == NULL) | 142 | if (ans_skb == NULL) |
| 143 | goto list_failure; | 143 | goto list_failure; |
| 144 | data = netlbl_netlink_hdr_put(ans_skb, | 144 | data = netlbl_netlink_hdr_put(ans_skb, |