mac80211: clean up ieee80211_stop_tx_ba_session

There's no sense in letting anything but internal
mac80211 functions set the initiator to anything
but WLAN_BACK_INITIATOR, since WLAN_BACK_RECIPIENT
is only valid when we have received a frame from
the peer, which we react to directly in mac80211.

The debugfs code I recently added got this wrong
as well.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

3 files changed, 8 insertions, 12 deletions

diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c
index c163d0a149f4..feb15c4a1fad 100644
--- a/net/mac80211/agg-tx.c
+++ b/net/mac80211/agg-tx.c
@@ -538,14 +538,13 @@ int __ieee80211_stop_tx_ba_session(struct sta_info *sta, u16 tid,
         return ret;
 }
 
-int ieee80211_stop_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
-                                 enum ieee80211_back_parties initiator)
+int ieee80211_stop_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid)
 {
         struct sta_info *sta = container_of(pubsta, struct sta_info, sta);
         struct ieee80211_sub_if_data *sdata = sta->sdata;
         struct ieee80211_local *local = sdata->local;
 
-        trace_api_stop_tx_ba_session(pubsta, tid, initiator);
+        trace_api_stop_tx_ba_session(pubsta, tid);
 
         if (!local->ops->ampdu_action)
                 return -EINVAL;
@@ -553,7 +552,7 @@ int ieee80211_stop_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
         if (tid >= STA_TID_NUM)
                 return -EINVAL;
 
-        return __ieee80211_stop_tx_ba_session(sta, tid, initiator);
+        return __ieee80211_stop_tx_ba_session(sta, tid, WLAN_BACK_INITIATOR);
 }
 EXPORT_SYMBOL(ieee80211_stop_tx_ba_session);
 
diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
index e763f1529ddb..9f140612224a 100644
--- a/net/mac80211/debugfs_sta.c
+++ b/net/mac80211/debugfs_sta.c
@@ -210,8 +210,7 @@ static ssize_t sta_agg_status_write(struct file *file, const char __user *userbu
                 if (start)
                         ret = ieee80211_start_tx_ba_session(&sta->sta, tid);
                 else
-                        ret = ieee80211_stop_tx_ba_session(&sta->sta, tid,
-                                                           WLAN_BACK_RECIPIENT);
+                        ret = ieee80211_stop_tx_ba_session(&sta->sta, tid);
         } else {
                 __ieee80211_stop_rx_ba_session(sta, tid, WLAN_BACK_RECIPIENT, 3);
                 ret = 0;
diff --git a/net/mac80211/driver-trace.h b/net/mac80211/driver-trace.h
index 577460da2ea1..6b90630151ab 100644
--- a/net/mac80211/driver-trace.h
+++ b/net/mac80211/driver-trace.h
@@ -876,25 +876,23 @@ TRACE_EVENT(api_start_tx_ba_cb,
 );
 
 TRACE_EVENT(api_stop_tx_ba_session,
-        TP_PROTO(struct ieee80211_sta *sta, u16 tid, u16 initiator),
+        TP_PROTO(struct ieee80211_sta *sta, u16 tid),
 
-        TP_ARGS(sta, tid, initiator),
+        TP_ARGS(sta, tid),
 
         TP_STRUCT__entry(
                 STA_ENTRY
                 __field(u16, tid)
-                __field(u16, initiator)
         ),
 
         TP_fast_assign(
                 STA_ASSIGN;
                 __entry->tid = tid;
-                __entry->initiator = initiator;
         ),
 
         TP_printk(
-                STA_PR_FMT " tid:%d initiator:%d",
-                STA_PR_ARG, __entry->tid, __entry->initiator
+                STA_PR_FMT " tid:%d",
+                STA_PR_ARG, __entry->tid
         )
 );