diff options
author | Johannes Berg <johannes@sipsolutions.net> | 2009-05-19 15:26:07 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-05-22 14:05:59 -0400 |
commit | 4ef699fb771d347b31ddafd214c0dd47b90f7f0f (patch) | |
tree | 6e27e3c02468d603488f632fce0faa7591d80fc9 /net/mac80211 | |
parent | 87057825824973f29cf2f37cff1e549170b2d7e6 (diff) |
mac80211: fix probe response wait timing
In "mac80211: split out and decrease probe wait time" I tried
to reduce the time waiting for a probe response, but failed to
take into account the case where we are detecting beacon loss
in software -- in that case we still wait the monitoring time
rather than the probe wait time. Fix this by refactoring the
mod_timer() calls in ieee80211_associated().
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211')
-rw-r--r-- | net/mac80211/mlme.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index b7f9c60793dd..ac6883f5a43e 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c | |||
@@ -1389,8 +1389,8 @@ static void ieee80211_associated(struct ieee80211_sub_if_data *sdata) | |||
1389 | ifmgd->flags |= IEEE80211_STA_PROBEREQ_POLL; | 1389 | ifmgd->flags |= IEEE80211_STA_PROBEREQ_POLL; |
1390 | ieee80211_send_probe_req(sdata, ifmgd->bssid, ifmgd->ssid, | 1390 | ieee80211_send_probe_req(sdata, ifmgd->bssid, ifmgd->ssid, |
1391 | ifmgd->ssid_len, NULL, 0); | 1391 | ifmgd->ssid_len, NULL, 0); |
1392 | mod_timer(&ifmgd->timer, jiffies + IEEE80211_PROBE_WAIT); | ||
1392 | goto unlock; | 1393 | goto unlock; |
1393 | |||
1394 | } | 1394 | } |
1395 | 1395 | ||
1396 | if (time_after(jiffies, sta->last_rx + IEEE80211_PROBE_IDLE_TIME)) { | 1396 | if (time_after(jiffies, sta->last_rx + IEEE80211_PROBE_IDLE_TIME)) { |
@@ -1399,15 +1399,16 @@ static void ieee80211_associated(struct ieee80211_sub_if_data *sdata) | |||
1399 | ifmgd->ssid_len, NULL, 0); | 1399 | ifmgd->ssid_len, NULL, 0); |
1400 | } | 1400 | } |
1401 | 1401 | ||
1402 | if (!disassoc) | ||
1403 | mod_timer(&ifmgd->timer, | ||
1404 | jiffies + IEEE80211_MONITORING_INTERVAL); | ||
1405 | |||
1402 | unlock: | 1406 | unlock: |
1403 | rcu_read_unlock(); | 1407 | rcu_read_unlock(); |
1404 | 1408 | ||
1405 | if (disassoc) | 1409 | if (disassoc) |
1406 | ieee80211_set_disassoc(sdata, true, true, | 1410 | ieee80211_set_disassoc(sdata, true, true, |
1407 | WLAN_REASON_PREV_AUTH_NOT_VALID); | 1411 | WLAN_REASON_PREV_AUTH_NOT_VALID); |
1408 | else | ||
1409 | mod_timer(&ifmgd->timer, jiffies + | ||
1410 | IEEE80211_MONITORING_INTERVAL); | ||
1411 | } | 1412 | } |
1412 | 1413 | ||
1413 | 1414 | ||