[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()

This is nicer than the MAC_FMT stuff.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

14 files changed, 225 insertions, 174 deletions

diff --git a/net/mac80211/debugfs_key.c b/net/mac80211/debugfs_key.c
index 8e4a1bcd16ea..c881524c8725 100644
--- a/net/mac80211/debugfs_key.c
+++ b/net/mac80211/debugfs_key.c
@@ -262,11 +262,12 @@ void ieee80211_debugfs_key_sta_link(struct ieee80211_key *key,
                                     struct sta_info *sta)
 {
         char buf[50];
+        DECLARE_MAC_BUF(mac);
 
         if (!key->debugfs.dir)
                 return;
 
-        sprintf(buf, "../../stations/" MAC_FMT, MAC_ARG(sta->addr));
+        sprintf(buf, "../../stations/%s", print_mac(mac, sta->addr));
         key->debugfs.stalink =
                 debugfs_create_symlink("station", key->debugfs.dir, buf);
 }
diff --git a/net/mac80211/debugfs_netdev.c b/net/mac80211/debugfs_netdev.c
index 8ceda33efc12..9efb84c47bb0 100644
--- a/net/mac80211/debugfs_netdev.c
+++ b/net/mac80211/debugfs_netdev.c
@@ -66,7 +66,8 @@ static ssize_t ieee80211_if_fmt_##name(					\
         const struct ieee80211_sub_if_data *sdata, char *buf,           \
         int buflen)                                                     \
 {                                                                       \
-        return scnprintf(buf, buflen, MAC_FMT "\n", MAC_ARG(sdata->field));\
+        DECLARE_MAC_BUF(mac);                                           \
+        return scnprintf(buf, buflen, "%s\n", print_mac(mac, sdata->field));\
 }
 
 #define __IEEE80211_IF_FILE(name)                                       \
diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
index 2daaa802bbd0..f7c717c906dc 100644
--- a/net/mac80211/debugfs_sta.c
+++ b/net/mac80211/debugfs_sta.c
@@ -203,15 +203,15 @@ STA_OPS(wme_tx_queue);
 
 void ieee80211_sta_debugfs_add(struct sta_info *sta)
 {
-        char buf[3*6];
         struct dentry *stations_dir = sta->local->debugfs.stations;
+        DECLARE_MAC_BUF(mac);
 
         if (!stations_dir)
                 return;
 
-        sprintf(buf, MAC_FMT, MAC_ARG(sta->addr));
+        print_mac(mac, sta->addr);
 
-        sta->debugfs.dir = debugfs_create_dir(buf, stations_dir);
+        sta->debugfs.dir = debugfs_create_dir(mac, stations_dir);
         if (!sta->debugfs.dir)
                 return;
 
diff --git a/net/mac80211/event.c b/net/mac80211/event.c
index 68a526cb7623..2280f40b4560 100644
--- a/net/mac80211/event.c
+++ b/net/mac80211/event.c
@@ -22,13 +22,14 @@ void mac80211_ev_michael_mic_failure(struct net_device *dev, int keyidx,
 {
         union iwreq_data wrqu;
         char *buf = kmalloc(128, GFP_ATOMIC);
+        DECLARE_MAC_BUF(mac);
 
         if (buf) {
                 /* TODO: needed parameters: count, key type, TSC */
                 sprintf(buf, "MLME-MICHAELMICFAILURE.indication("
-                        "keyid=%d %scast addr=" MAC_FMT ")",
+                        "keyid=%d %scast addr=%s)",
                         keyidx, hdr->addr1[0] & 0x01 ? "broad" : "uni",
-                        MAC_ARG(hdr->addr2));
+                        print_mac(mac, hdr->addr2));
                 memset(&wrqu, 0, sizeof(wrqu));
                 wrqu.data.length = strlen(buf);
                 wireless_send_event(dev, IWEVCUSTOM, &wrqu, buf);
diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index 0c1f7b2e157c..4229d150e783 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -602,6 +602,7 @@ int ieee80211_if_update_wds(struct net_device *dev, u8 *remote_addr)
         struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
         struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
         struct sta_info *sta;
+        DECLARE_MAC_BUF(mac);
 
         if (compare_ether_addr(remote_addr, sdata->u.wds.remote_addr) == 0)
                 return 0;
@@ -619,8 +620,8 @@ int ieee80211_if_update_wds(struct net_device *dev, u8 *remote_addr)
                 sta_info_put(sta);
         } else {
                 printk(KERN_DEBUG "%s: could not find STA entry for WDS link "
-                       "peer " MAC_FMT "\n",
-                       dev->name, MAC_ARG(sdata->u.wds.remote_addr));
+                       "peer %s\n",
+                       dev->name, print_mac(mac, sdata->u.wds.remote_addr));
         }
 
         /* Update WDS link data */
diff --git a/net/mac80211/ieee80211_ioctl.c b/net/mac80211/ieee80211_ioctl.c
index 51dca21f77c7..6ccdde82bded 100644
--- a/net/mac80211/ieee80211_ioctl.c
+++ b/net/mac80211/ieee80211_ioctl.c
@@ -98,9 +98,10 @@ static int ieee80211_set_encryption(struct net_device *dev, u8 *sta_addr,
                 sta = sta_info_get(local, sta_addr);
                 if (!sta) {
 #ifdef CONFIG_MAC80211_VERBOSE_DEBUG
+                        DECLARE_MAC_BUF(mac);
                         printk(KERN_DEBUG "%s: set_encrypt - unknown addr "
-                               MAC_FMT "\n",
-                               dev->name, MAC_ARG(sta_addr));
+                               "%s\n",
+                               dev->name, print_mac(mac, sta_addr));
 #endif /* CONFIG_MAC80211_VERBOSE_DEBUG */
 
                         return -ENOENT;
diff --git a/net/mac80211/ieee80211_sta.c b/net/mac80211/ieee80211_sta.c
index 8fdbd38e02c4..f47cbd294ceb 100644
--- a/net/mac80211/ieee80211_sta.c
+++ b/net/mac80211/ieee80211_sta.c
@@ -319,14 +319,15 @@ static void ieee80211_handle_erp_ie(struct net_device *dev, u8 erp_value)
         int use_protection = (erp_value & WLAN_ERP_USE_PROTECTION) != 0;
         int preamble_mode = (erp_value & WLAN_ERP_BARKER_PREAMBLE) != 0;
         u8 changes = 0;
+        DECLARE_MAC_BUF(mac);
 
         if (use_protection != !!(sdata->flags & IEEE80211_SDATA_USE_PROTECTION)) {
                 if (net_ratelimit()) {
                         printk(KERN_DEBUG "%s: CTS protection %s (BSSID="
-                               MAC_FMT ")\n",
+                               "%s)\n",
                                dev->name,
                                use_protection ? "enabled" : "disabled",
-                               MAC_ARG(ifsta->bssid));
+                               print_mac(mac, ifsta->bssid));
                 }
                 if (use_protection)
                         sdata->flags |= IEEE80211_SDATA_USE_PROTECTION;
@@ -338,11 +339,11 @@ static void ieee80211_handle_erp_ie(struct net_device *dev, u8 erp_value)
         if (preamble_mode != !(sdata->flags & IEEE80211_SDATA_SHORT_PREAMBLE)) {
                 if (net_ratelimit()) {
                         printk(KERN_DEBUG "%s: switched to %s barker preamble"
-                               " (BSSID=" MAC_FMT ")\n",
+                               " (BSSID=%s)\n",
                                dev->name,
                                (preamble_mode == WLAN_ERP_PREAMBLE_SHORT) ?
                                         "short" : "long",
-                               MAC_ARG(ifsta->bssid));
+                               print_mac(mac, ifsta->bssid));
                 }
                 if (preamble_mode)
                         sdata->flags &= ~IEEE80211_SDATA_SHORT_PREAMBLE;
@@ -524,18 +525,20 @@ static void ieee80211_send_auth(struct net_device *dev,
 static void ieee80211_authenticate(struct net_device *dev,
                                    struct ieee80211_if_sta *ifsta)
 {
+        DECLARE_MAC_BUF(mac);
+
         ifsta->auth_tries++;
         if (ifsta->auth_tries > IEEE80211_AUTH_MAX_TRIES) {
-                printk(KERN_DEBUG "%s: authentication with AP " MAC_FMT
+                printk(KERN_DEBUG "%s: authentication with AP %s"
                        " timed out\n",
-                       dev->name, MAC_ARG(ifsta->bssid));
+                       dev->name, print_mac(mac, ifsta->bssid));
                 ifsta->state = IEEE80211_DISABLED;
                 return;
         }
 
         ifsta->state = IEEE80211_AUTHENTICATE;
-        printk(KERN_DEBUG "%s: authenticate with AP " MAC_FMT "\n",
-               dev->name, MAC_ARG(ifsta->bssid));
+        printk(KERN_DEBUG "%s: authenticate with AP %s\n",
+               dev->name, print_mac(mac, ifsta->bssid));
 
         ieee80211_send_auth(dev, ifsta, 1, NULL, 0, 0);
 
@@ -744,18 +747,20 @@ static int ieee80211_privacy_mismatch(struct net_device *dev,
 static void ieee80211_associate(struct net_device *dev,
                                 struct ieee80211_if_sta *ifsta)
 {
+        DECLARE_MAC_BUF(mac);
+
         ifsta->assoc_tries++;
         if (ifsta->assoc_tries > IEEE80211_ASSOC_MAX_TRIES) {
-                printk(KERN_DEBUG "%s: association with AP " MAC_FMT
+                printk(KERN_DEBUG "%s: association with AP %s"
                        " timed out\n",
-                       dev->name, MAC_ARG(ifsta->bssid));
+                       dev->name, print_mac(mac, ifsta->bssid));
                 ifsta->state = IEEE80211_DISABLED;
                 return;
         }
 
         ifsta->state = IEEE80211_ASSOCIATE;
-        printk(KERN_DEBUG "%s: associate with AP " MAC_FMT "\n",
-               dev->name, MAC_ARG(ifsta->bssid));
+        printk(KERN_DEBUG "%s: associate with AP %s\n",
+               dev->name, print_mac(mac, ifsta->bssid));
         if (ieee80211_privacy_mismatch(dev, ifsta)) {
                 printk(KERN_DEBUG "%s: mismatch in privacy configuration and "
                        "mixed-cell disabled - abort association\n", dev->name);
@@ -775,6 +780,7 @@ static void ieee80211_associated(struct net_device *dev,
         struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
         struct sta_info *sta;
         int disassoc;
+        DECLARE_MAC_BUF(mac);
 
         /* TODO: start monitoring current AP signal quality and number of
          * missed beacons. Scan other channels every now and then and search
@@ -785,8 +791,8 @@ static void ieee80211_associated(struct net_device *dev,
 
         sta = sta_info_get(local, ifsta->bssid);
         if (!sta) {
-                printk(KERN_DEBUG "%s: No STA entry for own AP " MAC_FMT "\n",
-                       dev->name, MAC_ARG(ifsta->bssid));
+                printk(KERN_DEBUG "%s: No STA entry for own AP %s\n",
+                       dev->name, print_mac(mac, ifsta->bssid));
                 disassoc = 1;
         } else {
                 disassoc = 0;
@@ -794,9 +800,9 @@ static void ieee80211_associated(struct net_device *dev,
                                sta->last_rx + IEEE80211_MONITORING_INTERVAL)) {
                         if (ifsta->flags & IEEE80211_STA_PROBEREQ_POLL) {
                                 printk(KERN_DEBUG "%s: No ProbeResp from "
-                                       "current AP " MAC_FMT " - assume out of "
+                                       "current AP %s - assume out of "
                                        "range\n",
-                                       dev->name, MAC_ARG(ifsta->bssid));
+                                       dev->name, print_mac(mac, ifsta->bssid));
                                 disassoc = 1;
                                 sta_info_free(sta);
                         } else
@@ -944,37 +950,38 @@ static void ieee80211_rx_mgmt_auth(struct net_device *dev,
 {
         struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
         u16 auth_alg, auth_transaction, status_code;
+        DECLARE_MAC_BUF(mac);
 
         if (ifsta->state != IEEE80211_AUTHENTICATE &&
             sdata->type != IEEE80211_IF_TYPE_IBSS) {
                 printk(KERN_DEBUG "%s: authentication frame received from "
-                       MAC_FMT ", but not in authenticate state - ignored\n",
-                       dev->name, MAC_ARG(mgmt->sa));
+                       "%s, but not in authenticate state - ignored\n",
+                       dev->name, print_mac(mac, mgmt->sa));
                 return;
         }
 
         if (len < 24 + 6) {
                 printk(KERN_DEBUG "%s: too short (%zd) authentication frame "
-                       "received from " MAC_FMT " - ignored\n",
-                       dev->name, len, MAC_ARG(mgmt->sa));
+                       "received from %s - ignored\n",
+                       dev->name, len, print_mac(mac, mgmt->sa));
                 return;
         }
 
         if (sdata->type != IEEE80211_IF_TYPE_IBSS &&
             memcmp(ifsta->bssid, mgmt->sa, ETH_ALEN) != 0) {
                 printk(KERN_DEBUG "%s: authentication frame received from "
-                       "unknown AP (SA=" MAC_FMT " BSSID=" MAC_FMT ") - "
-                       "ignored\n", dev->name, MAC_ARG(mgmt->sa),
-                       MAC_ARG(mgmt->bssid));
+                       "unknown AP (SA=%s BSSID=%s) - "
+                       "ignored\n", dev->name, print_mac(mac, mgmt->sa),
+                       print_mac(mac, mgmt->bssid));
                 return;
         }
 
         if (sdata->type != IEEE80211_IF_TYPE_IBSS &&
             memcmp(ifsta->bssid, mgmt->bssid, ETH_ALEN) != 0) {
                 printk(KERN_DEBUG "%s: authentication frame received from "
-                       "unknown BSSID (SA=" MAC_FMT " BSSID=" MAC_FMT ") - "
-                       "ignored\n", dev->name, MAC_ARG(mgmt->sa),
-                       MAC_ARG(mgmt->bssid));
+                       "unknown BSSID (SA=%s BSSID=%s) - "
+                       "ignored\n", dev->name, print_mac(mac, mgmt->sa),
+                       print_mac(mac, mgmt->bssid));
                 return;
         }
 
@@ -982,9 +989,9 @@ static void ieee80211_rx_mgmt_auth(struct net_device *dev,
         auth_transaction = le16_to_cpu(mgmt->u.auth.auth_transaction);
         status_code = le16_to_cpu(mgmt->u.auth.status_code);
 
-        printk(KERN_DEBUG "%s: RX authentication from " MAC_FMT " (alg=%d "
+        printk(KERN_DEBUG "%s: RX authentication from %s (alg=%d "
                "transaction=%d status=%d)\n",
-               dev->name, MAC_ARG(mgmt->sa), auth_alg,
+               dev->name, print_mac(mac, mgmt->sa), auth_alg,
                auth_transaction, status_code);
 
         if (sdata->type == IEEE80211_IF_TYPE_IBSS) {
@@ -1071,27 +1078,28 @@ static void ieee80211_rx_mgmt_deauth(struct net_device *dev,
                                      size_t len)
 {
         u16 reason_code;
+        DECLARE_MAC_BUF(mac);
 
         if (len < 24 + 2) {
                 printk(KERN_DEBUG "%s: too short (%zd) deauthentication frame "
-                       "received from " MAC_FMT " - ignored\n",
-                       dev->name, len, MAC_ARG(mgmt->sa));
+                       "received from %s - ignored\n",
+                       dev->name, len, print_mac(mac, mgmt->sa));
                 return;
         }
 
         if (memcmp(ifsta->bssid, mgmt->sa, ETH_ALEN) != 0) {
                 printk(KERN_DEBUG "%s: deauthentication frame received from "
-                       "unknown AP (SA=" MAC_FMT " BSSID=" MAC_FMT ") - "
-                       "ignored\n", dev->name, MAC_ARG(mgmt->sa),
-                       MAC_ARG(mgmt->bssid));
+                       "unknown AP (SA=%s BSSID=%s) - "
+                       "ignored\n", dev->name, print_mac(mac, mgmt->sa),
+                       print_mac(mac, mgmt->bssid));
                 return;
         }
 
         reason_code = le16_to_cpu(mgmt->u.deauth.reason_code);
 
-        printk(KERN_DEBUG "%s: RX deauthentication from " MAC_FMT
+        printk(KERN_DEBUG "%s: RX deauthentication from %s"
                " (reason=%d)\n",
-               dev->name, MAC_ARG(mgmt->sa), reason_code);
+               dev->name, print_mac(mac, mgmt->sa), reason_code);
 
         if (ifsta->flags & IEEE80211_STA_AUTHENTICATED) {
                 printk(KERN_DEBUG "%s: deauthenticated\n", dev->name);
@@ -1116,27 +1124,28 @@ static void ieee80211_rx_mgmt_disassoc(struct net_device *dev,
                                        size_t len)
 {
         u16 reason_code;
+        DECLARE_MAC_BUF(mac);
 
         if (len < 24 + 2) {
                 printk(KERN_DEBUG "%s: too short (%zd) disassociation frame "
-                       "received from " MAC_FMT " - ignored\n",
-                       dev->name, len, MAC_ARG(mgmt->sa));
+                       "received from %s - ignored\n",
+                       dev->name, len, print_mac(mac, mgmt->sa));
                 return;
         }
 
         if (memcmp(ifsta->bssid, mgmt->sa, ETH_ALEN) != 0) {
                 printk(KERN_DEBUG "%s: disassociation frame received from "
-                       "unknown AP (SA=" MAC_FMT " BSSID=" MAC_FMT ") - "
-                       "ignored\n", dev->name, MAC_ARG(mgmt->sa),
-                       MAC_ARG(mgmt->bssid));
+                       "unknown AP (SA=%s BSSID=%s) - "
+                       "ignored\n", dev->name, print_mac(mac, mgmt->sa),
+                       print_mac(mac, mgmt->bssid));
                 return;
         }
 
         reason_code = le16_to_cpu(mgmt->u.disassoc.reason_code);
 
-        printk(KERN_DEBUG "%s: RX disassociation from " MAC_FMT
+        printk(KERN_DEBUG "%s: RX disassociation from %s"
                " (reason=%d)\n",
-               dev->name, MAC_ARG(mgmt->sa), reason_code);
+               dev->name, print_mac(mac, mgmt->sa), reason_code);
 
         if (ifsta->flags & IEEE80211_STA_ASSOCIATED)
                 printk(KERN_DEBUG "%s: disassociated\n", dev->name);
@@ -1165,29 +1174,30 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
         struct ieee802_11_elems elems;
         u8 *pos;
         int i, j;
+        DECLARE_MAC_BUF(mac);
 
         /* AssocResp and ReassocResp have identical structure, so process both
          * of them in this function. */
 
         if (ifsta->state != IEEE80211_ASSOCIATE) {
                 printk(KERN_DEBUG "%s: association frame received from "
-                       MAC_FMT ", but not in associate state - ignored\n",
-                       dev->name, MAC_ARG(mgmt->sa));
+                       "%s, but not in associate state - ignored\n",
+                       dev->name, print_mac(mac, mgmt->sa));
                 return;
         }
 
         if (len < 24 + 6) {
                 printk(KERN_DEBUG "%s: too short (%zd) association frame "
-                       "received from " MAC_FMT " - ignored\n",
-                       dev->name, len, MAC_ARG(mgmt->sa));
+                       "received from %s - ignored\n",
+                       dev->name, len, print_mac(mac, mgmt->sa));
                 return;
         }
 
         if (memcmp(ifsta->bssid, mgmt->sa, ETH_ALEN) != 0) {
                 printk(KERN_DEBUG "%s: association frame received from "
-                       "unknown AP (SA=" MAC_FMT " BSSID=" MAC_FMT ") - "
-                       "ignored\n", dev->name, MAC_ARG(mgmt->sa),
-                       MAC_ARG(mgmt->bssid));
+                       "unknown AP (SA=%s BSSID=%s) - "
+                       "ignored\n", dev->name, print_mac(mac, mgmt->sa),
+                       print_mac(mac, mgmt->bssid));
                 return;
         }
 
@@ -1199,9 +1209,9 @@ static void ieee80211_rx_mgmt_assoc_resp(struct net_device *dev,
                        "set\n", dev->name, aid);
         aid &= ~(BIT(15) | BIT(14));
 
-        printk(KERN_DEBUG "%s: RX %sssocResp from " MAC_FMT " (capab=0x%x "
+        printk(KERN_DEBUG "%s: RX %sssocResp from %s (capab=0x%x "
                "status=%d aid=%d)\n",
-               dev->name, reassoc ? "Rea" : "A", MAC_ARG(mgmt->sa),
+               dev->name, reassoc ? "Rea" : "A", print_mac(mac, mgmt->sa),
                capab_info, status_code, aid);
 
         if (status_code != WLAN_STATUS_SUCCESS) {
@@ -1435,14 +1445,16 @@ static void ieee80211_rx_bss_info(struct net_device *dev,
         struct sta_info *sta;
         struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
         u64 timestamp;
+        DECLARE_MAC_BUF(mac);
+        DECLARE_MAC_BUF(mac2);
 
         if (!beacon && memcmp(mgmt->da, dev->dev_addr, ETH_ALEN))
                 return; /* ignore ProbeResp to foreign address */
 
 #if 0
-        printk(KERN_DEBUG "%s: RX %s from " MAC_FMT " to " MAC_FMT "\n",
+        printk(KERN_DEBUG "%s: RX %s from %s to %s\n",
                dev->name, beacon ? "Beacon" : "Probe Response",
-               MAC_ARG(mgmt->sa), MAC_ARG(mgmt->da));
+               print_mac(mac, mgmt->sa), print_mac(mac2, mgmt->da));
 #endif
 
         baselen = (u8 *) mgmt->u.beacon.variable - (u8 *) mgmt;
@@ -1461,10 +1473,10 @@ static void ieee80211_rx_bss_info(struct net_device *dev,
                 else
                         tsf = -1LLU;
                 if (time_after(jiffies, last_tsf_debug + 5 * HZ)) {
-                        printk(KERN_DEBUG "RX beacon SA=" MAC_FMT " BSSID="
-                               MAC_FMT " TSF=0x%llx BCN=0x%llx diff=%lld "
+                        printk(KERN_DEBUG "RX beacon SA=%s BSSID="
+                               "%s TSF=0x%llx BCN=0x%llx diff=%lld "
                                "@%lu\n",
-                               MAC_ARG(mgmt->sa), MAC_ARG(mgmt->bssid),
+                               print_mac(mac, mgmt->sa), print_mac(mac2, mgmt->bssid),
                                (unsigned long long)tsf,
                                (unsigned long long)timestamp,
                                (unsigned long long)(tsf - timestamp),
@@ -1518,9 +1530,9 @@ static void ieee80211_rx_bss_info(struct net_device *dev,
                 }
                 if (sta->supp_rates != prev_rates) {
                         printk(KERN_DEBUG "%s: updated supp_rates set for "
-                               MAC_FMT " based on beacon info (0x%x & 0x%x -> "
+                               "%s based on beacon info (0x%x & 0x%x -> "
                                "0x%x)\n",
-                               dev->name, MAC_ARG(sta->addr), prev_rates,
+                               dev->name, print_mac(mac, sta->addr), prev_rates,
                                supp_rates, sta->supp_rates);
                 }
                 sta_info_put(sta);
@@ -1722,6 +1734,11 @@ static void ieee80211_rx_mgmt_probe_req(struct net_device *dev,
         struct sk_buff *skb;
         struct ieee80211_mgmt *resp;
         u8 *pos, *end;
+        DECLARE_MAC_BUF(mac);
+#ifdef CONFIG_MAC80211_IBSS_DEBUG
+        DECLARE_MAC_BUF(mac2);
+        DECLARE_MAC_BUF(mac3);
+#endif
 
         if (sdata->type != IEEE80211_IF_TYPE_IBSS ||
             ifsta->state != IEEE80211_IBSS_JOINED ||
@@ -1734,10 +1751,10 @@ static void ieee80211_rx_mgmt_probe_req(struct net_device *dev,
                 tx_last_beacon = 1;
 
 #ifdef CONFIG_MAC80211_IBSS_DEBUG
-        printk(KERN_DEBUG "%s: RX ProbeReq SA=" MAC_FMT " DA=" MAC_FMT " BSSID="
-               MAC_FMT " (tx_last_beacon=%d)\n",
-               dev->name, MAC_ARG(mgmt->sa), MAC_ARG(mgmt->da),
-               MAC_ARG(mgmt->bssid), tx_last_beacon);
+        printk(KERN_DEBUG "%s: RX ProbeReq SA=%s DA=%s BSSID="
+               "%s (tx_last_beacon=%d)\n",
+               dev->name, print_mac(mac, mgmt->sa), print_mac(mac2, mgmt->da),
+               print_mac(mac3, mgmt->bssid), tx_last_beacon);
 #endif /* CONFIG_MAC80211_IBSS_DEBUG */
 
         if (!tx_last_beacon)
@@ -1753,8 +1770,8 @@ static void ieee80211_rx_mgmt_probe_req(struct net_device *dev,
             pos + 2 + pos[1] > end) {
                 if (net_ratelimit()) {
                         printk(KERN_DEBUG "%s: Invalid SSID IE in ProbeReq "
-                               "from " MAC_FMT "\n",
-                               dev->name, MAC_ARG(mgmt->sa));
+                               "from %s\n",
+                               dev->name, print_mac(mac, mgmt->sa));
                 }
                 return;
         }
@@ -1773,8 +1790,8 @@ static void ieee80211_rx_mgmt_probe_req(struct net_device *dev,
         resp = (struct ieee80211_mgmt *) skb->data;
         memcpy(resp->da, mgmt->sa, ETH_ALEN);
 #ifdef CONFIG_MAC80211_IBSS_DEBUG
-        printk(KERN_DEBUG "%s: Sending ProbeResp to " MAC_FMT "\n",
-               dev->name, MAC_ARG(resp->da));
+        printk(KERN_DEBUG "%s: Sending ProbeResp to %s\n",
+               dev->name, print_mac(mac, resp->da));
 #endif /* CONFIG_MAC80211_IBSS_DEBUG */
         ieee80211_sta_tx(dev, skb, 0);
 }
@@ -1925,13 +1942,14 @@ static void ieee80211_sta_expire(struct net_device *dev)
         struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
         struct sta_info *sta, *tmp;
         LIST_HEAD(tmp_list);
+        DECLARE_MAC_BUF(mac);
 
         write_lock_bh(&local->sta_lock);
         list_for_each_entry_safe(sta, tmp, &local->sta_list, list)
                 if (time_after(jiffies, sta->last_rx +
                                IEEE80211_IBSS_INACTIVITY_LIMIT)) {
-                        printk(KERN_DEBUG "%s: expiring inactive STA " MAC_FMT
-                               "\n", dev->name, MAC_ARG(sta->addr));
+                        printk(KERN_DEBUG "%s: expiring inactive STA %s\n",
+                               dev->name, print_mac(mac, sta->addr));
                         __sta_info_get(sta);
                         sta_info_remove(sta);
                         list_add(&sta->list, &tmp_list);
@@ -2362,6 +2380,7 @@ static int ieee80211_sta_create_ibss(struct net_device *dev,
         struct ieee80211_hw_mode *mode;
         u8 bssid[ETH_ALEN], *pos;
         int i;
+        DECLARE_MAC_BUF(mac);
 
 #if 0
         /* Easier testing, use fixed BSSID. */
@@ -2377,8 +2396,8 @@ static int ieee80211_sta_create_ibss(struct net_device *dev,
         bssid[0] |= 0x02;
 #endif
 
-        printk(KERN_DEBUG "%s: Creating new IBSS network, BSSID " MAC_FMT "\n",
-               dev->name, MAC_ARG(bssid));
+        printk(KERN_DEBUG "%s: Creating new IBSS network, BSSID %s\n",
+               dev->name, print_mac(mac, bssid));
 
         bss = ieee80211_rx_bss_add(dev, bssid);
         if (!bss)
@@ -2418,6 +2437,8 @@ static int ieee80211_sta_find_ibss(struct net_device *dev,
         int found = 0;
         u8 bssid[ETH_ALEN];
         int active_ibss;
+        DECLARE_MAC_BUF(mac);
+        DECLARE_MAC_BUF(mac2);
 
         if (ifsta->ssid_len == 0)
                 return -EINVAL;
@@ -2434,8 +2455,8 @@ static int ieee80211_sta_find_ibss(struct net_device *dev,
                     || !(bss->capability & WLAN_CAPABILITY_IBSS))
                         continue;
 #ifdef CONFIG_MAC80211_IBSS_DEBUG
-                printk(KERN_DEBUG "   bssid=" MAC_FMT " found\n",
-                       MAC_ARG(bss->bssid));
+                printk(KERN_DEBUG "   bssid=%s found\n",
+                       print_mac(mac, bss->bssid));
 #endif /* CONFIG_MAC80211_IBSS_DEBUG */
                 memcpy(bssid, bss->bssid, ETH_ALEN);
                 found = 1;
@@ -2445,14 +2466,14 @@ static int ieee80211_sta_find_ibss(struct net_device *dev,
         spin_unlock_bh(&local->sta_bss_lock);
 
 #ifdef CONFIG_MAC80211_IBSS_DEBUG
-        printk(KERN_DEBUG "   sta_find_ibss: selected " MAC_FMT " current "
-               MAC_FMT "\n", MAC_ARG(bssid), MAC_ARG(ifsta->bssid));
+        printk(KERN_DEBUG "   sta_find_ibss: selected %s current "
+               "%s\n", print_mac(mac, bssid), print_mac(mac2, ifsta->bssid));
 #endif /* CONFIG_MAC80211_IBSS_DEBUG */
         if (found && memcmp(ifsta->bssid, bssid, ETH_ALEN) != 0 &&
             (bss = ieee80211_rx_bss_get(dev, bssid))) {
-                printk(KERN_DEBUG "%s: Selected IBSS BSSID " MAC_FMT
+                printk(KERN_DEBUG "%s: Selected IBSS BSSID %s"
                        " based on configured SSID\n",
-                       dev->name, MAC_ARG(bssid));
+                       dev->name, print_mac(mac, bssid));
                 return ieee80211_sta_join_ibss(dev, ifsta, bss);
         }
 #ifdef CONFIG_MAC80211_IBSS_DEBUG
@@ -3070,19 +3091,20 @@ struct sta_info * ieee80211_ibss_add_sta(struct net_device *dev,
         struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
         struct sta_info *sta;
         struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
+        DECLARE_MAC_BUF(mac);
 
         /* TODO: Could consider removing the least recently used entry and
          * allow new one to be added. */
         if (local->num_sta >= IEEE80211_IBSS_MAX_STA_ENTRIES) {
                 if (net_ratelimit()) {
                         printk(KERN_DEBUG "%s: No room for a new IBSS STA "
-                               "entry " MAC_FMT "\n", dev->name, MAC_ARG(addr));
+                               "entry %s\n", dev->name, print_mac(mac, addr));
                 }
                 return NULL;
         }
 
-        printk(KERN_DEBUG "%s: Adding new IBSS station " MAC_FMT " (dev=%s)\n",
-               local->mdev->name, MAC_ARG(addr), dev->name);
+        printk(KERN_DEBUG "%s: Adding new IBSS station %s (dev=%s)\n",
+               local->mdev->name, print_mac(mac, addr), dev->name);
 
         sta = sta_info_add(local, dev, addr, GFP_ATOMIC);
         if (!sta)
diff --git a/net/mac80211/key.c b/net/mac80211/key.c
index dd6fc4aa3ff5..c10e53afbb4f 100644
--- a/net/mac80211/key.c
+++ b/net/mac80211/key.c
@@ -63,6 +63,7 @@ static void ieee80211_key_enable_hw_accel(struct ieee80211_key *key)
 {
         const u8 *addr;
         int ret;
+        DECLARE_MAC_BUF(mac);
 
         if (!key->local->ops->set_key)
                 return;
@@ -78,15 +79,16 @@ static void ieee80211_key_enable_hw_accel(struct ieee80211_key *key)
 
         if (ret && ret != -ENOSPC && ret != -EOPNOTSUPP)
                 printk(KERN_ERR "mac80211-%s: failed to set key "
-                       "(%d, " MAC_FMT ") to hardware (%d)\n",
+                       "(%d, %s) to hardware (%d)\n",
                        wiphy_name(key->local->hw.wiphy),
-                       key->conf.keyidx, MAC_ARG(addr), ret);
+                       key->conf.keyidx, print_mac(mac, addr), ret);
 }
 
 static void ieee80211_key_disable_hw_accel(struct ieee80211_key *key)
 {
         const u8 *addr;
         int ret;
+        DECLARE_MAC_BUF(mac);
 
         if (!key->local->ops->set_key)
                 return;
@@ -102,9 +104,9 @@ static void ieee80211_key_disable_hw_accel(struct ieee80211_key *key)
 
         if (ret)
                 printk(KERN_ERR "mac80211-%s: failed to remove key "
-                       "(%d, " MAC_FMT ") from hardware (%d)\n",
+                       "(%d, %s) from hardware (%d)\n",
                        wiphy_name(key->local->hw.wiphy),
-                       key->conf.keyidx, MAC_ARG(addr), ret);
+                       key->conf.keyidx, print_mac(mac, addr), ret);
 
         key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;
 }
diff --git a/net/mac80211/rc80211_simple.c b/net/mac80211/rc80211_simple.c
index ef91ce428aca..314b8de88862 100644
--- a/net/mac80211/rc80211_simple.c
+++ b/net/mac80211/rc80211_simple.c
@@ -201,9 +201,10 @@ static void rate_control_simple_tx_status(void *priv, struct net_device *dev,
                 srctrl->avg_rate_update = jiffies;
                 if (srctrl->tx_avg_rate_num > 0) {
 #ifdef CONFIG_MAC80211_VERBOSE_DEBUG
-                        printk(KERN_DEBUG "%s: STA " MAC_FMT " Average rate: "
+                        DECLARE_MAC_BUF(mac);
+                        printk(KERN_DEBUG "%s: STA %s Average rate: "
                                "%d (%d/%d)\n",
-                               dev->name, MAC_ARG(sta->addr),
+                               dev->name, print_mac(mac, sta->addr),
                                srctrl->tx_avg_rate_sum /
                                srctrl->tx_avg_rate_num,
                                srctrl->tx_avg_rate_sum,
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index c985c7a537db..e9dcc6229c3c 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -403,6 +403,8 @@ ieee80211_rx_h_load_key(struct ieee80211_txrx_data *rx)
 static void ap_sta_ps_start(struct net_device *dev, struct sta_info *sta)
 {
         struct ieee80211_sub_if_data *sdata;
+        DECLARE_MAC_BUF(mac);
+
         sdata = IEEE80211_DEV_TO_SUB_IF(sta->dev);
 
         if (sdata->bss)
@@ -410,8 +412,8 @@ static void ap_sta_ps_start(struct net_device *dev, struct sta_info *sta)
         sta->flags |= WLAN_STA_PS;
         sta->pspoll = 0;
 #ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
-        printk(KERN_DEBUG "%s: STA " MAC_FMT " aid %d enters power "
-               "save mode\n", dev->name, MAC_ARG(sta->addr), sta->aid);
+        printk(KERN_DEBUG "%s: STA %s aid %d enters power save mode\n",
+               dev->name, print_mac(mac, sta->addr), sta->aid);
 #endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
 }
 
@@ -422,6 +424,7 @@ static int ap_sta_ps_end(struct net_device *dev, struct sta_info *sta)
         int sent = 0;
         struct ieee80211_sub_if_data *sdata;
         struct ieee80211_tx_packet_data *pkt_data;
+        DECLARE_MAC_BUF(mac);
 
         sdata = IEEE80211_DEV_TO_SUB_IF(sta->dev);
         if (sdata->bss)
@@ -435,8 +438,8 @@ static int ap_sta_ps_end(struct net_device *dev, struct sta_info *sta)
                         bss_tim_clear(local, sdata->bss, sta->aid);
         }
 #ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
-        printk(KERN_DEBUG "%s: STA " MAC_FMT " aid %d exits power "
-               "save mode\n", dev->name, MAC_ARG(sta->addr), sta->aid);
+        printk(KERN_DEBUG "%s: STA %s aid %d exits power save mode\n",
+               dev->name, print_mac(mac, sta->addr), sta->aid);
 #endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
         /* Send all buffered frames to the station */
         while ((skb = skb_dequeue(&sta->tx_filtered)) != NULL) {
@@ -450,9 +453,9 @@ static int ap_sta_ps_end(struct net_device *dev, struct sta_info *sta)
                 local->total_ps_buffered--;
                 sent++;
 #ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
-                printk(KERN_DEBUG "%s: STA " MAC_FMT " aid %d send PS frame "
+                printk(KERN_DEBUG "%s: STA %s aid %d send PS frame "
                        "since STA not sleeping anymore\n", dev->name,
-                       MAC_ARG(sta->addr), sta->aid);
+                       print_mac(mac, sta->addr), sta->aid);
 #endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
                 pkt_data->flags |= IEEE80211_TXPD_REQUEUE;
                 dev_queue_xmit(skb);
@@ -590,13 +593,15 @@ ieee80211_reassemble_add(struct ieee80211_sub_if_data *sdata,
 #ifdef CONFIG_MAC80211_DEBUG
                 struct ieee80211_hdr *hdr =
                         (struct ieee80211_hdr *) entry->skb_list.next->data;
+                DECLARE_MAC_BUF(mac);
+                DECLARE_MAC_BUF(mac2);
                 printk(KERN_DEBUG "%s: RX reassembly removed oldest "
                        "fragment entry (idx=%d age=%lu seq=%d last_frag=%d "
-                       "addr1=" MAC_FMT " addr2=" MAC_FMT "\n",
+                       "addr1=%s addr2=%s\n",
                        sdata->dev->name, idx,
                        jiffies - entry->first_frag_time, entry->seq,
-                       entry->last_frag, MAC_ARG(hdr->addr1),
-                       MAC_ARG(hdr->addr2));
+                       entry->last_frag, print_mac(mac, hdr->addr1),
+                       print_mac(mac2, hdr->addr2));
 #endif /* CONFIG_MAC80211_DEBUG */
                 __skb_queue_purge(&entry->skb_list);
         }
@@ -662,6 +667,7 @@ ieee80211_rx_h_defragment(struct ieee80211_txrx_data *rx)
         unsigned int frag, seq;
         struct ieee80211_fragment_entry *entry;
         struct sk_buff *skb;
+        DECLARE_MAC_BUF(mac);
 
         hdr = (struct ieee80211_hdr *) rx->skb->data;
         sc = le16_to_cpu(hdr->seq_ctrl);
@@ -720,10 +726,10 @@ ieee80211_rx_h_defragment(struct ieee80211_txrx_data *rx)
                 if (memcmp(pn, rpn, CCMP_PN_LEN) != 0) {
                         if (net_ratelimit())
                                 printk(KERN_DEBUG "%s: defrag: CCMP PN not "
-                                       "sequential A2=" MAC_FMT
+                                       "sequential A2=%s"
                                        " PN=%02x%02x%02x%02x%02x%02x "
                                        "(expected %02x%02x%02x%02x%02x%02x)\n",
-                                       rx->dev->name, MAC_ARG(hdr->addr2),
+                                       rx->dev->name, print_mac(mac, hdr->addr2),
                                        rpn[0], rpn[1], rpn[2], rpn[3], rpn[4],
                                        rpn[5], pn[0], pn[1], pn[2], pn[3],
                                        pn[4], pn[5]);
@@ -774,6 +780,7 @@ ieee80211_rx_h_ps_poll(struct ieee80211_txrx_data *rx)
 {
         struct sk_buff *skb;
         int no_pending_pkts;
+        DECLARE_MAC_BUF(mac);
 
         if (likely(!rx->sta ||
                    (rx->fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_CTL ||
@@ -799,9 +806,8 @@ ieee80211_rx_h_ps_poll(struct ieee80211_txrx_data *rx)
                 rx->sta->pspoll = 1;
 
 #ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
-                printk(KERN_DEBUG "STA " MAC_FMT " aid %d: PS Poll (entries "
-                       "after %d)\n",
-                       MAC_ARG(rx->sta->addr), rx->sta->aid,
+                printk(KERN_DEBUG "STA %s aid %d: PS Poll (entries after %d)\n",
+                       print_mac(mac, rx->sta->addr), rx->sta->aid,
                        skb_queue_len(&rx->sta->ps_tx_buf));
 #endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
 
@@ -824,9 +830,9 @@ ieee80211_rx_h_ps_poll(struct ieee80211_txrx_data *rx)
                 }
 #ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
         } else if (!rx->u.rx.sent_ps_buffered) {
-                printk(KERN_DEBUG "%s: STA " MAC_FMT " sent PS Poll even "
+                printk(KERN_DEBUG "%s: STA %s sent PS Poll even "
                        "though there is no buffered frames for it\n",
-                       rx->dev->name, MAC_ARG(rx->sta->addr));
+                       rx->dev->name, print_mac(mac, rx->sta->addr));
 #endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
 
         }
@@ -881,9 +887,10 @@ ieee80211_rx_h_802_1x_pae(struct ieee80211_txrx_data *rx)
 #ifdef CONFIG_MAC80211_DEBUG
                 struct ieee80211_hdr *hdr =
                         (struct ieee80211_hdr *) rx->skb->data;
-                printk(KERN_DEBUG "%s: dropped frame from " MAC_FMT
+                DECLARE_MAC_BUF(mac);
+                printk(KERN_DEBUG "%s: dropped frame from %s"
                        " (unauthorized port)\n", rx->dev->name,
-                       MAC_ARG(hdr->addr2));
+                       print_mac(mac, hdr->addr2));
 #endif /* CONFIG_MAC80211_DEBUG */
                 return TXRX_DROP;
         }
@@ -928,6 +935,10 @@ ieee80211_rx_h_data(struct ieee80211_txrx_data *rx)
         u8 src[ETH_ALEN];
         struct sk_buff *skb = rx->skb, *skb2;
         struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
+        DECLARE_MAC_BUF(mac);
+        DECLARE_MAC_BUF(mac2);
+        DECLARE_MAC_BUF(mac3);
+        DECLARE_MAC_BUF(mac4);
 
         fc = rx->fc;
         if (unlikely((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA))
@@ -958,13 +969,11 @@ ieee80211_rx_h_data(struct ieee80211_txrx_data *rx)
                              sdata->type != IEEE80211_IF_TYPE_VLAN)) {
                         if (net_ratelimit())
                                 printk(KERN_DEBUG "%s: dropped ToDS frame "
-                                       "(BSSID=" MAC_FMT
-                                       " SA=" MAC_FMT
-                                       " DA=" MAC_FMT ")\n",
+                                       "(BSSID=%s SA=%s DA=%s)\n",
                                        dev->name,
-                                       MAC_ARG(hdr->addr1),
-                                       MAC_ARG(hdr->addr2),
-                                       MAC_ARG(hdr->addr3));
+                                       print_mac(mac, hdr->addr1),
+                                       print_mac(mac2, hdr->addr2),
+                                       print_mac(mac3, hdr->addr3));
                         return TXRX_DROP;
                 }
                 break;
@@ -976,14 +985,12 @@ ieee80211_rx_h_data(struct ieee80211_txrx_data *rx)
                 if (unlikely(sdata->type != IEEE80211_IF_TYPE_WDS)) {
                         if (net_ratelimit())
                                 printk(KERN_DEBUG "%s: dropped FromDS&ToDS "
-                                       "frame (RA=" MAC_FMT
-                                       " TA=" MAC_FMT " DA=" MAC_FMT
-                                       " SA=" MAC_FMT ")\n",
+                                       "frame (RA=%s TA=%s DA=%s SA=%s)\n",
                                        rx->dev->name,
-                                       MAC_ARG(hdr->addr1),
-                                       MAC_ARG(hdr->addr2),
-                                       MAC_ARG(hdr->addr3),
-                                       MAC_ARG(hdr->addr4));
+                                       print_mac(mac, hdr->addr1),
+                                       print_mac(mac2, hdr->addr2),
+                                       print_mac(mac3, hdr->addr3),
+                                       print_mac(mac4, hdr->addr4));
                         return TXRX_DROP;
                 }
                 break;
@@ -1004,12 +1011,12 @@ ieee80211_rx_h_data(struct ieee80211_txrx_data *rx)
 
                 if (sdata->type != IEEE80211_IF_TYPE_IBSS) {
                         if (net_ratelimit()) {
-                                printk(KERN_DEBUG "%s: dropped IBSS frame (DA="
-                                       MAC_FMT " SA=" MAC_FMT " BSSID=" MAC_FMT
-                                       ")\n",
-                                       dev->name, MAC_ARG(hdr->addr1),
-                                       MAC_ARG(hdr->addr2),
-                                       MAC_ARG(hdr->addr3));
+                                printk(KERN_DEBUG "%s: dropped IBSS frame "
+                                       "(DA=%s SA=%s BSSID=%s)\n",
+                                       dev->name,
+                                       print_mac(mac, hdr->addr1),
+                                       print_mac(mac2, hdr->addr2),
+                                       print_mac(mac3, hdr->addr3));
                         }
                         return TXRX_DROP;
                 }
@@ -1172,6 +1179,8 @@ static void ieee80211_rx_michael_mic_report(struct net_device *dev,
                                             struct ieee80211_txrx_data *rx)
 {
         int keyidx, hdrlen;
+        DECLARE_MAC_BUF(mac);
+        DECLARE_MAC_BUF(mac2);
 
         hdrlen = ieee80211_get_hdrlen_from_skb(rx->skb);
         if (rx->skb->len >= hdrlen + 4)
@@ -1181,9 +1190,9 @@ static void ieee80211_rx_michael_mic_report(struct net_device *dev,
 
         if (net_ratelimit())
                 printk(KERN_DEBUG "%s: TKIP hwaccel reported Michael MIC "
-                       "failure from " MAC_FMT " to " MAC_FMT " keyidx=%d\n",
-                       dev->name, MAC_ARG(hdr->addr2), MAC_ARG(hdr->addr1),
-                       keyidx);
+                       "failure from %s to %s keyidx=%d\n",
+                       dev->name, print_mac(mac, hdr->addr2),
+                       print_mac(mac2, hdr->addr1), keyidx);
 
         if (!sta) {
                 /*
@@ -1192,8 +1201,8 @@ static void ieee80211_rx_michael_mic_report(struct net_device *dev,
                  */
                 if (net_ratelimit())
                         printk(KERN_DEBUG "%s: ignored spurious Michael MIC "
-                               "error for unknown address " MAC_FMT "\n",
-                               dev->name, MAC_ARG(hdr->addr2));
+                               "error for unknown address %s\n",
+                               dev->name, print_mac(mac, hdr->addr2));
                 goto ignore;
         }
 
@@ -1201,7 +1210,7 @@ static void ieee80211_rx_michael_mic_report(struct net_device *dev,
                 if (net_ratelimit())
                         printk(KERN_DEBUG "%s: ignored spurious Michael MIC "
                                "error for a frame with no PROTECTED flag (src "
-                               MAC_FMT ")\n", dev->name, MAC_ARG(hdr->addr2));
+                               "%s)\n", dev->name, print_mac(mac, hdr->addr2));
                 goto ignore;
         }
 
@@ -1215,8 +1224,8 @@ static void ieee80211_rx_michael_mic_report(struct net_device *dev,
                 if (net_ratelimit())
                         printk(KERN_DEBUG "%s: ignored Michael MIC error for "
                                "a frame with non-zero keyidx (%d)"
-                               " (src " MAC_FMT ")\n", dev->name, keyidx,
-                               MAC_ARG(hdr->addr2));
+                               " (src %s)\n", dev->name, keyidx,
+                               print_mac(mac, hdr->addr2));
                 goto ignore;
         }
 
@@ -1226,8 +1235,8 @@ static void ieee80211_rx_michael_mic_report(struct net_device *dev,
                 if (net_ratelimit())
                         printk(KERN_DEBUG "%s: ignored spurious Michael MIC "
                                "error for a frame that cannot be encrypted "
-                               "(fc=0x%04x) (src " MAC_FMT ")\n",
-                               dev->name, rx->fc, MAC_ARG(hdr->addr2));
+                               "(fc=0x%04x) (src %s)\n",
+                               dev->name, rx->fc, print_mac(mac, hdr->addr2));
                 goto ignore;
         }
 
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index c17172abb21c..44d983404952 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -132,6 +132,7 @@ struct sta_info * sta_info_add(struct ieee80211_local *local,
                                struct net_device *dev, u8 *addr, gfp_t gfp)
 {
         struct sta_info *sta;
+        DECLARE_MAC_BUF(mac);
 
         sta = kzalloc(sizeof(*sta), gfp);
         if (!sta)
@@ -164,8 +165,8 @@ struct sta_info * sta_info_add(struct ieee80211_local *local,
         write_unlock_bh(&local->sta_lock);
 
 #ifdef CONFIG_MAC80211_VERBOSE_DEBUG
-        printk(KERN_DEBUG "%s: Added STA " MAC_FMT "\n",
-               local->mdev->name, MAC_ARG(addr));
+        printk(KERN_DEBUG "%s: Added STA %s\n",
+               local->mdev->name, print_mac(mac, addr));
 #endif /* CONFIG_MAC80211_VERBOSE_DEBUG */
 
 #ifdef CONFIG_MAC80211_DEBUGFS
@@ -207,6 +208,7 @@ void sta_info_free(struct sta_info *sta)
 {
         struct sk_buff *skb;
         struct ieee80211_local *local = sta->local;
+        DECLARE_MAC_BUF(mac);
 
         might_sleep();
 
@@ -223,8 +225,8 @@ void sta_info_free(struct sta_info *sta)
         }
 
 #ifdef CONFIG_MAC80211_VERBOSE_DEBUG
-        printk(KERN_DEBUG "%s: Removed STA " MAC_FMT "\n",
-               local->mdev->name, MAC_ARG(sta->addr));
+        printk(KERN_DEBUG "%s: Removed STA %s\n",
+               local->mdev->name, print_mac(mac, sta->addr));
 #endif /* CONFIG_MAC80211_VERBOSE_DEBUG */
 
         ieee80211_key_free(sta->key);
@@ -263,6 +265,7 @@ static void sta_info_cleanup_expire_buffered(struct ieee80211_local *local,
 {
         unsigned long flags;
         struct sk_buff *skb;
+        DECLARE_MAC_BUF(mac);
 
         if (skb_queue_empty(&sta->ps_tx_buf))
                 return;
@@ -281,7 +284,7 @@ static void sta_info_cleanup_expire_buffered(struct ieee80211_local *local,
                 if (skb) {
                         local->total_ps_buffered--;
                         printk(KERN_DEBUG "Buffered frame expired (STA "
-                               MAC_FMT ")\n", MAC_ARG(sta->addr));
+                               "%s)\n", print_mac(mac, sta->addr));
                         dev_kfree_skb(skb);
                 } else
                         break;
diff --git a/net/mac80211/tkip.c b/net/mac80211/tkip.c
index b9c1d5405180..5b11f14abfba 100644
--- a/net/mac80211/tkip.c
+++ b/net/mac80211/tkip.c
@@ -275,9 +275,10 @@ int ieee80211_tkip_decrypt_data(struct crypto_blkcipher *tfm,
              (iv32 == key->u.tkip.iv32_rx[queue] &&
               iv16 <= key->u.tkip.iv16_rx[queue]))) {
 #ifdef CONFIG_TKIP_DEBUG
+                DECLARE_MAC_BUF(mac);
                 printk(KERN_DEBUG "TKIP replay detected for RX frame from "
-                       MAC_FMT " (RX IV (%04x,%02x) <= prev. IV (%04x,%02x)\n",
-                       MAC_ARG(ta),
+                       "%s (RX IV (%04x,%02x) <= prev. IV (%04x,%02x)\n",
+                       print_mac(mac, ta),
                        iv32, iv16, key->u.tkip.iv32_rx[queue],
                        key->u.tkip.iv16_rx[queue]);
 #endif /* CONFIG_TKIP_DEBUG */
@@ -299,8 +300,9 @@ int ieee80211_tkip_decrypt_data(struct crypto_blkcipher *tfm,
 #ifdef CONFIG_TKIP_DEBUG
                 {
                         int i;
-                        printk(KERN_DEBUG "TKIP decrypt: Phase1 TA=" MAC_FMT
-                               " TK=", MAC_ARG(ta));
+                        DECLARE_MAC_BUF(mac);
+                        printk(KERN_DEBUG "TKIP decrypt: Phase1 TA=%s"
+                               " TK=", print_mac(mac, ta));
                         for (i = 0; i < 16; i++)
                                 printk("%02x ",
                                        key->conf.key[
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index ca262a99e56f..04b4fa9c69ea 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -54,6 +54,7 @@ static void ieee80211_dump_frame(const char *ifname, const char *title,
         const struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
         u16 fc;
         int hdrlen;
+        DECLARE_MAC_BUF(mac);
 
         printk(KERN_DEBUG "%s: %s (len=%d)", ifname, title, skb->len);
         if (skb->len < 4) {
@@ -69,13 +70,13 @@ static void ieee80211_dump_frame(const char *ifname, const char *title,
                 printk(" FC=0x%04x DUR=0x%04x",
                        fc, le16_to_cpu(hdr->duration_id));
         if (hdrlen >= 10)
-                printk(" A1=" MAC_FMT, MAC_ARG(hdr->addr1));
+                printk(" A1=%s", print_mac(mac, hdr->addr1));
         if (hdrlen >= 16)
-                printk(" A2=" MAC_FMT, MAC_ARG(hdr->addr2));
+                printk(" A2=%s", print_mac(mac, hdr->addr2));
         if (hdrlen >= 24)
-                printk(" A3=" MAC_FMT, MAC_ARG(hdr->addr3));
+                printk(" A3=%s", print_mac(mac, hdr->addr3));
         if (hdrlen >= 30)
-                printk(" A4=" MAC_FMT, MAC_ARG(hdr->addr4));
+                printk(" A4=%s", print_mac(mac, hdr->addr4));
         printk("\n");
 }
 #else /* CONFIG_MAC80211_LOWTX_FRAME_DUMP */
@@ -236,9 +237,10 @@ ieee80211_tx_h_check_assoc(struct ieee80211_txrx_data *tx)
                              tx->sdata->type != IEEE80211_IF_TYPE_IBSS &&
                              (tx->fc & IEEE80211_FCTL_FTYPE) == IEEE80211_FTYPE_DATA)) {
 #ifdef CONFIG_MAC80211_VERBOSE_DEBUG
+                        DECLARE_MAC_BUF(mac);
                         printk(KERN_DEBUG "%s: dropped data frame to not "
-                               "associated station " MAC_FMT "\n",
-                               tx->dev->name, MAC_ARG(hdr->addr1));
+                               "associated station %s\n",
+                               tx->dev->name, print_mac(mac, hdr->addr1));
 #endif /* CONFIG_MAC80211_VERBOSE_DEBUG */
                         I802_DEBUG_INC(tx->local->tx_handlers_drop_not_assoc);
                         return TXRX_DROP;
@@ -259,9 +261,10 @@ ieee80211_tx_h_check_assoc(struct ieee80211_txrx_data *tx)
         if (unlikely(!tx->u.tx.mgmt_interface && tx->sdata->ieee802_1x &&
                      !(sta_flags & WLAN_STA_AUTHORIZED))) {
 #ifdef CONFIG_MAC80211_VERBOSE_DEBUG
-                printk(KERN_DEBUG "%s: dropped frame to " MAC_FMT
+                DECLARE_MAC_BUF(mac);
+                printk(KERN_DEBUG "%s: dropped frame to %s"
                        " (unauthorized port)\n", tx->dev->name,
-                       MAC_ARG(hdr->addr1));
+                       print_mac(mac, hdr->addr1));
 #endif
                 I802_DEBUG_INC(tx->local->tx_handlers_drop_unauth_port);
                 return TXRX_DROP;
@@ -357,6 +360,7 @@ static inline ieee80211_txrx_result
 ieee80211_tx_h_unicast_ps_buf(struct ieee80211_txrx_data *tx)
 {
         struct sta_info *sta = tx->sta;
+        DECLARE_MAC_BUF(mac);
 
         if (unlikely(!sta ||
                      ((tx->fc & IEEE80211_FCTL_FTYPE) == IEEE80211_FTYPE_MGMT &&
@@ -366,9 +370,9 @@ ieee80211_tx_h_unicast_ps_buf(struct ieee80211_txrx_data *tx)
         if (unlikely((sta->flags & WLAN_STA_PS) && !sta->pspoll)) {
                 struct ieee80211_tx_packet_data *pkt_data;
 #ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
-                printk(KERN_DEBUG "STA " MAC_FMT " aid %d: PS buffer (entries "
+                printk(KERN_DEBUG "STA %s aid %d: PS buffer (entries "
                        "before %d)\n",
-                       MAC_ARG(sta->addr), sta->aid,
+                       print_mac(mac, sta->addr), sta->aid,
                        skb_queue_len(&sta->ps_tx_buf));
 #endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
                 sta->flags |= WLAN_STA_TIM;
@@ -377,9 +381,9 @@ ieee80211_tx_h_unicast_ps_buf(struct ieee80211_txrx_data *tx)
                 if (skb_queue_len(&sta->ps_tx_buf) >= STA_MAX_TX_BUFFER) {
                         struct sk_buff *old = skb_dequeue(&sta->ps_tx_buf);
                         if (net_ratelimit()) {
-                                printk(KERN_DEBUG "%s: STA " MAC_FMT " TX "
+                                printk(KERN_DEBUG "%s: STA %s TX "
                                        "buffer full - dropping oldest frame\n",
-                                       tx->dev->name, MAC_ARG(sta->addr));
+                                       tx->dev->name, print_mac(mac, sta->addr));
                         }
                         dev_kfree_skb(old);
                 } else
@@ -399,9 +403,9 @@ ieee80211_tx_h_unicast_ps_buf(struct ieee80211_txrx_data *tx)
         }
 #ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
         else if (unlikely(sta->flags & WLAN_STA_PS)) {
-                printk(KERN_DEBUG "%s: STA " MAC_FMT " in PS mode, but pspoll "
+                printk(KERN_DEBUG "%s: STA %s in PS mode, but pspoll "
                        "set -> send frame\n", tx->dev->name,
-                       MAC_ARG(sta->addr));
+                       print_mac(mac, sta->addr));
         }
 #endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */
         sta->pspoll = 0;
diff --git a/net/mac80211/wpa.c b/net/mac80211/wpa.c
index 6e12638054aa..360d11e9de15 100644
--- a/net/mac80211/wpa.c
+++ b/net/mac80211/wpa.c
@@ -132,6 +132,7 @@ ieee80211_rx_h_michael_mic_verify(struct ieee80211_txrx_data *rx)
         u8 mic[MICHAEL_MIC_LEN];
         struct sk_buff *skb = rx->skb;
         int authenticator = 1, wpa_test = 0;
+        DECLARE_MAC_BUF(mac);
 
         fc = rx->fc;
 
@@ -164,7 +165,7 @@ ieee80211_rx_h_michael_mic_verify(struct ieee80211_txrx_data *rx)
                         return TXRX_DROP;
 
                 printk(KERN_DEBUG "%s: invalid Michael MIC in data frame from "
-                       MAC_FMT "\n", rx->dev->name, MAC_ARG(sa));
+                       "%s\n", rx->dev->name, print_mac(mac, sa));
 
                 mac80211_ev_michael_mic_failure(rx->dev, rx->key->conf.keyidx,
                                                 (void *) skb->data);
@@ -287,6 +288,7 @@ ieee80211_rx_h_tkip_decrypt(struct ieee80211_txrx_data *rx)
         int hdrlen, res, hwaccel = 0, wpa_test = 0;
         struct ieee80211_key *key = rx->key;
         struct sk_buff *skb = rx->skb;
+        DECLARE_MAC_BUF(mac);
 
         fc = le16_to_cpu(hdr->frame_control);
         hdrlen = ieee80211_get_hdrlen(fc);
@@ -319,8 +321,8 @@ ieee80211_rx_h_tkip_decrypt(struct ieee80211_txrx_data *rx)
                                           hwaccel, rx->u.rx.queue);
         if (res != TKIP_DECRYPT_OK || wpa_test) {
                 printk(KERN_DEBUG "%s: TKIP decrypt failed for RX frame from "
-                       MAC_FMT " (res=%d)\n",
-                       rx->dev->name, MAC_ARG(rx->sta->addr), res);
+                       "%s (res=%d)\n",
+                       rx->dev->name, print_mac(mac, rx->sta->addr), res);
                 return TXRX_DROP;
         }
 
@@ -542,6 +544,7 @@ ieee80211_rx_h_ccmp_decrypt(struct ieee80211_txrx_data *rx)
         struct sk_buff *skb = rx->skb;
         u8 pn[CCMP_PN_LEN];
         int data_len;
+        DECLARE_MAC_BUF(mac);
 
         fc = le16_to_cpu(hdr->frame_control);
         hdrlen = ieee80211_get_hdrlen(fc);
@@ -564,10 +567,11 @@ ieee80211_rx_h_ccmp_decrypt(struct ieee80211_txrx_data *rx)
         if (memcmp(pn, key->u.ccmp.rx_pn[rx->u.rx.queue], CCMP_PN_LEN) <= 0) {
 #ifdef CONFIG_MAC80211_DEBUG
                 u8 *ppn = key->u.ccmp.rx_pn[rx->u.rx.queue];
+
                 printk(KERN_DEBUG "%s: CCMP replay detected for RX frame from "
-                       MAC_FMT " (RX PN %02x%02x%02x%02x%02x%02x <= prev. PN "
+                       "%s (RX PN %02x%02x%02x%02x%02x%02x <= prev. PN "
                        "%02x%02x%02x%02x%02x%02x)\n", rx->dev->name,
-                       MAC_ARG(rx->sta->addr),
+                       print_mac(mac, rx->sta->addr),
                        pn[0], pn[1], pn[2], pn[3], pn[4], pn[5],
                        ppn[0], ppn[1], ppn[2], ppn[3], ppn[4], ppn[5]);
 #endif /* CONFIG_MAC80211_DEBUG */
@@ -591,8 +595,8 @@ ieee80211_rx_h_ccmp_decrypt(struct ieee80211_txrx_data *rx)
                             skb->data + skb->len - CCMP_MIC_LEN,
                             skb->data + hdrlen + CCMP_HDR_LEN)) {
                         printk(KERN_DEBUG "%s: CCMP decrypt failed for RX "
-                               "frame from " MAC_FMT "\n", rx->dev->name,
-                               MAC_ARG(rx->sta->addr));
+                               "frame from %s\n", rx->dev->name,
+                               print_mac(mac, rx->sta->addr));
                         return TXRX_DROP;
                 }
         }
@@ -606,4 +610,3 @@ ieee80211_rx_h_ccmp_decrypt(struct ieee80211_txrx_data *rx)
 
         return TXRX_CONTINUE;
 }
-