aboutsummaryrefslogtreecommitdiffstats
path: root/net/mac80211
diff options
context:
space:
mode:
authorJohannes Berg <johannes@sipsolutions.net>2007-08-28 17:01:55 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-10-10 19:48:56 -0400
commit8dc06a1c6112fef7616d26e0b001455b5d8c3c5e (patch)
treee7e37614847c2e7b26834a0a97bfddbac38661e0 /net/mac80211
parentb331615722779b078822988843ddffd4eaec9f83 (diff)
[MAC80211]: improve key selection comment
When I changed the code there I forgot to mention what happens with multicast frames in a regular BSS and keep wondering myself if the code is correct. Add appropriate comments. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Acked-by: Michael Wu <flamingice@sourmilk.net> Signed-off-by: John W. Linville <linville@tuxdriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/mac80211')
-rw-r--r--net/mac80211/rx.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 969be3adda7a..75a1e204b9b6 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -327,8 +327,15 @@ ieee80211_rx_h_load_key(struct ieee80211_txrx_data *rx)
327 * frames can also use key indizes like GTKs. Hence, if we don't 327 * frames can also use key indizes like GTKs. Hence, if we don't
328 * have a PTK/STK we check the key index for a WEP key. 328 * have a PTK/STK we check the key index for a WEP key.
329 * 329 *
330 * Note that in a regular BSS, multicast frames are sent by the
331 * AP only, associated stations unicast the frame to the AP first
332 * which then multicasts it on their behalf.
333 *
330 * There is also a slight problem in IBSS mode: GTKs are negotiated 334 * There is also a slight problem in IBSS mode: GTKs are negotiated
331 * with each station, that is something we don't currently handle. 335 * with each station, that is something we don't currently handle.
336 * The spec seems to expect that one negotiates the same key with
337 * every station but there's no such requirement; VLANs could be
338 * possible.
332 */ 339 */
333 340
334 if (!(rx->fc & IEEE80211_FCTL_PROTECTED)) 341 if (!(rx->fc & IEEE80211_FCTL_PROTECTED))