diff options
author | Arnd Bergmann <arnd@arndb.de> | 2010-07-06 13:05:31 -0400 |
---|---|---|
committer | Arnd Bergmann <arnd@arndb.de> | 2010-09-16 04:33:08 -0400 |
commit | 2b18ab36cf7e956fb5b5ee12847e94fc66d496f4 (patch) | |
tree | 3abdb07b9caa17e902f43cec478a42e8d9ab4990 /net/mac80211 | |
parent | dc880abef75e7c62c9048171f5112500f36a9244 (diff) |
net/wireless: use generic_file_llseek in debugfs
The default llseek operation is changing from
default_llseek to no_llseek, so all code relying on
the current behaviour needs to make that explicit.
The wireless driver infrastructure and some of the drivers
make use of generated debugfs files, so they cannot
be converted by our script that automatically determines
the right operation.
All these files use debugfs and they typically rely
on simple_read_from_buffer, so the best llseek operation
here is generic_file_llseek.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Diffstat (limited to 'net/mac80211')
-rw-r--r-- | net/mac80211/debugfs.c | 2 | ||||
-rw-r--r-- | net/mac80211/debugfs_key.c | 2 | ||||
-rw-r--r-- | net/mac80211/debugfs_netdev.c | 1 | ||||
-rw-r--r-- | net/mac80211/debugfs_sta.c | 2 |
4 files changed, 7 insertions, 0 deletions
diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c index a694c593ff6a..4a4d35c750c6 100644 --- a/net/mac80211/debugfs.c +++ b/net/mac80211/debugfs.c | |||
@@ -36,6 +36,7 @@ static ssize_t name## _read(struct file *file, char __user *userbuf, \ | |||
36 | static const struct file_operations name## _ops = { \ | 36 | static const struct file_operations name## _ops = { \ |
37 | .read = name## _read, \ | 37 | .read = name## _read, \ |
38 | .open = mac80211_open_file_generic, \ | 38 | .open = mac80211_open_file_generic, \ |
39 | .llseek = generic_file_llseek, \ | ||
39 | }; | 40 | }; |
40 | 41 | ||
41 | #define DEBUGFS_ADD(name) \ | 42 | #define DEBUGFS_ADD(name) \ |
@@ -346,6 +347,7 @@ static ssize_t stats_ ##name## _read(struct file *file, \ | |||
346 | static const struct file_operations stats_ ##name## _ops = { \ | 347 | static const struct file_operations stats_ ##name## _ops = { \ |
347 | .read = stats_ ##name## _read, \ | 348 | .read = stats_ ##name## _read, \ |
348 | .open = mac80211_open_file_generic, \ | 349 | .open = mac80211_open_file_generic, \ |
350 | .llseek = generic_file_llseek, \ | ||
349 | }; | 351 | }; |
350 | 352 | ||
351 | #define DEBUGFS_STATS_ADD(name, field) \ | 353 | #define DEBUGFS_STATS_ADD(name, field) \ |
diff --git a/net/mac80211/debugfs_key.c b/net/mac80211/debugfs_key.c index fa5e76e658ef..7cd8dd9fc240 100644 --- a/net/mac80211/debugfs_key.c +++ b/net/mac80211/debugfs_key.c | |||
@@ -32,6 +32,7 @@ static ssize_t key_##name##_read(struct file *file, \ | |||
32 | static const struct file_operations key_ ##name## _ops = { \ | 32 | static const struct file_operations key_ ##name## _ops = { \ |
33 | .read = key_##name##_read, \ | 33 | .read = key_##name##_read, \ |
34 | .open = mac80211_open_file_generic, \ | 34 | .open = mac80211_open_file_generic, \ |
35 | .llseek = generic_file_llseek, \ | ||
35 | } | 36 | } |
36 | 37 | ||
37 | #define KEY_FILE(name, format) \ | 38 | #define KEY_FILE(name, format) \ |
@@ -46,6 +47,7 @@ static const struct file_operations key_ ##name## _ops = { \ | |||
46 | static const struct file_operations key_ ##name## _ops = { \ | 47 | static const struct file_operations key_ ##name## _ops = { \ |
47 | .read = key_conf_##name##_read, \ | 48 | .read = key_conf_##name##_read, \ |
48 | .open = mac80211_open_file_generic, \ | 49 | .open = mac80211_open_file_generic, \ |
50 | .llseek = generic_file_llseek, \ | ||
49 | } | 51 | } |
50 | 52 | ||
51 | #define KEY_CONF_FILE(name, format) \ | 53 | #define KEY_CONF_FILE(name, format) \ |
diff --git a/net/mac80211/debugfs_netdev.c b/net/mac80211/debugfs_netdev.c index 20b2998fa0ed..8ad33eef7dda 100644 --- a/net/mac80211/debugfs_netdev.c +++ b/net/mac80211/debugfs_netdev.c | |||
@@ -121,6 +121,7 @@ static const struct file_operations name##_ops = { \ | |||
121 | .read = ieee80211_if_read_##name, \ | 121 | .read = ieee80211_if_read_##name, \ |
122 | .write = (_write), \ | 122 | .write = (_write), \ |
123 | .open = mac80211_open_file_generic, \ | 123 | .open = mac80211_open_file_generic, \ |
124 | .llseek = generic_file_llseek, \ | ||
124 | } | 125 | } |
125 | 126 | ||
126 | #define __IEEE80211_IF_FILE_W(name) \ | 127 | #define __IEEE80211_IF_FILE_W(name) \ |
diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c index 76839d4dfaac..6a8fdc372c43 100644 --- a/net/mac80211/debugfs_sta.c +++ b/net/mac80211/debugfs_sta.c | |||
@@ -36,6 +36,7 @@ static ssize_t sta_ ##name## _read(struct file *file, \ | |||
36 | static const struct file_operations sta_ ##name## _ops = { \ | 36 | static const struct file_operations sta_ ##name## _ops = { \ |
37 | .read = sta_##name##_read, \ | 37 | .read = sta_##name##_read, \ |
38 | .open = mac80211_open_file_generic, \ | 38 | .open = mac80211_open_file_generic, \ |
39 | .llseek = generic_file_llseek, \ | ||
39 | } | 40 | } |
40 | 41 | ||
41 | #define STA_OPS_RW(name) \ | 42 | #define STA_OPS_RW(name) \ |
@@ -43,6 +44,7 @@ static const struct file_operations sta_ ##name## _ops = { \ | |||
43 | .read = sta_##name##_read, \ | 44 | .read = sta_##name##_read, \ |
44 | .write = sta_##name##_write, \ | 45 | .write = sta_##name##_write, \ |
45 | .open = mac80211_open_file_generic, \ | 46 | .open = mac80211_open_file_generic, \ |
47 | .llseek = generic_file_llseek, \ | ||
46 | } | 48 | } |
47 | 49 | ||
48 | #define STA_FILE(name, field, format) \ | 50 | #define STA_FILE(name, field, format) \ |