diff options
author | Johannes Berg <johannes@sipsolutions.net> | 2008-09-10 18:01:56 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2008-09-15 16:48:22 -0400 |
commit | ccd7b36286f8c42b3fa95c5a8d402162ffab41df (patch) | |
tree | c5eb18d98de275c64b45e96ce771c54158524fea /net/mac80211/tx.c | |
parent | c2b13452b283f9c4a5b02a6b53ed6416ebf4c03c (diff) |
mac80211: clean up some comments
Some comments refer to 80211.o or similar; also remove
a comment about implementing fragments better, we really
have better things to do.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/tx.c')
-rw-r--r-- | net/mac80211/tx.c | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index e606ba08ddd4..1bed3be01c26 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c | |||
@@ -111,7 +111,7 @@ static __le16 ieee80211_duration(struct ieee80211_tx_data *tx, int group_addr, | |||
111 | hdr = (struct ieee80211_hdr *)tx->skb->data; | 111 | hdr = (struct ieee80211_hdr *)tx->skb->data; |
112 | if (ieee80211_is_ctl(hdr->frame_control)) { | 112 | if (ieee80211_is_ctl(hdr->frame_control)) { |
113 | /* TODO: These control frames are not currently sent by | 113 | /* TODO: These control frames are not currently sent by |
114 | * 80211.o, but should they be implemented, this function | 114 | * mac80211, but should they be implemented, this function |
115 | * needs to be updated to support duration field calculation. | 115 | * needs to be updated to support duration field calculation. |
116 | * | 116 | * |
117 | * RTS: time needed to transmit pending data/mgmt frame plus | 117 | * RTS: time needed to transmit pending data/mgmt frame plus |
@@ -1580,19 +1580,6 @@ int ieee80211_subif_start_xmit(struct sk_buff *skb, | |||
1580 | nh_pos -= skip_header_bytes; | 1580 | nh_pos -= skip_header_bytes; |
1581 | h_pos -= skip_header_bytes; | 1581 | h_pos -= skip_header_bytes; |
1582 | 1582 | ||
1583 | /* TODO: implement support for fragments so that there is no need to | ||
1584 | * reallocate and copy payload; it might be enough to support one | ||
1585 | * extra fragment that would be copied in the beginning of the frame | ||
1586 | * data.. anyway, it would be nice to include this into skb structure | ||
1587 | * somehow | ||
1588 | * | ||
1589 | * There are few options for this: | ||
1590 | * use skb->cb as an extra space for 802.11 header | ||
1591 | * allocate new buffer if not enough headroom | ||
1592 | * make sure that there is enough headroom in every skb by increasing | ||
1593 | * build in headroom in __dev_alloc_skb() (linux/skbuff.h) and | ||
1594 | * alloc_skb() (net/core/skbuff.c) | ||
1595 | */ | ||
1596 | head_need = hdrlen + encaps_len + meshhdrlen - skb_headroom(skb); | 1583 | head_need = hdrlen + encaps_len + meshhdrlen - skb_headroom(skb); |
1597 | 1584 | ||
1598 | /* | 1585 | /* |