diff options
author | Johannes Berg <johannes@sipsolutions.net> | 2008-10-07 06:04:34 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2008-10-31 18:06:00 -0400 |
commit | d73782fdde76554016abf73b46f843b29f520848 (patch) | |
tree | 9b57321ce60ba336dfea63501b1d23d21c700817 /net/mac80211/scan.c | |
parent | 3db594380b8452eda4d88b12844077809607caaa (diff) |
mac80211: clean up ieee80211_hw_config errors
Warn when ieee80211_hw_config returns an error, it shouldn't
happen; remove a number of printks that would happen in such
a case and one printk that is user-triggerable.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/scan.c')
-rw-r--r-- | net/mac80211/scan.c | 16 |
1 files changed, 3 insertions, 13 deletions
diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c index 416bb41099f3..0989b1c062e3 100644 --- a/net/mac80211/scan.c +++ b/net/mac80211/scan.c | |||
@@ -448,18 +448,12 @@ void ieee80211_scan_completed(struct ieee80211_hw *hw) | |||
448 | 448 | ||
449 | if (local->hw_scanning) { | 449 | if (local->hw_scanning) { |
450 | local->hw_scanning = false; | 450 | local->hw_scanning = false; |
451 | if (ieee80211_hw_config(local)) | 451 | ieee80211_hw_config(local); |
452 | printk(KERN_DEBUG "%s: failed to restore operational " | ||
453 | "channel after scan\n", wiphy_name(local->hw.wiphy)); | ||
454 | |||
455 | goto done; | 452 | goto done; |
456 | } | 453 | } |
457 | 454 | ||
458 | local->sw_scanning = false; | 455 | local->sw_scanning = false; |
459 | if (ieee80211_hw_config(local)) | 456 | ieee80211_hw_config(local); |
460 | printk(KERN_DEBUG "%s: failed to restore operational " | ||
461 | "channel after scan\n", wiphy_name(local->hw.wiphy)); | ||
462 | |||
463 | 457 | ||
464 | netif_tx_lock_bh(local->mdev); | 458 | netif_tx_lock_bh(local->mdev); |
465 | netif_addr_lock(local->mdev); | 459 | netif_addr_lock(local->mdev); |
@@ -546,12 +540,8 @@ void ieee80211_scan_work(struct work_struct *work) | |||
546 | 540 | ||
547 | if (!skip) { | 541 | if (!skip) { |
548 | local->scan_channel = chan; | 542 | local->scan_channel = chan; |
549 | if (ieee80211_hw_config(local)) { | 543 | if (ieee80211_hw_config(local)) |
550 | printk(KERN_DEBUG "%s: failed to set freq to " | ||
551 | "%d MHz for scan\n", wiphy_name(local->hw.wiphy), | ||
552 | chan->center_freq); | ||
553 | skip = 1; | 544 | skip = 1; |
554 | } | ||
555 | } | 545 | } |
556 | 546 | ||
557 | /* advance state machine to next channel/band */ | 547 | /* advance state machine to next channel/band */ |