diff options
author | Johannes Berg <johannes@sipsolutions.net> | 2007-09-26 09:19:43 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 19:53:15 -0400 |
commit | fb1c1cd6c5a8988b14c5c6c0dfe55542df3a34c6 (patch) | |
tree | 9dec818b2b6aea9c9823902e9c5b0108134d5747 /net/mac80211/rx.c | |
parent | af1a90da397f071d7ee893145a1e7b2124689376 (diff) |
[PATCH] mac80211: fix vlan bug
VLAN interfaces have yet another bug: they aren't accounted
for properly in the receive path in prepare_for_handlers().
I noticed this by code inspection, but it would be easy for
the compiler to catch such things if we'd just use the proper
enum where appropriate.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/rx.c')
-rw-r--r-- | net/mac80211/rx.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 453ccab060a2..34adc5288fbc 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c | |||
@@ -1425,6 +1425,7 @@ static int prepare_for_handlers(struct ieee80211_sub_if_data *sdata, | |||
1425 | rx->sta = ieee80211_ibss_add_sta(sdata->dev, rx->skb, | 1425 | rx->sta = ieee80211_ibss_add_sta(sdata->dev, rx->skb, |
1426 | bssid, hdr->addr2); | 1426 | bssid, hdr->addr2); |
1427 | break; | 1427 | break; |
1428 | case IEEE80211_IF_TYPE_VLAN: | ||
1428 | case IEEE80211_IF_TYPE_AP: | 1429 | case IEEE80211_IF_TYPE_AP: |
1429 | if (!bssid) { | 1430 | if (!bssid) { |
1430 | if (compare_ether_addr(sdata->dev->dev_addr, | 1431 | if (compare_ether_addr(sdata->dev->dev_addr, |
@@ -1449,6 +1450,13 @@ static int prepare_for_handlers(struct ieee80211_sub_if_data *sdata, | |||
1449 | if (compare_ether_addr(sdata->u.wds.remote_addr, hdr->addr2)) | 1450 | if (compare_ether_addr(sdata->u.wds.remote_addr, hdr->addr2)) |
1450 | return 0; | 1451 | return 0; |
1451 | break; | 1452 | break; |
1453 | case IEEE80211_IF_TYPE_MNTR: | ||
1454 | /* take everything */ | ||
1455 | break; | ||
1456 | case IEEE80211_IF_TYPE_MGMT: | ||
1457 | /* should never get here */ | ||
1458 | WARN_ON(1); | ||
1459 | break; | ||
1452 | } | 1460 | } |
1453 | 1461 | ||
1454 | return 1; | 1462 | return 1; |