aboutsummaryrefslogtreecommitdiffstats
path: root/net/mac80211/mlme.c
diff options
context:
space:
mode:
authorIvo van Doorn <ivdoorn@gmail.com>2008-07-01 04:45:13 -0400
committerJohn W. Linville <linville@tuxdriver.com>2008-07-08 10:21:34 -0400
commitb2898a27809f54a33050a70d0eaa4a78194163a0 (patch)
treee0adf0193c7c3cfd9b2165cbbd18ff14b352927f /net/mac80211/mlme.c
parent8fa7425c6394117a541de82826d128d6c3d9161b (diff)
mac80211: Don't request encryption for probe response
Probe responses shouldn't be encrypted, and mac80211 doesn't set the crypto key accordingly. However it didn't set the IEEE80211_TX_CTL_DO_NOT_ENCRYPT flag which means drivers could make an attempt to encrypt it, and causing a NULL pointer dereference when accessing the provided hw_key field. Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com> Acked-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/mlme.c')
-rw-r--r--net/mac80211/mlme.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 4a3bddd206d8..86abdf96390c 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -2481,6 +2481,7 @@ static int ieee80211_sta_join_ibss(struct net_device *dev,
2481 control->flags |= IEEE80211_TX_CTL_SHORT_PREAMBLE; 2481 control->flags |= IEEE80211_TX_CTL_SHORT_PREAMBLE;
2482 control->antenna_sel_tx = local->hw.conf.antenna_sel_tx; 2482 control->antenna_sel_tx = local->hw.conf.antenna_sel_tx;
2483 control->flags |= IEEE80211_TX_CTL_NO_ACK; 2483 control->flags |= IEEE80211_TX_CTL_NO_ACK;
2484 control->flags |= IEEE80211_TX_CTL_DO_NOT_ENCRYPT;
2484 control->control.retry_limit = 1; 2485 control->control.retry_limit = 1;
2485 2486
2486 ifsta->probe_resp = skb_copy(skb, GFP_ATOMIC); 2487 ifsta->probe_resp = skb_copy(skb, GFP_ATOMIC);