[MAC80211]: embed key conf in key, fix driver interface

This patch embeds the struct ieee80211_key_conf into struct ieee80211_key
and thus avoids allocations and having data present twice.

This required some more changes:
 1) The removal of the IEEE80211_KEY_DEFAULT_TX_KEY key flag.
    This flag isn't used by drivers nor should it be since
    we have a set_key_idx() callback. Maybe that callback needs
    to be extended to include the key conf, but only a driver that
    requires it will tell.
 2) The removal of the IEEE80211_KEY_DEFAULT_WEP_ONLY key flag.
    This flag is global, so it shouldn't be passed in the key
    conf structure. Pass it to the function instead.

Also, this patch removes the AID parameter to the set_key() callback
because it is currently unused and the hardware currently cannot know
about the AID anyway. I suspect this was used with some hardware that
actually selected the AID itself, but that functionality was removed.

Additionally, I've removed the ALG_NULL key algorithm since we have
ALG_NONE.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 8 insertions, 12 deletions

diff --git a/net/mac80211/ieee80211_key.h b/net/mac80211/ieee80211_key.h
index c33384912782..1b5e539c678f 100644
--- a/net/mac80211/ieee80211_key.h
+++ b/net/mac80211/ieee80211_key.h
@@ -44,8 +44,6 @@
 struct ieee80211_key {
         struct kref kref;
 
-        int hw_key_idx; /* filled and used by low-level driver */
-        ieee80211_key_alg alg;
         union {
                 struct {
                         /* last used TSC */
@@ -73,22 +71,16 @@ struct ieee80211_key {
                         u8 rx_crypto_buf[6 * AES_BLOCK_LEN];
                 } ccmp;
         } u;
-        int tx_rx_count; /* number of times this key has been used */
-        int keylen;
 
-        /* if the low level driver can provide hardware acceleration it should
-         * clear this flag */
-        unsigned int force_sw_encrypt:1;
-        unsigned int default_tx_key:1; /* This key is the new default TX key
-                                        * (used only for broadcast keys). */
-        s8 keyidx; /* WEP key index */
+        /* number of times this key has been used */
+        int tx_rx_count;
 
 #ifdef CONFIG_MAC80211_DEBUGFS
         struct {
                 struct dentry *stalink;
                 struct dentry *dir;
                 struct dentry *keylen;
-                struct dentry *force_sw_encrypt;
+                struct dentry *flags;
                 struct dentry *keyidx;
                 struct dentry *hw_key_idx;
                 struct dentry *tx_rx_count;
@@ -100,7 +92,11 @@ struct ieee80211_key {
         } debugfs;
 #endif
 
-        u8 key[0];
+        /*
+         * key config, must be last because it contains key
+         * material as variable length member
+         */
+        struct ieee80211_key_conf conf;
 };
 
 #endif /* IEEE80211_KEY_H */