diff options
author | Johannes Berg <johannes@sipsolutions.net> | 2009-04-23 12:52:52 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-05-06 15:14:37 -0400 |
commit | 2448798133d747ad339e57099e32a1d1e68aca1c (patch) | |
tree | ee09385f5dca9e243c38f5f888baa02605423bd7 /net/mac80211/cfg.c | |
parent | 2d0ddec5b2b859f06116f631fc0ffe94fbceb556 (diff) |
mac80211: add driver ops wrappers
In order to later add tracing or verifications to the driver
calls mac80211 makes, this patch adds static inline wrappers
for all operations.
All calls are now written as
drv_<op>(local, ...);
instead of
local->ops-><op>(&local->hw, ...);
Where necessary, the wrappers also do existence checking and
return default values as appropriate.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/cfg.c')
-rw-r--r-- | net/mac80211/cfg.c | 24 |
1 files changed, 10 insertions, 14 deletions
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index 648bac1c850e..d0ca6da33ca9 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c | |||
@@ -13,6 +13,7 @@ | |||
13 | #include <linux/rcupdate.h> | 13 | #include <linux/rcupdate.h> |
14 | #include <net/cfg80211.h> | 14 | #include <net/cfg80211.h> |
15 | #include "ieee80211_i.h" | 15 | #include "ieee80211_i.h" |
16 | #include "driver-ops.h" | ||
16 | #include "cfg.h" | 17 | #include "cfg.h" |
17 | #include "rate.h" | 18 | #include "rate.h" |
18 | #include "mesh.h" | 19 | #include "mesh.h" |
@@ -245,12 +246,10 @@ static int ieee80211_get_key(struct wiphy *wiphy, struct net_device *dev, | |||
245 | iv32 = key->u.tkip.tx.iv32; | 246 | iv32 = key->u.tkip.tx.iv32; |
246 | iv16 = key->u.tkip.tx.iv16; | 247 | iv16 = key->u.tkip.tx.iv16; |
247 | 248 | ||
248 | if (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE && | 249 | if (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) |
249 | sdata->local->ops->get_tkip_seq) | 250 | drv_get_tkip_seq(sdata->local, |
250 | sdata->local->ops->get_tkip_seq( | 251 | key->conf.hw_key_idx, |
251 | local_to_hw(sdata->local), | 252 | &iv32, &iv16); |
252 | key->conf.hw_key_idx, | ||
253 | &iv32, &iv16); | ||
254 | 253 | ||
255 | seq[0] = iv16 & 0xff; | 254 | seq[0] = iv16 & 0xff; |
256 | seq[1] = (iv16 >> 8) & 0xff; | 255 | seq[1] = (iv16 >> 8) & 0xff; |
@@ -1115,7 +1114,7 @@ static int ieee80211_set_txq_params(struct wiphy *wiphy, | |||
1115 | p.cw_max = params->cwmax; | 1114 | p.cw_max = params->cwmax; |
1116 | p.cw_min = params->cwmin; | 1115 | p.cw_min = params->cwmin; |
1117 | p.txop = params->txop; | 1116 | p.txop = params->txop; |
1118 | if (local->ops->conf_tx(local_to_hw(local), params->queue, &p)) { | 1117 | if (drv_conf_tx(local, params->queue, &p)) { |
1119 | printk(KERN_DEBUG "%s: failed to set TX queue " | 1118 | printk(KERN_DEBUG "%s: failed to set TX queue " |
1120 | "parameters for queue %d\n", local->mdev->name, | 1119 | "parameters for queue %d\n", local->mdev->name, |
1121 | params->queue); | 1120 | params->queue); |
@@ -1296,16 +1295,13 @@ static int ieee80211_leave_ibss(struct wiphy *wiphy, struct net_device *dev) | |||
1296 | static int ieee80211_set_wiphy_params(struct wiphy *wiphy, u32 changed) | 1295 | static int ieee80211_set_wiphy_params(struct wiphy *wiphy, u32 changed) |
1297 | { | 1296 | { |
1298 | struct ieee80211_local *local = wiphy_priv(wiphy); | 1297 | struct ieee80211_local *local = wiphy_priv(wiphy); |
1298 | int err; | ||
1299 | 1299 | ||
1300 | if (changed & WIPHY_PARAM_RTS_THRESHOLD) { | 1300 | if (changed & WIPHY_PARAM_RTS_THRESHOLD) { |
1301 | int err; | 1301 | err = drv_set_rts_threshold(local, wiphy->rts_threshold); |
1302 | 1302 | ||
1303 | if (local->ops->set_rts_threshold) { | 1303 | if (err) |
1304 | err = local->ops->set_rts_threshold( | 1304 | return err; |
1305 | local_to_hw(local), wiphy->rts_threshold); | ||
1306 | if (err) | ||
1307 | return err; | ||
1308 | } | ||
1309 | } | 1305 | } |
1310 | 1306 | ||
1311 | if (changed & WIPHY_PARAM_RETRY_SHORT) | 1307 | if (changed & WIPHY_PARAM_RETRY_SHORT) |