mac80211: rework debug settings and make debugging safer

This patch reworks the mac80211 debug settings making them more focused
and adding help text for those that didn't have one. It also removes a
number of printks that can be triggered remotely and add no value, e.g.
"too short deauthentication frame received - ignoring".

If somebody really needs to debug that they should just add a monitor
interface and look at the frames in wireshark.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

1 files changed, 91 insertions, 39 deletions

diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 661d3c291482..11a1e7fa195d 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -88,10 +88,16 @@ config MAC80211_DEBUGFS
 
           Say N unless you know you need this.
 
+menuconfig MAC80211_DEBUG_MENU
+        bool "Select mac80211 debugging features"
+        depends on MAC80211
+        ---help---
+          This option collects various mac80211 debug settings.
+
 config MAC80211_DEBUG_PACKET_ALIGNMENT
         bool "Enable packet alignment debugging"
-        depends on MAC80211
-        help
+        depends on MAC80211_DEBUG_MENU
+        ---help---
           This option is recommended for driver authors and strongly
           discouraged for everybody else, it will trigger a warning
           when a driver hands mac80211 a buffer that is aligned in
@@ -100,33 +106,95 @@ config MAC80211_DEBUG_PACKET_ALIGNMENT
 
           Say N unless you're writing a mac80211 based driver.
 
-config MAC80211_DEBUG
-        bool "Enable debugging output"
-        depends on MAC80211
+config MAC80211_NOINLINE
+        bool "Do not inline TX/RX handlers"
+        depends on MAC80211_DEBUG_MENU
         ---help---
-          This option will enable debug tracing output for the
-          ieee80211 network stack.
+          This option affects code generation in mac80211, when
+          selected some functions are marked "noinline" to allow
+          easier debugging of problems in the transmit and receive
+          paths.
+
+          This option increases code size a bit and inserts a lot
+          of function calls in the code, but is otherwise safe to
+          enable.
 
-          If you are not trying to debug or develop the ieee80211
-          subsystem, you most likely want to say N here.
+          If unsure, say N unless you expect to be finding problems
+          in mac80211.
+
+config MAC80211_VERBOSE_DEBUG
+        bool "Verbose debugging output"
+        depends on MAC80211_DEBUG_MENU
+        ---help---
+          Selecting this option causes mac80211 to print out
+          many debugging messages. It should not be selected
+          on production systems as some of the messages are
+          remotely triggerable.
+
+          Do not select this option.
 
 config MAC80211_HT_DEBUG
-        bool "Enable HT debugging output"
-        depends on MAC80211_DEBUG
+        bool "Verbose HT debugging"
+        depends on MAC80211_DEBUG_MENU
         ---help---
           This option enables 802.11n High Throughput features
           debug tracing output.
 
-          If you are not trying to debug of develop the ieee80211
-          subsystem, you most likely want to say N here.
+          It should not be selected on production systems as some
+          of the messages are remotely triggerable.
 
-config MAC80211_VERBOSE_DEBUG
-        bool "Verbose debugging output"
-        depends on MAC80211_DEBUG
+          Do not select this option.
+
+config MAC80211_TKIP_DEBUG
+        bool "Verbose TKIP debugging"
+        depends on MAC80211_DEBUG_MENU
+        ---help---
+          Selecting this option causes mac80211 to print out
+          very verbose TKIP debugging messages. It should not
+          be selected on production systems as those messages
+          are remotely triggerable.
+
+          Do not select this option.
+
+config MAC80211_IBSS_DEBUG
+        bool "Verbose IBSS debugging"
+        depends on MAC80211_DEBUG_MENU
+        ---help---
+          Selecting this option causes mac80211 to print out
+          very verbose IBSS debugging messages. It should not
+          be selected on production systems as those messages
+          are remotely triggerable.
+
+          Do not select this option.
+
+config MAC80211_VERBOSE_PS_DEBUG
+        bool "Verbose powersave mode debugging"
+        depends on MAC80211_DEBUG_MENU
+        ---help---
+          Selecting this option causes mac80211 to print out very
+          verbose power save mode debugging messages (when mac80211
+          is an AP and has power saving stations.)
+          It should not be selected on production systems as those
+          messages are remotely triggerable.
+
+          Do not select this option.
+
+config MAC80211_VERBOSE_MPL_DEBUG
+        bool "Verbose mesh peer link debugging"
+        depends on MAC80211_DEBUG_MENU
+        depends on MAC80211_MESH
+        ---help---
+          Selecting this option causes mac80211 to print out very
+          verbose mesh peer link debugging messages (when mac80211
+          is taking part in a mesh network).
+          It should not be selected on production systems as those
+          messages are remotely triggerable.
+
+          Do not select this option.
 
 config MAC80211_LOWTX_FRAME_DUMP
         bool "Debug frame dumping"
-        depends on MAC80211_DEBUG
+        depends on MAC80211_DEBUG_MENU
         ---help---
           Selecting this option will cause the stack to
           print a message for each frame that is handed
@@ -137,33 +205,17 @@ config MAC80211_LOWTX_FRAME_DUMP
           If unsure, say N and insert the debugging code
           you require into the driver you are debugging.
 
-config MAC80211_TKIP_DEBUG
-        bool "TKIP debugging"
-        depends on MAC80211_DEBUG
-
 config MAC80211_DEBUG_COUNTERS
         bool "Extra statistics for TX/RX debugging"
         depends on MAC80211_DEBUG
-
-config MAC80211_IBSS_DEBUG
-        bool "Support for IBSS testing"
-        depends on MAC80211_DEBUG
-        ---help---
-          Say Y here if you intend to debug the IBSS code.
-
-config MAC80211_VERBOSE_PS_DEBUG
-        bool "Verbose powersave mode debugging"
-        depends on MAC80211_DEBUG
+        depends on MAC80211_DEBUG_MENU
+        depends on MAC80211_DEBUGFS
         ---help---
-          Say Y here to print out verbose powersave
-          mode debug messages.
+          Selecting this option causes mac80211 to keep additional
+          and very verbose statistics about TX and RX handler use
+          and show them in debugfs.
 
-config MAC80211_VERBOSE_MPL_DEBUG
-        bool "Verbose mesh peer link debugging"
-        depends on MAC80211_DEBUG && MAC80211_MESH
-        ---help---
-          Say Y here to print out verbose mesh peer link
-          debug messages.
+          If unsure, say N.
 
 config MAC80211_VERBOSE_SPECT_MGMT_DEBUG
         bool "Verbose Spectrum Management (IEEE 802.11h)debugging"