diff options
author | Pavel Emelyanov <xemul@openvz.org> | 2008-01-24 00:20:07 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 17:53:35 -0500 |
commit | b24b8a247ff65c01b252025926fe564209fae4fc (patch) | |
tree | 8a9e0ea1e24b4733d8b9433d41877659505e9da4 /net/llc/llc_station.c | |
parent | a92aa318b4b369091fd80433c80e62838db8bc1c (diff) |
[NET]: Convert init_timer into setup_timer
Many-many code in the kernel initialized the timer->function
and timer->data together with calling init_timer(timer). There
is already a helper for this. Use it for networking code.
The patch is HUGE, but makes the code 130 lines shorter
(98 insertions(+), 228 deletions(-)).
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/llc/llc_station.c')
-rw-r--r-- | net/llc/llc_station.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/net/llc/llc_station.c b/net/llc/llc_station.c index 576355a192ab..6f2ea2090322 100644 --- a/net/llc/llc_station.c +++ b/net/llc/llc_station.c | |||
@@ -688,9 +688,8 @@ int __init llc_station_init(void) | |||
688 | skb_queue_head_init(&llc_main_station.mac_pdu_q); | 688 | skb_queue_head_init(&llc_main_station.mac_pdu_q); |
689 | skb_queue_head_init(&llc_main_station.ev_q.list); | 689 | skb_queue_head_init(&llc_main_station.ev_q.list); |
690 | spin_lock_init(&llc_main_station.ev_q.lock); | 690 | spin_lock_init(&llc_main_station.ev_q.lock); |
691 | init_timer(&llc_main_station.ack_timer); | 691 | setup_timer(&llc_main_station.ack_timer, llc_station_ack_tmr_cb, |
692 | llc_main_station.ack_timer.data = (unsigned long)&llc_main_station; | 692 | (unsigned long)&llc_main_station); |
693 | llc_main_station.ack_timer.function = llc_station_ack_tmr_cb; | ||
694 | llc_main_station.ack_timer.expires = jiffies + | 693 | llc_main_station.ack_timer.expires = jiffies + |
695 | sysctl_llc_station_ack_timeout; | 694 | sysctl_llc_station_ack_timeout; |
696 | skb = alloc_skb(0, GFP_ATOMIC); | 695 | skb = alloc_skb(0, GFP_ATOMIC); |