diff options
author | Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> | 2014-04-22 08:48:30 -0400 |
---|---|---|
committer | Steffen Klassert <steffen.klassert@secunet.com> | 2014-04-23 02:21:04 -0400 |
commit | 2e71029e2c32ecd59a2e8f351517bfbbad42ac11 (patch) | |
tree | b149f7d9be228544e36416dece87c2ab6ca28b7b /net/key | |
parent | f1370cc4a01e61007ab3020c761cef6b88ae3729 (diff) |
xfrm: Remove useless xfrm_audit struct.
Commit f1370cc4 "xfrm: Remove useless secid field from xfrm_audit." changed
"struct xfrm_audit" to have either
{ audit_get_loginuid(current) / audit_get_sessionid(current) } or
{ INVALID_UID / -1 } pair.
This means that we can represent "struct xfrm_audit" as "bool".
This patch replaces "struct xfrm_audit" argument with "bool".
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Diffstat (limited to 'net/key')
-rw-r--r-- | net/key/af_key.c | 30 |
1 files changed, 7 insertions, 23 deletions
diff --git a/net/key/af_key.c b/net/key/af_key.c index d66ff72adefb..b47f8e542aae 100644 --- a/net/key/af_key.c +++ b/net/key/af_key.c | |||
@@ -1476,9 +1476,7 @@ static int pfkey_add(struct sock *sk, struct sk_buff *skb, const struct sadb_msg | |||
1476 | else | 1476 | else |
1477 | err = xfrm_state_update(x); | 1477 | err = xfrm_state_update(x); |
1478 | 1478 | ||
1479 | xfrm_audit_state_add(x, err ? 0 : 1, | 1479 | xfrm_audit_state_add(x, err ? 0 : 1, true); |
1480 | audit_get_loginuid(current), | ||
1481 | audit_get_sessionid(current)); | ||
1482 | 1480 | ||
1483 | if (err < 0) { | 1481 | if (err < 0) { |
1484 | x->km.state = XFRM_STATE_DEAD; | 1482 | x->km.state = XFRM_STATE_DEAD; |
@@ -1532,9 +1530,7 @@ static int pfkey_delete(struct sock *sk, struct sk_buff *skb, const struct sadb_ | |||
1532 | c.event = XFRM_MSG_DELSA; | 1530 | c.event = XFRM_MSG_DELSA; |
1533 | km_state_notify(x, &c); | 1531 | km_state_notify(x, &c); |
1534 | out: | 1532 | out: |
1535 | xfrm_audit_state_delete(x, err ? 0 : 1, | 1533 | xfrm_audit_state_delete(x, err ? 0 : 1, true); |
1536 | audit_get_loginuid(current), | ||
1537 | audit_get_sessionid(current)); | ||
1538 | xfrm_state_put(x); | 1534 | xfrm_state_put(x); |
1539 | 1535 | ||
1540 | return err; | 1536 | return err; |
@@ -1726,16 +1722,13 @@ static int pfkey_flush(struct sock *sk, struct sk_buff *skb, const struct sadb_m | |||
1726 | struct net *net = sock_net(sk); | 1722 | struct net *net = sock_net(sk); |
1727 | unsigned int proto; | 1723 | unsigned int proto; |
1728 | struct km_event c; | 1724 | struct km_event c; |
1729 | struct xfrm_audit audit_info; | ||
1730 | int err, err2; | 1725 | int err, err2; |
1731 | 1726 | ||
1732 | proto = pfkey_satype2proto(hdr->sadb_msg_satype); | 1727 | proto = pfkey_satype2proto(hdr->sadb_msg_satype); |
1733 | if (proto == 0) | 1728 | if (proto == 0) |
1734 | return -EINVAL; | 1729 | return -EINVAL; |
1735 | 1730 | ||
1736 | audit_info.loginuid = audit_get_loginuid(current); | 1731 | err = xfrm_state_flush(net, proto, true); |
1737 | audit_info.sessionid = audit_get_sessionid(current); | ||
1738 | err = xfrm_state_flush(net, proto, &audit_info); | ||
1739 | err2 = unicast_flush_resp(sk, hdr); | 1732 | err2 = unicast_flush_resp(sk, hdr); |
1740 | if (err || err2) { | 1733 | if (err || err2) { |
1741 | if (err == -ESRCH) /* empty table - go quietly */ | 1734 | if (err == -ESRCH) /* empty table - go quietly */ |
@@ -2287,9 +2280,7 @@ static int pfkey_spdadd(struct sock *sk, struct sk_buff *skb, const struct sadb_ | |||
2287 | err = xfrm_policy_insert(pol->sadb_x_policy_dir-1, xp, | 2280 | err = xfrm_policy_insert(pol->sadb_x_policy_dir-1, xp, |
2288 | hdr->sadb_msg_type != SADB_X_SPDUPDATE); | 2281 | hdr->sadb_msg_type != SADB_X_SPDUPDATE); |
2289 | 2282 | ||
2290 | xfrm_audit_policy_add(xp, err ? 0 : 1, | 2283 | xfrm_audit_policy_add(xp, err ? 0 : 1, true); |
2291 | audit_get_loginuid(current), | ||
2292 | audit_get_sessionid(current)); | ||
2293 | 2284 | ||
2294 | if (err) | 2285 | if (err) |
2295 | goto out; | 2286 | goto out; |
@@ -2371,9 +2362,7 @@ static int pfkey_spddelete(struct sock *sk, struct sk_buff *skb, const struct sa | |||
2371 | if (xp == NULL) | 2362 | if (xp == NULL) |
2372 | return -ENOENT; | 2363 | return -ENOENT; |
2373 | 2364 | ||
2374 | xfrm_audit_policy_delete(xp, err ? 0 : 1, | 2365 | xfrm_audit_policy_delete(xp, err ? 0 : 1, true); |
2375 | audit_get_loginuid(current), | ||
2376 | audit_get_sessionid(current)); | ||
2377 | 2366 | ||
2378 | if (err) | 2367 | if (err) |
2379 | goto out; | 2368 | goto out; |
@@ -2621,9 +2610,7 @@ static int pfkey_spdget(struct sock *sk, struct sk_buff *skb, const struct sadb_ | |||
2621 | return -ENOENT; | 2610 | return -ENOENT; |
2622 | 2611 | ||
2623 | if (delete) { | 2612 | if (delete) { |
2624 | xfrm_audit_policy_delete(xp, err ? 0 : 1, | 2613 | xfrm_audit_policy_delete(xp, err ? 0 : 1, true); |
2625 | audit_get_loginuid(current), | ||
2626 | audit_get_sessionid(current)); | ||
2627 | 2614 | ||
2628 | if (err) | 2615 | if (err) |
2629 | goto out; | 2616 | goto out; |
@@ -2732,12 +2719,9 @@ static int pfkey_spdflush(struct sock *sk, struct sk_buff *skb, const struct sad | |||
2732 | { | 2719 | { |
2733 | struct net *net = sock_net(sk); | 2720 | struct net *net = sock_net(sk); |
2734 | struct km_event c; | 2721 | struct km_event c; |
2735 | struct xfrm_audit audit_info; | ||
2736 | int err, err2; | 2722 | int err, err2; |
2737 | 2723 | ||
2738 | audit_info.loginuid = audit_get_loginuid(current); | 2724 | err = xfrm_policy_flush(net, XFRM_POLICY_TYPE_MAIN, true); |
2739 | audit_info.sessionid = audit_get_sessionid(current); | ||
2740 | err = xfrm_policy_flush(net, XFRM_POLICY_TYPE_MAIN, &audit_info); | ||
2741 | err2 = unicast_flush_resp(sk, hdr); | 2725 | err2 = unicast_flush_resp(sk, hdr); |
2742 | if (err || err2) { | 2726 | if (err || err2) { |
2743 | if (err == -ESRCH) /* empty table - old silent behavior */ | 2727 | if (err == -ESRCH) /* empty table - old silent behavior */ |