diff options
author | Samuel Ortiz <samuel@sortiz.org> | 2010-10-05 19:03:12 -0400 |
---|---|---|
committer | Samuel Ortiz <sameo@linux.intel.com> | 2010-10-10 20:12:26 -0400 |
commit | 37f9fc452d138dfc4da2ee1ce5ae85094efc3606 (patch) | |
tree | f2c35efb2269f237efe69f6a1ef5986f784465c5 /net/irda | |
parent | efc463eb508798da4243625b08c7396462cabf9f (diff) |
irda: Fix heap memory corruption in iriap.c
While parsing the GetValuebyClass command frame, we could potentially write
passed the skb->data pointer.
Cc: stable@kernel.org
Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Diffstat (limited to 'net/irda')
-rw-r--r-- | net/irda/iriap.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/irda/iriap.c b/net/irda/iriap.c index fce364c6c71a..5b743bdd89ba 100644 --- a/net/irda/iriap.c +++ b/net/irda/iriap.c | |||
@@ -502,7 +502,8 @@ static void iriap_getvaluebyclass_confirm(struct iriap_cb *self, | |||
502 | IRDA_DEBUG(4, "%s(), strlen=%d\n", __func__, value_len); | 502 | IRDA_DEBUG(4, "%s(), strlen=%d\n", __func__, value_len); |
503 | 503 | ||
504 | /* Make sure the string is null-terminated */ | 504 | /* Make sure the string is null-terminated */ |
505 | fp[n+value_len] = 0x00; | 505 | if (n + value_len < skb->len) |
506 | fp[n + value_len] = 0x00; | ||
506 | IRDA_DEBUG(4, "Got string %s\n", fp+n); | 507 | IRDA_DEBUG(4, "Got string %s\n", fp+n); |
507 | 508 | ||
508 | /* Will truncate to IAS_MAX_STRING bytes */ | 509 | /* Will truncate to IAS_MAX_STRING bytes */ |