diff options
author | David S. Miller <davem@davemloft.net> | 2012-07-17 06:29:28 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-07-17 06:29:28 -0400 |
commit | 6700c2709c08d74ae2c3c29b84a30da012dbc7f1 (patch) | |
tree | 1d44f300ec3cf5f9845fba7a25491e33d666426f /net/ipv6 | |
parent | 02f3d4ce9e81434a365f4643020b0402f6fe3332 (diff) |
net: Pass optional SKB and SK arguments to dst_ops->{update_pmtu,redirect}()
This will be used so that we can compose a full flow key.
Even though we have a route in this context, we need more. In the
future the routes will be without destination address, source address,
etc. keying. One ipv4 route will cover entire subnets, etc.
In this environment we have to have a way to possess persistent storage
for redirects and PMTU information. This persistent storage will exist
in the FIB tables, and that's why we'll need to be able to rebuild a
full lookup flow key here. Using that flow key will do a fib_lookup()
and create/update the persistent entry.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6')
-rw-r--r-- | net/ipv6/inet6_connection_sock.c | 2 | ||||
-rw-r--r-- | net/ipv6/ip6_tunnel.c | 6 | ||||
-rw-r--r-- | net/ipv6/route.c | 21 | ||||
-rw-r--r-- | net/ipv6/sit.c | 2 | ||||
-rw-r--r-- | net/ipv6/tcp_ipv6.c | 2 | ||||
-rw-r--r-- | net/ipv6/xfrm6_policy.c | 10 |
6 files changed, 25 insertions, 18 deletions
diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c index 62539a4b2dc7..4a0c4d2d8b05 100644 --- a/net/ipv6/inet6_connection_sock.c +++ b/net/ipv6/inet6_connection_sock.c | |||
@@ -269,7 +269,7 @@ struct dst_entry *inet6_csk_update_pmtu(struct sock *sk, u32 mtu) | |||
269 | 269 | ||
270 | if (IS_ERR(dst)) | 270 | if (IS_ERR(dst)) |
271 | return NULL; | 271 | return NULL; |
272 | dst->ops->update_pmtu(dst, mtu); | 272 | dst->ops->update_pmtu(dst, sk, NULL, mtu); |
273 | 273 | ||
274 | return inet6_csk_route_socket(sk); | 274 | return inet6_csk_route_socket(sk); |
275 | } | 275 | } |
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 61d106597296..db3284667968 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c | |||
@@ -609,10 +609,10 @@ ip4ip6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | |||
609 | if (rel_info > dst_mtu(skb_dst(skb2))) | 609 | if (rel_info > dst_mtu(skb_dst(skb2))) |
610 | goto out; | 610 | goto out; |
611 | 611 | ||
612 | skb_dst(skb2)->ops->update_pmtu(skb_dst(skb2), rel_info); | 612 | skb_dst(skb2)->ops->update_pmtu(skb_dst(skb2), NULL, skb2, rel_info); |
613 | } | 613 | } |
614 | if (rel_type == ICMP_REDIRECT) | 614 | if (rel_type == ICMP_REDIRECT) |
615 | skb_dst(skb2)->ops->redirect(skb_dst(skb2), skb2); | 615 | skb_dst(skb2)->ops->redirect(skb_dst(skb2), NULL, skb2); |
616 | 616 | ||
617 | icmp_send(skb2, rel_type, rel_code, htonl(rel_info)); | 617 | icmp_send(skb2, rel_type, rel_code, htonl(rel_info)); |
618 | 618 | ||
@@ -952,7 +952,7 @@ static int ip6_tnl_xmit2(struct sk_buff *skb, | |||
952 | if (mtu < IPV6_MIN_MTU) | 952 | if (mtu < IPV6_MIN_MTU) |
953 | mtu = IPV6_MIN_MTU; | 953 | mtu = IPV6_MIN_MTU; |
954 | if (skb_dst(skb)) | 954 | if (skb_dst(skb)) |
955 | skb_dst(skb)->ops->update_pmtu(skb_dst(skb), mtu); | 955 | skb_dst(skb)->ops->update_pmtu(skb_dst(skb), NULL, skb, mtu); |
956 | if (skb->len > mtu) { | 956 | if (skb->len > mtu) { |
957 | *pmtu = mtu; | 957 | *pmtu = mtu; |
958 | err = -EMSGSIZE; | 958 | err = -EMSGSIZE; |
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 2a4c8d48977f..31af1ed6c1dc 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c | |||
@@ -78,8 +78,10 @@ static int ip6_dst_gc(struct dst_ops *ops); | |||
78 | static int ip6_pkt_discard(struct sk_buff *skb); | 78 | static int ip6_pkt_discard(struct sk_buff *skb); |
79 | static int ip6_pkt_discard_out(struct sk_buff *skb); | 79 | static int ip6_pkt_discard_out(struct sk_buff *skb); |
80 | static void ip6_link_failure(struct sk_buff *skb); | 80 | static void ip6_link_failure(struct sk_buff *skb); |
81 | static void ip6_rt_update_pmtu(struct dst_entry *dst, u32 mtu); | 81 | static void ip6_rt_update_pmtu(struct dst_entry *dst, struct sock *sk, |
82 | static void rt6_do_redirect(struct dst_entry *dst, struct sk_buff *skb); | 82 | struct sk_buff *skb, u32 mtu); |
83 | static void rt6_do_redirect(struct dst_entry *dst, struct sock *sk, | ||
84 | struct sk_buff *skb); | ||
83 | 85 | ||
84 | #ifdef CONFIG_IPV6_ROUTE_INFO | 86 | #ifdef CONFIG_IPV6_ROUTE_INFO |
85 | static struct rt6_info *rt6_add_route_info(struct net *net, | 87 | static struct rt6_info *rt6_add_route_info(struct net *net, |
@@ -187,11 +189,13 @@ static unsigned int ip6_blackhole_mtu(const struct dst_entry *dst) | |||
187 | return mtu ? : dst->dev->mtu; | 189 | return mtu ? : dst->dev->mtu; |
188 | } | 190 | } |
189 | 191 | ||
190 | static void ip6_rt_blackhole_update_pmtu(struct dst_entry *dst, u32 mtu) | 192 | static void ip6_rt_blackhole_update_pmtu(struct dst_entry *dst, struct sock *sk, |
193 | struct sk_buff *skb, u32 mtu) | ||
191 | { | 194 | { |
192 | } | 195 | } |
193 | 196 | ||
194 | static void ip6_rt_blackhole_redirect(struct dst_entry *dst, struct sk_buff *skb) | 197 | static void ip6_rt_blackhole_redirect(struct dst_entry *dst, struct sock *sk, |
198 | struct sk_buff *skb) | ||
195 | { | 199 | { |
196 | } | 200 | } |
197 | 201 | ||
@@ -1071,7 +1075,8 @@ static void ip6_link_failure(struct sk_buff *skb) | |||
1071 | } | 1075 | } |
1072 | } | 1076 | } |
1073 | 1077 | ||
1074 | static void ip6_rt_update_pmtu(struct dst_entry *dst, u32 mtu) | 1078 | static void ip6_rt_update_pmtu(struct dst_entry *dst, struct sock *sk, |
1079 | struct sk_buff *skb, u32 mtu) | ||
1075 | { | 1080 | { |
1076 | struct rt6_info *rt6 = (struct rt6_info*)dst; | 1081 | struct rt6_info *rt6 = (struct rt6_info*)dst; |
1077 | 1082 | ||
@@ -1108,7 +1113,7 @@ void ip6_update_pmtu(struct sk_buff *skb, struct net *net, __be32 mtu, | |||
1108 | 1113 | ||
1109 | dst = ip6_route_output(net, NULL, &fl6); | 1114 | dst = ip6_route_output(net, NULL, &fl6); |
1110 | if (!dst->error) | 1115 | if (!dst->error) |
1111 | ip6_rt_update_pmtu(dst, ntohl(mtu)); | 1116 | ip6_rt_update_pmtu(dst, NULL, skb, ntohl(mtu)); |
1112 | dst_release(dst); | 1117 | dst_release(dst); |
1113 | } | 1118 | } |
1114 | EXPORT_SYMBOL_GPL(ip6_update_pmtu); | 1119 | EXPORT_SYMBOL_GPL(ip6_update_pmtu); |
@@ -1136,7 +1141,7 @@ void ip6_redirect(struct sk_buff *skb, struct net *net, int oif, u32 mark) | |||
1136 | 1141 | ||
1137 | dst = ip6_route_output(net, NULL, &fl6); | 1142 | dst = ip6_route_output(net, NULL, &fl6); |
1138 | if (!dst->error) | 1143 | if (!dst->error) |
1139 | rt6_do_redirect(dst, skb); | 1144 | rt6_do_redirect(dst, NULL, skb); |
1140 | dst_release(dst); | 1145 | dst_release(dst); |
1141 | } | 1146 | } |
1142 | EXPORT_SYMBOL_GPL(ip6_redirect); | 1147 | EXPORT_SYMBOL_GPL(ip6_redirect); |
@@ -1639,7 +1644,7 @@ static int ip6_route_del(struct fib6_config *cfg) | |||
1639 | return err; | 1644 | return err; |
1640 | } | 1645 | } |
1641 | 1646 | ||
1642 | static void rt6_do_redirect(struct dst_entry *dst, struct sk_buff *skb) | 1647 | static void rt6_do_redirect(struct dst_entry *dst, struct sock *sk, struct sk_buff *skb) |
1643 | { | 1648 | { |
1644 | struct net *net = dev_net(skb->dev); | 1649 | struct net *net = dev_net(skb->dev); |
1645 | struct netevent_redirect netevent; | 1650 | struct netevent_redirect netevent; |
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index fbf1622fdeef..3bd1bfc01f85 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c | |||
@@ -807,7 +807,7 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *skb, | |||
807 | } | 807 | } |
808 | 808 | ||
809 | if (tunnel->parms.iph.daddr && skb_dst(skb)) | 809 | if (tunnel->parms.iph.daddr && skb_dst(skb)) |
810 | skb_dst(skb)->ops->update_pmtu(skb_dst(skb), mtu); | 810 | skb_dst(skb)->ops->update_pmtu(skb_dst(skb), NULL, skb, mtu); |
811 | 811 | ||
812 | if (skb->len > mtu) { | 812 | if (skb->len > mtu) { |
813 | icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu); | 813 | icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu); |
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index ecdf241cad02..c9dabdd832d7 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c | |||
@@ -367,7 +367,7 @@ static void tcp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | |||
367 | struct dst_entry *dst = __sk_dst_check(sk, np->dst_cookie); | 367 | struct dst_entry *dst = __sk_dst_check(sk, np->dst_cookie); |
368 | 368 | ||
369 | if (dst) | 369 | if (dst) |
370 | dst->ops->redirect(dst,skb); | 370 | dst->ops->redirect(dst, sk, skb); |
371 | } | 371 | } |
372 | 372 | ||
373 | if (type == ICMPV6_PKT_TOOBIG) { | 373 | if (type == ICMPV6_PKT_TOOBIG) { |
diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index f5a9cb8257b9..ef39812107b1 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6/xfrm6_policy.c | |||
@@ -207,20 +207,22 @@ static inline int xfrm6_garbage_collect(struct dst_ops *ops) | |||
207 | return dst_entries_get_fast(ops) > ops->gc_thresh * 2; | 207 | return dst_entries_get_fast(ops) > ops->gc_thresh * 2; |
208 | } | 208 | } |
209 | 209 | ||
210 | static void xfrm6_update_pmtu(struct dst_entry *dst, u32 mtu) | 210 | static void xfrm6_update_pmtu(struct dst_entry *dst, struct sock *sk, |
211 | struct sk_buff *skb, u32 mtu) | ||
211 | { | 212 | { |
212 | struct xfrm_dst *xdst = (struct xfrm_dst *)dst; | 213 | struct xfrm_dst *xdst = (struct xfrm_dst *)dst; |
213 | struct dst_entry *path = xdst->route; | 214 | struct dst_entry *path = xdst->route; |
214 | 215 | ||
215 | path->ops->update_pmtu(path, mtu); | 216 | path->ops->update_pmtu(path, sk, skb, mtu); |
216 | } | 217 | } |
217 | 218 | ||
218 | static void xfrm6_redirect(struct dst_entry *dst, struct sk_buff *skb) | 219 | static void xfrm6_redirect(struct dst_entry *dst, struct sock *sk, |
220 | struct sk_buff *skb) | ||
219 | { | 221 | { |
220 | struct xfrm_dst *xdst = (struct xfrm_dst *)dst; | 222 | struct xfrm_dst *xdst = (struct xfrm_dst *)dst; |
221 | struct dst_entry *path = xdst->route; | 223 | struct dst_entry *path = xdst->route; |
222 | 224 | ||
223 | path->ops->redirect(path, skb); | 225 | path->ops->redirect(path, sk, skb); |
224 | } | 226 | } |
225 | 227 | ||
226 | static void xfrm6_dst_destroy(struct dst_entry *dst) | 228 | static void xfrm6_dst_destroy(struct dst_entry *dst) |