diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2007-03-12 19:09:15 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-04-26 01:25:07 -0400 |
commit | c9bdd4b5257406b0608385d19c40b5511decf4f6 (patch) | |
tree | fe5319c322a11c0b00e7ef0473762a8d1961da83 /net/ipv6 | |
parent | 0272ffc46f81a4bbbf302ba093c737e969c5bb55 (diff) |
[IP]: Introduce ip_hdrlen()
For the common sequence "skb->nh.iph->ihl * 4", removing a good number of open
coded skb->nh.iph uses, now to go after the rest...
Just out of curiosity, here are the idioms found to get the same result:
skb->nh.iph->ihl << 2
skb->nh.iph->ihl<<2
skb->nh.iph->ihl * 4
skb->nh.iph->ihl*4
(skb->nh.iph)->ihl * sizeof(u32)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6')
-rw-r--r-- | net/ipv6/netfilter/ip6table_filter.c | 2 | ||||
-rw-r--r-- | net/ipv6/netfilter/ip6table_mangle.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv6/netfilter/ip6table_filter.c b/net/ipv6/netfilter/ip6table_filter.c index 112a21d0c6da..76f0cf66f95c 100644 --- a/net/ipv6/netfilter/ip6table_filter.c +++ b/net/ipv6/netfilter/ip6table_filter.c | |||
@@ -102,7 +102,7 @@ ip6t_local_out_hook(unsigned int hook, | |||
102 | #if 0 | 102 | #if 0 |
103 | /* root is playing with raw sockets. */ | 103 | /* root is playing with raw sockets. */ |
104 | if ((*pskb)->len < sizeof(struct iphdr) | 104 | if ((*pskb)->len < sizeof(struct iphdr) |
105 | || (*pskb)->nh.iph->ihl * 4 < sizeof(struct iphdr)) { | 105 | || ip_hdrlen(*pskb) < sizeof(struct iphdr)) { |
106 | if (net_ratelimit()) | 106 | if (net_ratelimit()) |
107 | printk("ip6t_hook: happy cracking.\n"); | 107 | printk("ip6t_hook: happy cracking.\n"); |
108 | return NF_ACCEPT; | 108 | return NF_ACCEPT; |
diff --git a/net/ipv6/netfilter/ip6table_mangle.c b/net/ipv6/netfilter/ip6table_mangle.c index 0c468d35a937..da2c1994539b 100644 --- a/net/ipv6/netfilter/ip6table_mangle.c +++ b/net/ipv6/netfilter/ip6table_mangle.c | |||
@@ -138,7 +138,7 @@ ip6t_local_hook(unsigned int hook, | |||
138 | #if 0 | 138 | #if 0 |
139 | /* root is playing with raw sockets. */ | 139 | /* root is playing with raw sockets. */ |
140 | if ((*pskb)->len < sizeof(struct iphdr) | 140 | if ((*pskb)->len < sizeof(struct iphdr) |
141 | || (*pskb)->nh.iph->ihl * 4 < sizeof(struct iphdr)) { | 141 | || ip_hdrlen(*pskb) < sizeof(struct iphdr)) { |
142 | if (net_ratelimit()) | 142 | if (net_ratelimit()) |
143 | printk("ip6t_hook: happy cracking.\n"); | 143 | printk("ip6t_hook: happy cracking.\n"); |
144 | return NF_ACCEPT; | 144 | return NF_ACCEPT; |