diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2007-03-13 16:10:43 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-04-26 01:25:29 -0400 |
commit | bd82393ca23324d103b21aae43160728da6e6c9c (patch) | |
tree | c3795389947032eb8d79c269031232aa6293960e /net/ipv6 | |
parent | 39b89160df691045d1449cbaef43c02084c7543a (diff) |
[SK_BUFF]: More skb_reset_transport_header conversions
These are a bit more subtle, they are of this type:
- skb->h.raw = payload;
__skb_pull(skb, payload - skb->data);
+ skb_reset_transport_header(skb);
__skb_pull results in:
skb->data = skb->data + payload - skb->data;
skb->data = payload;
So after __skb_pull we have skb->data pointing to payload and we can
just call skb_reset_transport_header(skb), that will do:
skb->h.raw = payload;
The others are similar, allowing us to get rid of some more cases where a
pointer was being attributed to the layer headers.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6')
-rw-r--r-- | net/ipv6/datagram.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv6/datagram.c b/net/ipv6/datagram.c index feba6b197fe9..f16f4f0c5814 100644 --- a/net/ipv6/datagram.c +++ b/net/ipv6/datagram.c | |||
@@ -231,8 +231,8 @@ void ipv6_icmp_error(struct sock *sk, struct sk_buff *skb, int err, | |||
231 | skb_network_header(skb); | 231 | skb_network_header(skb); |
232 | serr->port = port; | 232 | serr->port = port; |
233 | 233 | ||
234 | skb->h.raw = payload; | ||
235 | __skb_pull(skb, payload - skb->data); | 234 | __skb_pull(skb, payload - skb->data); |
235 | skb_reset_transport_header(skb); | ||
236 | 236 | ||
237 | if (sock_queue_err_skb(sk, skb)) | 237 | if (sock_queue_err_skb(sk, skb)) |
238 | kfree_skb(skb); | 238 | kfree_skb(skb); |
@@ -268,8 +268,8 @@ void ipv6_local_error(struct sock *sk, int err, struct flowi *fl, u32 info) | |||
268 | serr->addr_offset = (u8 *)&iph->daddr - skb_network_header(skb); | 268 | serr->addr_offset = (u8 *)&iph->daddr - skb_network_header(skb); |
269 | serr->port = fl->fl_ip_dport; | 269 | serr->port = fl->fl_ip_dport; |
270 | 270 | ||
271 | skb->h.raw = skb->tail; | ||
272 | __skb_pull(skb, skb->tail - skb->data); | 271 | __skb_pull(skb, skb->tail - skb->data); |
272 | skb_reset_transport_header(skb); | ||
273 | 273 | ||
274 | if (sock_queue_err_skb(sk, skb)) | 274 | if (sock_queue_err_skb(sk, skb)) |
275 | kfree_skb(skb); | 275 | kfree_skb(skb); |