diff options
author | Patrick McHardy <kaber@trash.net> | 2006-01-07 02:04:54 -0500 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-01-07 15:57:33 -0500 |
commit | 3e3850e989c5d2eb1aab6f0fd9257759f0f4cbc6 (patch) | |
tree | fa05d1de4767bc30e77442ffbacfe8bd8dd2213d /net/ipv6 | |
parent | 8cdfab8a43bb4b3da686ea503a702cb6f9f6a803 (diff) |
[NETFILTER]: Fix xfrm lookup in ip_route_me_harder/ip6_route_me_harder
ip_route_me_harder doesn't use the port numbers of the xfrm lookup and
uses ip_route_input for non-local addresses which doesn't do a xfrm
lookup, ip6_route_me_harder doesn't do a xfrm lookup at all.
Use xfrm_decode_session and do the lookup manually, make sure both
only do the lookup if the packet hasn't been transformed already.
Makeing sure the lookup only happens once needs a new field in the
IP6CB, which exceeds the size of skb->cb. The size of skb->cb is
increased to 48b. Apparently the IPv6 mobile extensions need some
more room anyway.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6')
-rw-r--r-- | net/ipv6/netfilter.c | 9 | ||||
-rw-r--r-- | net/ipv6/xfrm6_output.c | 1 |
2 files changed, 9 insertions, 1 deletions
diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c index f8626ebf90fd..b63678328a3b 100644 --- a/net/ipv6/netfilter.c +++ b/net/ipv6/netfilter.c | |||
@@ -10,6 +10,7 @@ | |||
10 | #include <net/dst.h> | 10 | #include <net/dst.h> |
11 | #include <net/ipv6.h> | 11 | #include <net/ipv6.h> |
12 | #include <net/ip6_route.h> | 12 | #include <net/ip6_route.h> |
13 | #include <net/xfrm.h> | ||
13 | 14 | ||
14 | int ip6_route_me_harder(struct sk_buff *skb) | 15 | int ip6_route_me_harder(struct sk_buff *skb) |
15 | { | 16 | { |
@@ -21,11 +22,17 @@ int ip6_route_me_harder(struct sk_buff *skb) | |||
21 | { .ip6_u = | 22 | { .ip6_u = |
22 | { .daddr = iph->daddr, | 23 | { .daddr = iph->daddr, |
23 | .saddr = iph->saddr, } }, | 24 | .saddr = iph->saddr, } }, |
24 | .proto = iph->nexthdr, | ||
25 | }; | 25 | }; |
26 | 26 | ||
27 | dst = ip6_route_output(skb->sk, &fl); | 27 | dst = ip6_route_output(skb->sk, &fl); |
28 | 28 | ||
29 | #ifdef CONFIG_XFRM | ||
30 | if (!(IP6CB(skb)->flags & IP6SKB_XFRM_TRANSFORMED) && | ||
31 | xfrm_decode_session(skb, &fl, AF_INET6) == 0) | ||
32 | if (xfrm_lookup(&skb->dst, &fl, skb->sk, 0)) | ||
33 | return -1; | ||
34 | #endif | ||
35 | |||
29 | if (dst->error) { | 36 | if (dst->error) { |
30 | IP6_INC_STATS(IPSTATS_MIB_OUTNOROUTES); | 37 | IP6_INC_STATS(IPSTATS_MIB_OUTNOROUTES); |
31 | LIMIT_NETDEBUG(KERN_DEBUG "ip6_route_me_harder: No more route.\n"); | 38 | LIMIT_NETDEBUG(KERN_DEBUG "ip6_route_me_harder: No more route.\n"); |
diff --git a/net/ipv6/xfrm6_output.c b/net/ipv6/xfrm6_output.c index fc0ea38953c4..80242172a5df 100644 --- a/net/ipv6/xfrm6_output.c +++ b/net/ipv6/xfrm6_output.c | |||
@@ -139,6 +139,7 @@ static int xfrm6_output_one(struct sk_buff *skb) | |||
139 | x = dst->xfrm; | 139 | x = dst->xfrm; |
140 | } while (x && !x->props.mode); | 140 | } while (x && !x->props.mode); |
141 | 141 | ||
142 | IP6CB(skb)->flags |= IP6SKB_XFRM_TRANSFORMED; | ||
142 | err = 0; | 143 | err = 0; |
143 | 144 | ||
144 | out_exit: | 145 | out_exit: |