diff options
author | Herbert Xu <herbert@gondor.apana.org.au> | 2007-10-10 18:44:06 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 19:55:54 -0400 |
commit | 7b277b1a5fb147cb828e5d8b9780cee60f31a9bf (patch) | |
tree | 21af4818d7ba9d646a281517f476d81d4245cc30 /net/ipv6/xfrm6_mode_ro.c | |
parent | bee0b40c0621396326d1c17b81833f59118a2d80 (diff) |
[IPSEC]: Set skb->data to payload in x->mode->output
This patch changes the calling convention so that on entry from
x->mode->output and before entry into x->type->output skb->data
will point to the payload instead of the IP header.
This is essentially a redistribution of skb_push/skb_pull calls
with the aim of minimising them on the common path of tunnel +
ESP.
It'll also let us use the same calling convention between IPv4
and IPv6 with the next patch.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/xfrm6_mode_ro.c')
-rw-r--r-- | net/ipv6/xfrm6_mode_ro.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/net/ipv6/xfrm6_mode_ro.c b/net/ipv6/xfrm6_mode_ro.c index 25758048af54..5c29b367b432 100644 --- a/net/ipv6/xfrm6_mode_ro.c +++ b/net/ipv6/xfrm6_mode_ro.c | |||
@@ -42,8 +42,8 @@ | |||
42 | * filled in by x->type->output and the mac header will be set to the | 42 | * filled in by x->type->output and the mac header will be set to the |
43 | * nextheader field of the extension header directly preceding the | 43 | * nextheader field of the extension header directly preceding the |
44 | * encapsulation header, or in its absence, that of the top IP header. | 44 | * encapsulation header, or in its absence, that of the top IP header. |
45 | * The value of skb->data and the network header will always point to the | 45 | * The value of the network header will always point to the top IP header |
46 | * top IP header. | 46 | * while skb->data will point to the payload. |
47 | */ | 47 | */ |
48 | static int xfrm6_ro_output(struct xfrm_state *x, struct sk_buff *skb) | 48 | static int xfrm6_ro_output(struct xfrm_state *x, struct sk_buff *skb) |
49 | { | 49 | { |
@@ -51,14 +51,14 @@ static int xfrm6_ro_output(struct xfrm_state *x, struct sk_buff *skb) | |||
51 | u8 *prevhdr; | 51 | u8 *prevhdr; |
52 | int hdr_len; | 52 | int hdr_len; |
53 | 53 | ||
54 | skb_push(skb, x->props.header_len); | ||
55 | iph = ipv6_hdr(skb); | 54 | iph = ipv6_hdr(skb); |
56 | 55 | ||
57 | hdr_len = x->type->hdr_offset(x, skb, &prevhdr); | 56 | hdr_len = x->type->hdr_offset(x, skb, &prevhdr); |
58 | skb_set_mac_header(skb, (prevhdr - x->props.header_len) - skb->data); | 57 | skb_set_mac_header(skb, (prevhdr - x->props.header_len) - skb->data); |
59 | skb_reset_network_header(skb); | 58 | skb_set_network_header(skb, -x->props.header_len); |
60 | skb_set_transport_header(skb, hdr_len); | 59 | skb_set_transport_header(skb, hdr_len - x->props.header_len); |
61 | memmove(skb->data, iph, hdr_len); | 60 | __skb_pull(skb, hdr_len); |
61 | memmove(ipv6_hdr(skb), iph, hdr_len); | ||
62 | 62 | ||
63 | x->lastused = get_seconds(); | 63 | x->lastused = get_seconds(); |
64 | 64 | ||